mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
a19e91f0fa
#30985 caused `object.save` performance regression since calling `changes` in `changes_applied` is very slow. We don't need to call the expensive method in `changes_applied` as long as `@attributes` is tracked by mutation tracker. https://gist.github.com/kamipo/1a9f4f3891803b914fc72ede98268aa2 Before: ``` Warming up -------------------------------------- create_string_columns 73.000 i/100ms Calculating ------------------------------------- create_string_columns 722.256 (± 5.8%) i/s - 3.650k in 5.073031s ``` After: ``` Warming up -------------------------------------- create_string_columns 96.000 i/100ms Calculating ------------------------------------- create_string_columns 950.224 (± 7.7%) i/s - 4.800k in 5.084837s ```
311 lines
9.2 KiB
Ruby
311 lines
9.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "active_support/hash_with_indifferent_access"
|
|
require "active_support/core_ext/object/duplicable"
|
|
require "active_model/attribute_mutation_tracker"
|
|
require "active_model/attribute_set"
|
|
|
|
module ActiveModel
|
|
# == Active \Model \Dirty
|
|
#
|
|
# Provides a way to track changes in your object in the same way as
|
|
# Active Record does.
|
|
#
|
|
# The requirements for implementing ActiveModel::Dirty are:
|
|
#
|
|
# * <tt>include ActiveModel::Dirty</tt> in your object.
|
|
# * Call <tt>define_attribute_methods</tt> passing each method you want to
|
|
# track.
|
|
# * Call <tt>[attr_name]_will_change!</tt> before each change to the tracked
|
|
# attribute.
|
|
# * Call <tt>changes_applied</tt> after the changes are persisted.
|
|
# * Call <tt>clear_changes_information</tt> when you want to reset the changes
|
|
# information.
|
|
# * Call <tt>restore_attributes</tt> when you want to restore previous data.
|
|
#
|
|
# A minimal implementation could be:
|
|
#
|
|
# class Person
|
|
# include ActiveModel::Dirty
|
|
#
|
|
# define_attribute_methods :name
|
|
#
|
|
# def initialize
|
|
# @name = nil
|
|
# end
|
|
#
|
|
# def name
|
|
# @name
|
|
# end
|
|
#
|
|
# def name=(val)
|
|
# name_will_change! unless val == @name
|
|
# @name = val
|
|
# end
|
|
#
|
|
# def save
|
|
# # do persistence work
|
|
#
|
|
# changes_applied
|
|
# end
|
|
#
|
|
# def reload!
|
|
# # get the values from the persistence layer
|
|
#
|
|
# clear_changes_information
|
|
# end
|
|
#
|
|
# def rollback!
|
|
# restore_attributes
|
|
# end
|
|
# end
|
|
#
|
|
# A newly instantiated +Person+ object is unchanged:
|
|
#
|
|
# person = Person.new
|
|
# person.changed? # => false
|
|
#
|
|
# Change the name:
|
|
#
|
|
# person.name = 'Bob'
|
|
# person.changed? # => true
|
|
# person.name_changed? # => true
|
|
# person.name_changed?(from: nil, to: "Bob") # => true
|
|
# person.name_was # => nil
|
|
# person.name_change # => [nil, "Bob"]
|
|
# person.name = 'Bill'
|
|
# person.name_change # => [nil, "Bill"]
|
|
#
|
|
# Save the changes:
|
|
#
|
|
# person.save
|
|
# person.changed? # => false
|
|
# person.name_changed? # => false
|
|
#
|
|
# Reset the changes:
|
|
#
|
|
# person.previous_changes # => {"name" => [nil, "Bill"]}
|
|
# person.name_previously_changed? # => true
|
|
# person.name_previous_change # => [nil, "Bill"]
|
|
# person.reload!
|
|
# person.previous_changes # => {}
|
|
#
|
|
# Rollback the changes:
|
|
#
|
|
# person.name = "Uncle Bob"
|
|
# person.rollback!
|
|
# person.name # => "Bill"
|
|
# person.name_changed? # => false
|
|
#
|
|
# Assigning the same value leaves the attribute unchanged:
|
|
#
|
|
# person.name = 'Bill'
|
|
# person.name_changed? # => false
|
|
# person.name_change # => nil
|
|
#
|
|
# Which attributes have changed?
|
|
#
|
|
# person.name = 'Bob'
|
|
# person.changed # => ["name"]
|
|
# person.changes # => {"name" => ["Bill", "Bob"]}
|
|
#
|
|
# If an attribute is modified in-place then make use of
|
|
# <tt>[attribute_name]_will_change!</tt> to mark that the attribute is changing.
|
|
# Otherwise \Active \Model can't track changes to in-place attributes. Note
|
|
# that Active Record can detect in-place modifications automatically. You do
|
|
# not need to call <tt>[attribute_name]_will_change!</tt> on Active Record models.
|
|
#
|
|
# person.name_will_change!
|
|
# person.name_change # => ["Bill", "Bill"]
|
|
# person.name << 'y'
|
|
# person.name_change # => ["Bill", "Billy"]
|
|
module Dirty
|
|
extend ActiveSupport::Concern
|
|
include ActiveModel::AttributeMethods
|
|
|
|
OPTION_NOT_GIVEN = Object.new # :nodoc:
|
|
private_constant :OPTION_NOT_GIVEN
|
|
|
|
included do
|
|
attribute_method_suffix "_changed?", "_change", "_will_change!", "_was"
|
|
attribute_method_suffix "_previously_changed?", "_previous_change"
|
|
attribute_method_affix prefix: "restore_", suffix: "!"
|
|
end
|
|
|
|
def initialize_dup(other) # :nodoc:
|
|
super
|
|
if self.class.respond_to?(:_default_attributes)
|
|
@attributes = self.class._default_attributes.map do |attr|
|
|
attr.with_value_from_user(@attributes.fetch_value(attr.name))
|
|
end
|
|
end
|
|
@mutations_from_database = nil
|
|
end
|
|
|
|
def changes_applied # :nodoc:
|
|
_prepare_changes
|
|
@mutations_before_last_save = mutations_from_database
|
|
forget_attribute_assignments
|
|
@mutations_from_database = nil
|
|
end
|
|
|
|
# Returns +true+ if any of the attributes have unsaved changes, +false+ otherwise.
|
|
#
|
|
# person.changed? # => false
|
|
# person.name = 'bob'
|
|
# person.changed? # => true
|
|
def changed?
|
|
mutations_from_database.any_changes?
|
|
end
|
|
|
|
# Returns an array with the name of the attributes with unsaved changes.
|
|
#
|
|
# person.changed # => []
|
|
# person.name = 'bob'
|
|
# person.changed # => ["name"]
|
|
def changed
|
|
mutations_from_database.changed_attribute_names
|
|
end
|
|
|
|
# Handles <tt>*_changed?</tt> for +method_missing+.
|
|
def attribute_changed?(attr, from: OPTION_NOT_GIVEN, to: OPTION_NOT_GIVEN) # :nodoc:
|
|
!!mutations_from_database.changed?(attr) &&
|
|
(to == OPTION_NOT_GIVEN || to == _read_attribute(attr)) &&
|
|
(from == OPTION_NOT_GIVEN || from == attribute_was(attr))
|
|
end
|
|
|
|
# Handles <tt>*_was</tt> for +method_missing+.
|
|
def attribute_was(attr) # :nodoc:
|
|
mutations_from_database.original_value(attr)
|
|
end
|
|
|
|
# Handles <tt>*_previously_changed?</tt> for +method_missing+.
|
|
def attribute_previously_changed?(attr) #:nodoc:
|
|
mutations_before_last_save.changed?(attr)
|
|
end
|
|
|
|
# Restore all previous data of the provided attributes.
|
|
def restore_attributes(attributes = changed)
|
|
attributes.each { |attr| restore_attribute! attr }
|
|
end
|
|
|
|
# Clears all dirty data: current changes and previous changes.
|
|
def clear_changes_information
|
|
@mutations_before_last_save = nil
|
|
forget_attribute_assignments
|
|
@mutations_from_database = nil
|
|
end
|
|
|
|
def clear_attribute_changes(attr_names)
|
|
attr_names.each do |attr_name|
|
|
clear_attribute_change(attr_name)
|
|
end
|
|
end
|
|
|
|
# Returns a hash of the attributes with unsaved changes indicating their original
|
|
# values like <tt>attr => original value</tt>.
|
|
#
|
|
# person.name # => "bob"
|
|
# person.name = 'robert'
|
|
# person.changed_attributes # => {"name" => "bob"}
|
|
def changed_attributes
|
|
mutations_from_database.changed_values.freeze
|
|
end
|
|
|
|
# Returns a hash of changed attributes indicating their original
|
|
# and new values like <tt>attr => [original value, new value]</tt>.
|
|
#
|
|
# person.changes # => {}
|
|
# person.name = 'bob'
|
|
# person.changes # => { "name" => ["bill", "bob"] }
|
|
def changes
|
|
_prepare_changes
|
|
mutations_from_database.changes
|
|
end
|
|
|
|
# Returns a hash of attributes that were changed before the model was saved.
|
|
#
|
|
# person.name # => "bob"
|
|
# person.name = 'robert'
|
|
# person.save
|
|
# person.previous_changes # => {"name" => ["bob", "robert"]}
|
|
def previous_changes
|
|
mutations_before_last_save.changes
|
|
end
|
|
|
|
def attribute_changed_in_place?(attr_name) # :nodoc:
|
|
mutations_from_database.changed_in_place?(attr_name)
|
|
end
|
|
|
|
private
|
|
def clear_attribute_change(attr_name)
|
|
mutations_from_database.forget_change(attr_name)
|
|
end
|
|
|
|
def mutations_from_database
|
|
unless defined?(@mutations_from_database)
|
|
@mutations_from_database = nil
|
|
end
|
|
|
|
unless defined?(@attributes)
|
|
@_pseudo_attributes = true
|
|
@attributes = AttributeSet.new(
|
|
Hash.new { |h, attr|
|
|
h[attr] = Attribute.with_cast_value(attr, _clone_attribute(attr), Type.default_value)
|
|
}
|
|
)
|
|
end
|
|
|
|
@mutations_from_database ||= ActiveModel::AttributeMutationTracker.new(@attributes)
|
|
end
|
|
|
|
def forget_attribute_assignments
|
|
@attributes = @attributes.map(&:forgetting_assignment) if defined?(@attributes)
|
|
end
|
|
|
|
def mutations_before_last_save
|
|
@mutations_before_last_save ||= ActiveModel::NullMutationTracker.instance
|
|
end
|
|
|
|
# Handles <tt>*_change</tt> for +method_missing+.
|
|
def attribute_change(attr)
|
|
[attribute_was(attr), _read_attribute(attr)] if attribute_changed?(attr)
|
|
end
|
|
|
|
# Handles <tt>*_previous_change</tt> for +method_missing+.
|
|
def attribute_previous_change(attr)
|
|
mutations_before_last_save.change_to_attribute(attr)
|
|
end
|
|
|
|
# Handles <tt>*_will_change!</tt> for +method_missing+.
|
|
def attribute_will_change!(attr)
|
|
attr = attr.to_s
|
|
mutations_from_database.force_change(attr).tap do
|
|
@attributes[attr] if defined?(@_pseudo_attributes)
|
|
end
|
|
end
|
|
|
|
# Handles <tt>restore_*!</tt> for +method_missing+.
|
|
def restore_attribute!(attr)
|
|
if attribute_changed?(attr)
|
|
__send__("#{attr}=", attribute_was(attr))
|
|
clear_attribute_changes([attr])
|
|
end
|
|
end
|
|
|
|
def _prepare_changes
|
|
if defined?(@_pseudo_attributes)
|
|
changed.each do |attr|
|
|
@attributes.write_from_user(attr, _read_attribute(attr))
|
|
end
|
|
end
|
|
end
|
|
|
|
def _clone_attribute(attr)
|
|
value = _read_attribute(attr)
|
|
value.duplicable? ? value.clone : value
|
|
rescue TypeError, NoMethodError
|
|
value
|
|
end
|
|
end
|
|
end
|