mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
b4cab6a854
In some cases, the framework was mutating the :if option of callbacks. Since #38323, those options are frozen, so the framework could raise exception when trying to mutate those options if they were being resued with method like `with_options`.
144 lines
4.1 KiB
Ruby
144 lines
4.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "cases/helper"
|
|
|
|
class CallbacksTest < ActiveModel::TestCase
|
|
class CallbackValidator
|
|
def around_create(model)
|
|
model.callbacks << :before_around_create
|
|
yield
|
|
model.callbacks << :after_around_create
|
|
false
|
|
end
|
|
end
|
|
|
|
class ModelCallbacks
|
|
attr_reader :callbacks
|
|
extend ActiveModel::Callbacks
|
|
|
|
define_model_callbacks :create
|
|
define_model_callbacks :initialize, only: :after
|
|
define_model_callbacks :multiple, only: [:before, :around]
|
|
define_model_callbacks :empty, only: []
|
|
|
|
before_create :before_create
|
|
around_create CallbackValidator.new
|
|
|
|
after_create do |model|
|
|
model.callbacks << :after_create
|
|
false
|
|
end
|
|
|
|
after_create { |model| model.callbacks << :final_callback }
|
|
|
|
def initialize(options = {})
|
|
@callbacks = []
|
|
@valid = options[:valid]
|
|
@before_create_returns = options.fetch(:before_create_returns, true)
|
|
@before_create_throws = options[:before_create_throws]
|
|
end
|
|
|
|
def before_create
|
|
@callbacks << :before_create
|
|
throw(@before_create_throws) if @before_create_throws
|
|
@before_create_returns
|
|
end
|
|
|
|
def create
|
|
run_callbacks :create do
|
|
@callbacks << :create
|
|
@valid
|
|
end
|
|
end
|
|
end
|
|
|
|
test "complete callback chain" do
|
|
model = ModelCallbacks.new
|
|
model.create
|
|
assert_equal model.callbacks, [ :before_create, :before_around_create, :create,
|
|
:after_around_create, :after_create, :final_callback]
|
|
end
|
|
|
|
test "the callback chain is not halted when around or after callbacks return false" do
|
|
model = ModelCallbacks.new
|
|
model.create
|
|
assert_equal model.callbacks.last, :final_callback
|
|
end
|
|
|
|
test "the callback chain is not halted when a before callback returns false)" do
|
|
model = ModelCallbacks.new(before_create_returns: false)
|
|
model.create
|
|
assert_equal model.callbacks.last, :final_callback
|
|
end
|
|
|
|
test "the callback chain is halted when a callback throws :abort" do
|
|
model = ModelCallbacks.new(before_create_throws: :abort)
|
|
model.create
|
|
assert_equal model.callbacks, [:before_create]
|
|
end
|
|
|
|
test "after callbacks are not executed if the block returns false" do
|
|
model = ModelCallbacks.new(valid: false)
|
|
model.create
|
|
assert_equal model.callbacks, [ :before_create, :before_around_create,
|
|
:create, :after_around_create]
|
|
end
|
|
|
|
test "only selects which types of callbacks should be created" do
|
|
assert_not_respond_to ModelCallbacks, :before_initialize
|
|
assert_not_respond_to ModelCallbacks, :around_initialize
|
|
assert_respond_to ModelCallbacks, :after_initialize
|
|
end
|
|
|
|
test "only selects which types of callbacks should be created from an array list" do
|
|
assert_respond_to ModelCallbacks, :before_multiple
|
|
assert_respond_to ModelCallbacks, :around_multiple
|
|
assert_not_respond_to ModelCallbacks, :after_multiple
|
|
end
|
|
|
|
test "no callbacks should be created" do
|
|
assert_not_respond_to ModelCallbacks, :before_empty
|
|
assert_not_respond_to ModelCallbacks, :around_empty
|
|
assert_not_respond_to ModelCallbacks, :after_empty
|
|
end
|
|
|
|
test "the :if option array should not be mutated by an after callback" do
|
|
opts = []
|
|
|
|
Class.new(ModelCallbacks) do
|
|
after_create(if: opts) { }
|
|
end
|
|
|
|
assert_empty opts
|
|
end
|
|
|
|
class Violin
|
|
attr_reader :history
|
|
def initialize
|
|
@history = []
|
|
end
|
|
extend ActiveModel::Callbacks
|
|
define_model_callbacks :create
|
|
def callback1; history << "callback1"; end
|
|
def callback2; history << "callback2"; end
|
|
def create
|
|
run_callbacks(:create) { }
|
|
self
|
|
end
|
|
end
|
|
class Violin1 < Violin
|
|
after_create :callback1, :callback2
|
|
end
|
|
class Violin2 < Violin
|
|
after_create :callback1
|
|
after_create :callback2
|
|
end
|
|
|
|
test "after_create callbacks with both callbacks declared in one line" do
|
|
assert_equal ["callback1", "callback2"], Violin1.new.create.history
|
|
end
|
|
|
|
test "after_create callbacks with both callbacks declared in different lines" do
|
|
assert_equal ["callback1", "callback2"], Violin2.new.create.history
|
|
end
|
|
end
|