mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
c2ca73c9ee
`Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord callback chains) and has extra features (like `changed`) that were never used. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
182 lines
4.5 KiB
Ruby
182 lines
4.5 KiB
Ruby
require 'cases/helper'
|
|
require 'models/topic'
|
|
require 'models/developer'
|
|
require 'models/reply'
|
|
require 'models/minimalistic'
|
|
require 'models/comment'
|
|
|
|
class SpecialDeveloper < Developer; end
|
|
|
|
class SalaryChecker < ActiveRecord::Observer
|
|
observe :special_developer
|
|
|
|
def before_save(developer)
|
|
return developer.salary > 80000
|
|
end
|
|
end
|
|
|
|
class TopicaAuditor < ActiveRecord::Observer
|
|
observe :topic
|
|
|
|
attr_reader :topic
|
|
|
|
def after_find(topic)
|
|
@topic = topic
|
|
end
|
|
end
|
|
|
|
class TopicObserver < ActiveRecord::Observer
|
|
attr_reader :topic
|
|
|
|
def after_find(topic)
|
|
@topic = topic
|
|
end
|
|
|
|
# Create an after_save callback, so a notify_observer hook is created
|
|
# on :topic.
|
|
def after_save(nothing)
|
|
end
|
|
end
|
|
|
|
class MinimalisticObserver < ActiveRecord::Observer
|
|
attr_reader :minimalistic
|
|
|
|
def after_find(minimalistic)
|
|
@minimalistic = minimalistic
|
|
end
|
|
end
|
|
|
|
class MultiObserver < ActiveRecord::Observer
|
|
attr_reader :record
|
|
|
|
def self.observed_class() [ Topic, Developer ] end
|
|
|
|
cattr_reader :last_inherited
|
|
@@last_inherited = nil
|
|
|
|
def observed_class_inherited_with_testing(subclass)
|
|
observed_class_inherited_without_testing(subclass)
|
|
@@last_inherited = subclass
|
|
end
|
|
|
|
alias_method_chain :observed_class_inherited, :testing
|
|
|
|
def after_find(record)
|
|
@record = record
|
|
end
|
|
end
|
|
|
|
class ValidatedComment < Comment
|
|
attr_accessor :callers
|
|
|
|
before_validation :record_callers
|
|
|
|
after_validation do
|
|
record_callers
|
|
end
|
|
|
|
def record_callers
|
|
callers << self.class if callers
|
|
end
|
|
end
|
|
|
|
class ValidatedCommentObserver < ActiveRecord::Observer
|
|
attr_accessor :callers
|
|
|
|
def after_validation(model)
|
|
callers << self.class if callers
|
|
end
|
|
end
|
|
|
|
class LifecycleTest < ActiveRecord::TestCase
|
|
fixtures :topics, :developers, :minimalistics
|
|
|
|
def test_before_destroy
|
|
original_count = Topic.count
|
|
(topic_to_be_destroyed = Topic.find(1)).destroy
|
|
assert_equal original_count - (1 + topic_to_be_destroyed.replies.size), Topic.count
|
|
end
|
|
|
|
def test_auto_observer
|
|
topic_observer = TopicaAuditor.instance
|
|
assert_nil TopicaAuditor.observed_class
|
|
assert_equal [Topic], TopicaAuditor.instance.observed_classes.to_a
|
|
|
|
topic = Topic.find(1)
|
|
assert_equal topic.title, topic_observer.topic.title
|
|
end
|
|
|
|
def test_inferred_auto_observer
|
|
topic_observer = TopicObserver.instance
|
|
assert_equal Topic, TopicObserver.observed_class
|
|
|
|
topic = Topic.find(1)
|
|
assert_equal topic.title, topic_observer.topic.title
|
|
end
|
|
|
|
def test_observing_two_classes
|
|
multi_observer = MultiObserver.instance
|
|
|
|
topic = Topic.find(1)
|
|
assert_equal topic.title, multi_observer.record.title
|
|
|
|
developer = Developer.find(1)
|
|
assert_equal developer.name, multi_observer.record.name
|
|
end
|
|
|
|
def test_observing_subclasses
|
|
multi_observer = MultiObserver.instance
|
|
|
|
developer = SpecialDeveloper.find(1)
|
|
assert_equal developer.name, multi_observer.record.name
|
|
|
|
klass = Class.new(Developer)
|
|
assert_equal klass, multi_observer.last_inherited
|
|
|
|
developer = klass.find(1)
|
|
assert_equal developer.name, multi_observer.record.name
|
|
end
|
|
|
|
def test_after_find_can_be_observed_when_its_not_defined_on_the_model
|
|
observer = MinimalisticObserver.instance
|
|
assert_equal Minimalistic, MinimalisticObserver.observed_class
|
|
|
|
minimalistic = Minimalistic.find(1)
|
|
assert_equal minimalistic, observer.minimalistic
|
|
end
|
|
|
|
def test_after_find_can_be_observed_when_its_defined_on_the_model
|
|
observer = TopicObserver.instance
|
|
assert_equal Topic, TopicObserver.observed_class
|
|
|
|
topic = Topic.find(1)
|
|
assert_equal topic, observer.topic
|
|
end
|
|
|
|
def test_invalid_observer
|
|
assert_raise(ArgumentError) { Topic.observers = Object.new; Topic.instantiate_observers }
|
|
end
|
|
|
|
test "model callbacks fire before observers are notified" do
|
|
callers = []
|
|
|
|
comment = ValidatedComment.new
|
|
comment.callers = ValidatedCommentObserver.instance.callers = callers
|
|
|
|
comment.valid?
|
|
assert_equal [ValidatedComment, ValidatedComment, ValidatedCommentObserver], callers,
|
|
"model callbacks did not fire before observers were notified"
|
|
end
|
|
|
|
test "able to save developer" do
|
|
SalaryChecker.instance # activate
|
|
developer = SpecialDeveloper.new :name => 'Roger', :salary => 100000
|
|
assert developer.save, "developer with normal salary failed to save"
|
|
end
|
|
|
|
test "unable to save developer with low salary" do
|
|
SalaryChecker.instance # activate
|
|
developer = SpecialDeveloper.new :name => 'Rookie', :salary => 50000
|
|
assert !developer.save, "allowed to save a developer with too low salary"
|
|
end
|
|
end
|