1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/railties/test
Masaki Hara 89f5789aad Delay ActionDispatch::Response configuration to load-time
It fixes the problem in propagating return_only_media_type_on_content_type
and fixes the corresponding test being ineffective.

The mentioned test addes the following line:
...config.action_dispatch.return_only_media_type_on_content_type = true
to the config and checks if it takes effect. However, in this scenario,
the value is already true before this line.
Moreover, the users are supposed to flip this from true to false in real
situations.

This commit flips the config in the test, making it to fail as
expected. The next commit will fix the failure.

In order for return_only_media_type_on_content_type to appropriately
take effect on ActionDispatch::Response, we want to know when
ActionDispatch::Response is loaded.
As load hooks for ActionDispatch would be too broad, the appropriate
registry is for ActionDispatch::Response itself.

Looking into other examples, a hook name is a full class name in
snake case with `_base` suffix omitted, if any. Therefore, in this case,
:action_dispatch_response seems appropriate.
2019-10-01 17:42:05 +09:00
..
application Delay ActionDispatch::Response configuration to load-time 2019-10-01 17:42:05 +09:00
command Fix deeply nested namespace command printing 2019-01-24 12:28:43 -05:00
commands Use symbols everywhere for database configurations 2019-09-13 08:53:22 -04:00
configuration Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
engine Make Webpacker the default JavaScript compiler for Rails 6 (#33079) 2018-09-30 22:31:21 -07:00
fixtures/lib Remove unused fixtures 2017-09-26 07:45:42 +09:00
generators Explicitly require active_record/migration 2019-09-29 08:07:14 +09:00
isolation create an attribute so that webpacker can set its default path instead of hardcoding 2019-08-13 15:20:59 -05:00
minitest rubocop single space after assignment 2018-02-19 11:23:47 +05:30
railties Use match? where we don't need MatchData 2019-07-29 14:23:10 +09:00
test_unit Show rails instead of bin/rails on USAGE instructions 2018-07-06 22:46:54 +02:00
abstract_unit.rb Revert "You give jruby_skip & rubinius_skip a good name" 2019-08-02 00:24:11 -04:00
app_loader_test.rb Turn on performance based cops 2018-07-23 15:37:06 -07:00
backtrace_cleaner_test.rb Find query_source_location using lazy Enumerator 2019-04-15 16:13:06 -07:00
code_statistics_calculator_test.rb use "minitest" consistently 2018-09-11 23:57:25 +02:00
code_statistics_test.rb Adding frozen_string_literal pragma to Railties. 2017-08-14 19:08:09 +02:00
console_helpers.rb Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
engine_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
env_helpers.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
generators_test.rb Do not show suggestion message when not exist suggestion 2018-12-29 18:57:55 +09:00
initializable_test.rb Adding frozen_string_literal pragma to Railties. 2017-08-14 19:08:09 +02:00
json_params_parsing_test.rb Adding frozen_string_literal pragma to Railties. 2017-08-14 19:08:09 +02:00
path_generation_test.rb Remove deprecated config.secret_token 2019-01-17 16:08:34 -05:00
paths_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
rack_logger_test.rb Change the empty block style to have space inside of the block 2018-09-25 13:19:35 -04:00
rails_info_controller_test.rb Fix secret_key_base for Railties 2019-03-13 16:41:29 -04:00
rails_info_test.rb Revert "Merge pull request #34387 from yhirano55/rails_info_properties_json" 2019-01-08 22:21:20 +01:00
secrets_test.rb Enable Style/RedundantBegin cop to avoid newly adding redundant begin block 2018-12-21 06:12:42 +09:00
version_test.rb Adding frozen_string_literal pragma to Railties. 2017-08-14 19:08:09 +02:00