mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
20ab1bf4f7
Forgotten followup to #23669 😬 If you went to an internal route (e.g. `/rails/info/routes`), you would previously see the following in your logger: ```bash Processing by Rails::InfoController#routes as HTML Parameters: {"internal"=>true} Rendering /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application Rendered collection of /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_route.html.erb [2 times] (10.5ms) Rendered /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_table.html.erb (2.5ms) Rendered /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application (23.5ms) Completed 200 OK in 50ms (Views: 35.1ms | ActiveRecord: 0.0ms) ``` Now, with this change, you would see: ```bash Processing by Rails::InfoController#routes as HTML Rendering /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application Rendered collection of /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_route.html.erb [2 times] (1.6ms) Rendered /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_table.html.erb (10.2ms) Rendered /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application (17.4ms) Completed 200 OK in 44ms (Views: 28.0ms | ActiveRecord: 0.0ms) ```
87 lines
2.4 KiB
Ruby
87 lines
2.4 KiB
Ruby
require 'abstract_unit'
|
|
|
|
module ActionController
|
|
class Base
|
|
include ActionController::Testing
|
|
end
|
|
end
|
|
|
|
class InfoControllerTest < ActionController::TestCase
|
|
tests Rails::InfoController
|
|
|
|
def setup
|
|
Rails.application.routes.draw do
|
|
get '/rails/info/properties' => "rails/info#properties"
|
|
get '/rails/info/routes' => "rails/info#routes"
|
|
end
|
|
@routes = Rails.application.routes
|
|
|
|
Rails::InfoController.include(@routes.url_helpers)
|
|
|
|
@request.env["REMOTE_ADDR"] = "127.0.0.1"
|
|
end
|
|
|
|
test "info controller does not allow remote requests" do
|
|
@request.env["REMOTE_ADDR"] = "example.org"
|
|
get :properties
|
|
assert_response :forbidden
|
|
end
|
|
|
|
test "info controller renders an error message when request was forbidden" do
|
|
@request.env["REMOTE_ADDR"] = "example.org"
|
|
get :properties
|
|
assert_select 'p'
|
|
end
|
|
|
|
test "info controller allows requests when all requests are considered local" do
|
|
get :properties
|
|
assert_response :success
|
|
end
|
|
|
|
test "info controller allows local requests" do
|
|
get :properties
|
|
assert_response :success
|
|
end
|
|
|
|
test "info controller renders a table with properties" do
|
|
get :properties
|
|
assert_select 'table'
|
|
end
|
|
|
|
test "info controller renders with routes" do
|
|
get :routes
|
|
assert_response :success
|
|
end
|
|
|
|
test "info controller returns exact matches" do
|
|
exact_count = -> { JSON(response.body)['exact'].size }
|
|
|
|
get :routes, params: { path: 'rails/info/route' }
|
|
assert exact_count.call == 0, 'should not match incomplete routes'
|
|
|
|
get :routes, params: { path: 'rails/info/routes' }
|
|
assert exact_count.call == 1, 'should match complete routes'
|
|
|
|
get :routes, params: { path: 'rails/info/routes.html' }
|
|
assert exact_count.call == 1, 'should match complete routes with optional parts'
|
|
end
|
|
|
|
test "info controller returns fuzzy matches" do
|
|
fuzzy_count = -> { JSON(response.body)['fuzzy'].size }
|
|
|
|
get :routes, params: { path: 'rails/info' }
|
|
assert fuzzy_count.call == 2, 'should match incomplete routes'
|
|
|
|
get :routes, params: { path: 'rails/info/routes' }
|
|
assert fuzzy_count.call == 1, 'should match complete routes'
|
|
|
|
get :routes, params: { path: 'rails/info/routes.html' }
|
|
assert fuzzy_count.call == 0, 'should match optional parts of route literally'
|
|
end
|
|
|
|
test "internal routes do not have a default params[:internal] value" do
|
|
get :properties
|
|
assert_response :success
|
|
assert_nil @controller.params[:internal]
|
|
end
|
|
end
|