1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/activerecord/test
Vladimir Kochnev 41b92914f8 Abandon TOP support.
Initially, `TOP` was introduced to support `limit` for MSSQL database.
Unlike PostgreSQL/MySQL/SQLite, MSSQL does not have native `LIMIT`/`OFFSET` support.
The commit adding `TOP` is 1a246f7161.

However, it figured out that `TOP` implementation was weak and it's not sufficient
to also support `OFFSET`, then `TOP` was substituted with
`ROW_NUMBER()` subquery in be48ed3071.
This is a well known trick in MSSQL -
https://stackoverflow.com/questions/2135418/equivalent-of-limit-and-offset-for-sql-server.

So now we don't need this `visit_Arel_Nodes_Top` at all.
It does nothing useful but also adds an extra space after `SELECT` when `LIMIT` is being
used for **any** database.
2018-09-25 15:39:14 +04:00
..
active_record/connection_adapters Use frozen-string-literal in ActiveRecord 2017-07-19 22:27:07 +03:00
assets Use YAML to serialize schema cache 2016-11-27 22:09:58 -05:00
cases Abandon TOP support. 2018-09-25 15:39:14 +04:00
fixtures Eager loading/preloading should be worked regardless of large number of records 2018-09-12 01:11:38 +09:00
migrations Fix occurrences Fixnum|Bignum 2018-03-04 20:44:30 +02:00
models Avoid the same foreign_key and counter_cache associations on SillyReply 2018-09-19 01:11:07 +09:00
schema Use utf8mb4 in all tests and examples 2018-09-21 04:00:25 +09:00
support Use frozen-string-literal in ActiveRecord 2017-07-19 22:27:07 +03:00
config.example.yml Use utf8mb4 character set by default for MySQL database (#33608) 2018-09-11 13:03:34 -07:00
config.rb Use frozen-string-literal in ActiveRecord 2017-07-19 22:27:07 +03:00