mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
0a12a5f816
Don't use this:
scope :red, where(color: 'red')
default_scope where(color: 'red')
Use this:
scope :red, -> { where(color: 'red') }
default_scope { where(color: 'red') }
The former has numerous issues. It is a common newbie gotcha to do
the following:
scope :recent, where(published_at: Time.now - 2.weeks)
Or a more subtle variant:
scope :recent, -> { where(published_at: Time.now - 2.weeks) }
scope :recent_red, recent.where(color: 'red')
Eager scopes are also very complex to implement within Active
Record, and there are still bugs. For example, the following does
not do what you expect:
scope :remove_conditions, except(:where)
where(...).remove_conditions # => still has conditions
64 lines
1.9 KiB
Ruby
64 lines
1.9 KiB
Ruby
require 'models/topic'
|
|
|
|
class Reply < Topic
|
|
scope :base, -> { scoped }
|
|
|
|
belongs_to :topic, :foreign_key => "parent_id", :counter_cache => true
|
|
belongs_to :topic_with_primary_key, :class_name => "Topic", :primary_key => "title", :foreign_key => "parent_title", :counter_cache => "replies_count"
|
|
has_many :replies, :class_name => "SillyReply", :dependent => :destroy, :foreign_key => "parent_id"
|
|
|
|
attr_accessible :title, :author_name, :author_email_address, :written_on, :content, :last_read, :parent_title
|
|
end
|
|
|
|
class UniqueReply < Reply
|
|
validates_uniqueness_of :content, :scope => 'parent_id'
|
|
end
|
|
|
|
class SillyUniqueReply < UniqueReply
|
|
end
|
|
|
|
class WrongReply < Reply
|
|
validate :errors_on_empty_content
|
|
validate :title_is_wrong_create, :on => :create
|
|
|
|
validate :check_empty_title
|
|
validate :check_content_mismatch, :on => :create
|
|
validate :check_wrong_update, :on => :update
|
|
validate :check_author_name_is_secret, :on => :special_case
|
|
|
|
def check_empty_title
|
|
errors[:title] << "Empty" unless attribute_present?("title")
|
|
end
|
|
|
|
def errors_on_empty_content
|
|
errors[:content] << "Empty" unless attribute_present?("content")
|
|
end
|
|
|
|
def check_content_mismatch
|
|
if attribute_present?("title") && attribute_present?("content") && content == "Mismatch"
|
|
errors[:title] << "is Content Mismatch"
|
|
end
|
|
end
|
|
|
|
def title_is_wrong_create
|
|
errors[:title] << "is Wrong Create" if attribute_present?("title") && title == "Wrong Create"
|
|
end
|
|
|
|
def check_wrong_update
|
|
errors[:title] << "is Wrong Update" if attribute_present?("title") && title == "Wrong Update"
|
|
end
|
|
|
|
def check_author_name_is_secret
|
|
errors[:author_name] << "Invalid" unless author_name == "secret"
|
|
end
|
|
end
|
|
|
|
class SillyReply < Reply
|
|
belongs_to :reply, :foreign_key => "parent_id", :counter_cache => :replies_count
|
|
end
|
|
|
|
module Web
|
|
class Reply < Web::Topic
|
|
belongs_to :topic, :foreign_key => "parent_id", :counter_cache => true, :class_name => 'Web::Topic'
|
|
end
|
|
end
|