mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
d43b1b0a9e
Hashes with indifferent access should support `reverse_merge` out-of-the-box
but they don't; for instance the following code fails:
```ruby
require 'active_support'
require 'active_support/hash_with_indifferent_access'
hash = HashWithIndifferentAccess.new key: :old_value
hash.reverse_merge key: :new_value
```
This PR fixes the case above by simply requiring
`active_support/core_ext/hash/reverse_merge` in `hash_with_indifferent_access.rb`
and adding a test that confirms the fix.
---
Here are more details about the bugfix.
Currently, `reverse_merge` is [defined in HashWithIndifferentAccess](4e8ea13ba1/activesupport/lib/active_support/hash_with_indifferent_access.rb (L208))
by invoking `super`, that is by invoking `Hash#reverse_merge`:
```ruby
def reverse_merge(other_hash)
super(self.class.new_from_hash_copying_default(other_hash))
end
```
However, Ruby's `Hash` does not have the `reverse_merge` by default: it must be
added by ActiveSupport, and that requires the following line of code to be
present:
```ruby
require 'active_support/core_ext/hash/reverse_merge'
```
10 lines
No EOL
312 B
Ruby
10 lines
No EOL
312 B
Ruby
require 'abstract_unit'
|
|
require 'active_support/hash_with_indifferent_access'
|
|
|
|
class HashWithIndifferentAccessTest < ActiveSupport::TestCase
|
|
def test_reverse_merge
|
|
hash = HashWithIndifferentAccess.new key: :old_value
|
|
hash.reverse_merge! key: :new_value
|
|
assert_equal :old_value, hash[:key]
|
|
end
|
|
end |