mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
ea5f509643
Since #35709, `Response#conten_type` returns only MIME type correctly.
It is a documented behavior that this method only returns MIME type, so
this change seems appropriate.
39de7fac05/actionpack/lib/action_dispatch/http/response.rb (L245-L249)
But unfortunately, some users expect this method to return all
Content-Type that does not contain charset. This seems to be breaking
changes.
We can change this behavior with the deprecate cycle.
But, in that case, a method needs that include Content-Type with
additional parameters. And that method name is probably the
`content_type` seems to properly.
So I changed the new behavior to more appropriate `media_type` method.
And `Response#content_type` changed (as the method name) to return Content-Type
header as it is.
Fixes #35709.
[Rafael Mendonça França & Yuuji Yaginuma ]
50 lines
1 KiB
Ruby
50 lines
1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "abstract_unit"
|
|
require "active_support/core_ext/hash/conversions"
|
|
|
|
class MetalRenderingController < ActionController::Metal
|
|
include AbstractController::Rendering
|
|
include ActionController::Rendering
|
|
include ActionController::Renderers
|
|
end
|
|
|
|
class MetalRenderingJsonController < MetalRenderingController
|
|
class Model
|
|
def to_json(options = {})
|
|
{ a: "b" }.to_json(options)
|
|
end
|
|
|
|
def to_xml(options = {})
|
|
{ a: "b" }.to_xml(options)
|
|
end
|
|
end
|
|
|
|
use_renderers :json
|
|
|
|
def one
|
|
render json: Model.new
|
|
end
|
|
|
|
def two
|
|
render xml: Model.new
|
|
end
|
|
end
|
|
|
|
class RenderersMetalTest < ActionController::TestCase
|
|
tests MetalRenderingJsonController
|
|
|
|
def test_render_json
|
|
get :one
|
|
assert_response :success
|
|
assert_equal({ a: "b" }.to_json, @response.body)
|
|
assert_equal "application/json", @response.media_type
|
|
end
|
|
|
|
def test_render_xml
|
|
get :two
|
|
assert_response :success
|
|
assert_equal(" ", @response.body)
|
|
assert_equal "text/plain", @response.media_type
|
|
end
|
|
end
|