mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
8eec6ee962
`Pattern#from_sting` was introduced inbb207ea7to support creating patterns from strings in tests (removing a conditional in the initialize method that had been there only for the sake of those tests). `Pattern#build` was introduced in947ebe9a, and was similarly used only in tests. My understanding is that [`Mapping#path`][path] is the only place where we initialize a `Path::Pattern` in library code. Since these two methods appear to be used only in tests, this commit moves them out of the class and into a test helper. My reasoning for doing this is that I am doing some performance work that may involve a modification to how `Path::Pattern`s get initialized, and I will have more confidence in that work if I know for sure that these methods are test helpers that can be modified freely. [path]: https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/routing/mapper.rb#L192-L194
115 lines
3.9 KiB
Ruby
115 lines
3.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "abstract_unit"
|
|
require "support/path_helper"
|
|
|
|
module ActionDispatch
|
|
module Journey
|
|
class TestRoute < ActiveSupport::TestCase
|
|
include PathHelper
|
|
|
|
def test_initialize
|
|
app = Object.new
|
|
path = path_from_string "/:controller(/:action(/:id(.:format)))"
|
|
defaults = {}
|
|
route = Route.new(name: "name", app: app, path: path, defaults: defaults)
|
|
|
|
assert_equal app, route.app
|
|
assert_equal path, route.path
|
|
assert_same defaults, route.defaults
|
|
end
|
|
|
|
def test_route_adds_itself_as_memo
|
|
app = Object.new
|
|
path = path_from_string "/:controller(/:action(/:id(.:format)))"
|
|
route = Route.new(name: "name", app: app, path: path)
|
|
|
|
route.ast.grep(Nodes::Terminal).each do |node|
|
|
assert_equal route, node.memo
|
|
end
|
|
end
|
|
|
|
def test_path_requirements_override_defaults
|
|
path = build_path(":name", { name: /love/ }, "/", true)
|
|
defaults = { name: "tender" }
|
|
route = Route.new(name: "name", path: path, defaults: defaults)
|
|
assert_equal(/love/, route.requirements[:name])
|
|
end
|
|
|
|
def test_ip_address
|
|
path = path_from_string "/messages/:id(.:format)"
|
|
route = Route.new(name: "name", path: path, constraints: { ip: "192.168.1.1" },
|
|
defaults: { controller: "foo", action: "bar" })
|
|
assert_equal "192.168.1.1", route.ip
|
|
end
|
|
|
|
def test_default_ip
|
|
path = path_from_string "/messages/:id(.:format)"
|
|
route = Route.new(name: "name", path: path,
|
|
defaults: { controller: "foo", action: "bar" })
|
|
assert_equal(//, route.ip)
|
|
end
|
|
|
|
def test_format_with_star
|
|
path = path_from_string "/:controller/*extra"
|
|
route = Route.new(name: "name", path: path,
|
|
defaults: { controller: "foo", action: "bar" })
|
|
assert_equal "/foo/himom", route.format(
|
|
controller: "foo",
|
|
extra: "himom")
|
|
end
|
|
|
|
def test_connects_all_match
|
|
path = path_from_string "/:controller(/:action(/:id(.:format)))"
|
|
route = Route.new(name: "name", path: path, constraints: { action: "bar" },
|
|
defaults: { controller: "foo" })
|
|
|
|
assert_equal "/foo/bar/10", route.format(
|
|
controller: "foo",
|
|
action: "bar",
|
|
id: 10)
|
|
end
|
|
|
|
def test_extras_are_not_included_if_optional
|
|
path = path_from_string "/page/:id(/:action)"
|
|
route = Route.new(name: "name", path: path, defaults: { action: "show" })
|
|
|
|
assert_equal "/page/10", route.format(id: 10)
|
|
end
|
|
|
|
def test_extras_are_not_included_if_optional_with_parameter
|
|
path = path_from_string "(/sections/:section)/pages/:id"
|
|
route = Route.new(name: "name", path: path, defaults: { action: "show" })
|
|
|
|
assert_equal "/pages/10", route.format(id: 10)
|
|
end
|
|
|
|
def test_extras_are_not_included_if_optional_parameter_is_nil
|
|
path = path_from_string "(/sections/:section)/pages/:id"
|
|
route = Route.new(name: "name", path: path, defaults: { action: "show" })
|
|
|
|
assert_equal "/pages/10", route.format(id: 10, section: nil)
|
|
end
|
|
|
|
def test_score
|
|
defaults = { controller: "pages", action: "show" }
|
|
|
|
path = path_from_string "/page/:id(/:action)(.:format)"
|
|
specific = Route.new name: "name", path: path, required_defaults: [:controller, :action], defaults: defaults
|
|
|
|
path = path_from_string "/:controller(/:action(/:id))(.:format)"
|
|
generic = Route.new name: "name", path: path
|
|
|
|
knowledge = { "id" => true, "controller" => true, "action" => true }
|
|
|
|
routes = [specific, generic]
|
|
|
|
assert_not_equal specific.score(knowledge), generic.score(knowledge)
|
|
|
|
found = routes.sort_by { |r| r.score(knowledge) }.last
|
|
|
|
assert_equal specific, found
|
|
end
|
|
end
|
|
end
|
|
end
|