kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
rails--rails/actioncable/test
History
Fumiaki MATSUSHIMA 788c908577 Fix unstable test test_delegate_socket_errors_to_on_error_handler 
I often face the following error when running test/connection/client_socket_test.rb:

```
$ bin/test test/connection/client_socket_test.rb:38
Run options: --seed 44035

# Running:

F

Failure:
ActionCable::Connection::ClientSocketTest#test_delegate_socket_errors_to_on_error_handler
[/app/actioncable/test/connection/client_socket_test.rb:47]:
--- expected
+++ actual
@@ -1 +1 @@
-["foo"]
+["Broken pipe", "Broken pipe", "Broken pipe", "foo"]
```

It can be reproduced easily by applying the following patch:

```
diff --git a/actioncable/test/connection/client_socket_test.rb b/actioncable/test/connection/client_socket_test.rb
index 2051216010..6bb9f13ea7 100644
--- a/actioncable/test/connection/client_socket_test.rb
+++ b/actioncable/test/connection/client_socket_test.rb
@@ -34,7 +34,8 @@ def on_error(message)
     @server.config.allowed_request_origins = %w( http://rubyonrails.com )
   end

-  test "delegate socket errors to on_error handler" do
+  1000.times do |i|
+  test "delegate socket errors to on_error handler #{i}" do
     run_in_eventmachine do
       connection = open_connection

@@ -47,6 +48,7 @@ def on_error(message)
       assert_equal %w[ foo ], connection.errors
     end
   end
+  end

   test "closes hijacked i/o socket at shutdown" do
     run_in_eventmachine do
```

The cause is writing io from different thread at the same time.

`connection.process` sends handshake message from [StreamEventLoop's thread][] whereas
`connection.handle_open` sends welcome message from current thread.

[StreamEventLoop's thread]: 067fc779c4/actioncable/lib/action_cable/connection/stream_event_loop.rb (L75)
2017-11-23 14:37:06 +09:00
..
channel Fix RuboCop offenses 2017-08-16 17:55:25 +09:00
connection Fix unstable test test_delegate_socket_errors_to_on_error_handler 2017-11-23 14:37:06 +09:00
javascript ActionCable should not raise when a connection is already open 2017-01-06 12:49:58 -05:00
server Use frozen string literal in actioncable/ 2017-07-23 23:30:29 +03:00
stubs Use frozen string literal in actioncable/ 2017-07-23 23:30:29 +03:00
subscription_adapter Action Cable: run Redis tests against a default config without a password 2017-11-13 01:34:59 -07:00
client_test.rb Use frozen string literal in actioncable/ 2017-07-23 23:30:29 +03:00
test_helper.rb Use frozen string literal in actioncable/ 2017-07-23 23:30:29 +03:00
worker_test.rb Use frozen string literal in actioncable/ 2017-07-23 23:30:29 +03:00