mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
8606a7fbe9
See #9869 and #9929. The problem arises from the following example: class Project < ActiveRecord::Base scope :completed, -> { where completed: true } end class MajorProject < Project end When calling: MajorProject.where(tasks_count: 10).completed This expands to: MajorProject.where(tasks_count: 10).scoping { MajorProject.completed } However the lambda for the `completed` scope is defined on Project. This means that when it is called, `self` is Project rather than MajorProject. So it expands to: MajorProject.where(tasks_count: 10).scoping { Project.where(completed: true) } Since the scoping was applied on MajorProject, and not Project, this fails to apply the tasks_count condition. The solution is to make scoping apply across STI classes. I am slightly concerned about the possible side-effects of this, but no tests fail and it seems ok. I guess we'll see.
38 lines
975 B
Ruby
38 lines
975 B
Ruby
class Comment < ActiveRecord::Base
|
|
scope :limit_by, lambda {|l| limit(l) }
|
|
scope :containing_the_letter_e, -> { where("comments.body LIKE '%e%'") }
|
|
scope :not_again, -> { where("comments.body NOT LIKE '%again%'") }
|
|
scope :for_first_post, -> { where(:post_id => 1) }
|
|
scope :for_first_author, -> { joins(:post).where("posts.author_id" => 1) }
|
|
scope :created, -> { all }
|
|
|
|
belongs_to :post, :counter_cache => true
|
|
has_many :ratings
|
|
|
|
belongs_to :first_post, :foreign_key => :post_id
|
|
|
|
has_many :children, :class_name => 'Comment', :foreign_key => :parent_id
|
|
belongs_to :parent, :class_name => 'Comment', :counter_cache => :children_count
|
|
|
|
def self.what_are_you
|
|
'a comment...'
|
|
end
|
|
|
|
def self.search_by_type(q)
|
|
where("#{QUOTED_TYPE} = ?", q)
|
|
end
|
|
|
|
def self.all_as_method
|
|
all
|
|
end
|
|
scope :all_as_scope, -> { all }
|
|
end
|
|
|
|
class SpecialComment < Comment
|
|
end
|
|
|
|
class SubSpecialComment < SpecialComment
|
|
end
|
|
|
|
class VerySpecialComment < Comment
|
|
end
|