mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
164 lines
4.9 KiB
Ruby
164 lines
4.9 KiB
Ruby
require 'abstract_unit'
|
|
|
|
class JsonParamsParsingTest < ActionDispatch::IntegrationTest
|
|
class TestController < ActionController::Base
|
|
class << self
|
|
attr_accessor :last_request_parameters
|
|
end
|
|
|
|
def parse
|
|
self.class.last_request_parameters = request.request_parameters
|
|
head :ok
|
|
end
|
|
end
|
|
|
|
def teardown
|
|
TestController.last_request_parameters = nil
|
|
end
|
|
|
|
test "parses json params for application json" do
|
|
assert_parses(
|
|
{"person" => {"name" => "David"}},
|
|
"{\"person\": {\"name\": \"David\"}}", { 'CONTENT_TYPE' => 'application/json' }
|
|
)
|
|
end
|
|
|
|
test "parses boolean and number json params for application json" do
|
|
assert_parses(
|
|
{"item" => {"enabled" => false, "count" => 10}},
|
|
"{\"item\": {\"enabled\": false, \"count\": 10}}", { 'CONTENT_TYPE' => 'application/json' }
|
|
)
|
|
end
|
|
|
|
test "parses json params for application jsonrequest" do
|
|
assert_parses(
|
|
{"person" => {"name" => "David"}},
|
|
"{\"person\": {\"name\": \"David\"}}", { 'CONTENT_TYPE' => 'application/jsonrequest' }
|
|
)
|
|
end
|
|
|
|
test "nils are stripped from collections" do
|
|
assert_parses(
|
|
{"person" => nil},
|
|
"{\"person\":[null]}", { 'CONTENT_TYPE' => 'application/json' }
|
|
)
|
|
assert_parses(
|
|
{"person" => ['foo']},
|
|
"{\"person\":[\"foo\",null]}", { 'CONTENT_TYPE' => 'application/json' }
|
|
)
|
|
assert_parses(
|
|
{"person" => nil},
|
|
"{\"person\":[null, null]}", { 'CONTENT_TYPE' => 'application/json' }
|
|
)
|
|
end
|
|
|
|
test "logs error if parsing unsuccessful" do
|
|
with_test_routing do
|
|
output = StringIO.new
|
|
json = "[\"person]\": {\"name\": \"David\"}}"
|
|
post "/parse", json, {'CONTENT_TYPE' => 'application/json', 'action_dispatch.show_exceptions' => true, 'action_dispatch.logger' => ActiveSupport::Logger.new(output)}
|
|
assert_response :bad_request
|
|
output.rewind && err = output.read
|
|
assert err =~ /Error occurred while parsing request parameters/
|
|
end
|
|
end
|
|
|
|
test "occurring a parse error if parsing unsuccessful" do
|
|
with_test_routing do
|
|
begin
|
|
$stderr = StringIO.new # suppress the log
|
|
json = "[\"person]\": {\"name\": \"David\"}}"
|
|
exception = assert_raise(ActionDispatch::ParamsParser::ParseError) { post "/parse", json, {'CONTENT_TYPE' => 'application/json', 'action_dispatch.show_exceptions' => false} }
|
|
assert_equal JSON::ParserError, exception.original_exception.class
|
|
assert_equal exception.original_exception.message, exception.message
|
|
ensure
|
|
$stderr = STDERR
|
|
end
|
|
end
|
|
end
|
|
|
|
test 'raw_post is not empty for JSON request' do
|
|
with_test_routing do
|
|
post '/parse', '{"posts": [{"title": "Post Title"}]}', 'CONTENT_TYPE' => 'application/json'
|
|
assert_equal '{"posts": [{"title": "Post Title"}]}', request.raw_post
|
|
end
|
|
end
|
|
|
|
private
|
|
def assert_parses(expected, actual, headers = {})
|
|
with_test_routing do
|
|
post "/parse", actual, headers
|
|
assert_response :ok
|
|
assert_equal(expected, TestController.last_request_parameters)
|
|
end
|
|
end
|
|
|
|
def with_test_routing
|
|
with_routing do |set|
|
|
set.draw do
|
|
post ':action', :to => ::JsonParamsParsingTest::TestController
|
|
end
|
|
yield
|
|
end
|
|
end
|
|
end
|
|
|
|
class RootLessJSONParamsParsingTest < ActionDispatch::IntegrationTest
|
|
class UsersController < ActionController::Base
|
|
wrap_parameters :format => :json
|
|
|
|
class << self
|
|
attr_accessor :last_request_parameters, :last_parameters
|
|
end
|
|
|
|
def parse
|
|
self.class.last_request_parameters = request.request_parameters
|
|
self.class.last_parameters = params
|
|
head :ok
|
|
end
|
|
end
|
|
|
|
def teardown
|
|
UsersController.last_request_parameters = nil
|
|
end
|
|
|
|
test "parses json params for application json" do
|
|
assert_parses(
|
|
{"user" => {"username" => "sikachu"}, "username" => "sikachu"},
|
|
"{\"username\": \"sikachu\"}", { 'CONTENT_TYPE' => 'application/json' }
|
|
)
|
|
end
|
|
|
|
test "parses json params for application jsonrequest" do
|
|
assert_parses(
|
|
{"user" => {"username" => "sikachu"}, "username" => "sikachu"},
|
|
"{\"username\": \"sikachu\"}", { 'CONTENT_TYPE' => 'application/jsonrequest' }
|
|
)
|
|
end
|
|
|
|
test "parses json with non-object JSON content" do
|
|
assert_parses(
|
|
{"user" => {"_json" => "string content" }, "_json" => "string content" },
|
|
"\"string content\"", { 'CONTENT_TYPE' => 'application/json' }
|
|
)
|
|
end
|
|
|
|
private
|
|
def assert_parses(expected, actual, headers = {})
|
|
with_test_routing(UsersController) do
|
|
post "/parse", actual, headers
|
|
assert_response :ok
|
|
assert_equal(expected, UsersController.last_request_parameters)
|
|
assert_equal(expected.merge({"action" => "parse"}), UsersController.last_parameters)
|
|
end
|
|
end
|
|
|
|
def with_test_routing(controller)
|
|
with_routing do |set|
|
|
set.draw do
|
|
post ':action', :to => controller
|
|
end
|
|
yield
|
|
end
|
|
end
|
|
end
|