mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
b168eb5819
* Introduce a connection coder responsible for encoding Cable messages as WebSocket messages, defaulting to `ActiveSupport::JSON` and duck- typing to any object responding to `#encode` and `#decode`. * Consolidate encoding responsibility to the connection. No longer explicitly JSON-encode from channels or other sources. Pass Cable messages as Hashes to `#transmit` and rely on it to encode. * Introduce stream encoders responsible for decoding pubsub messages. Preserve the currently raw encoding, but make it easy to use JSON. Same duck type as the connection encoder. * Revert recent data normalization/quoting (#23649) which treated `identifier` and `data` values as nested JSON objects rather than as opaque JSON-encoded strings. That dealt us an awkward hand where we'd decode JSON strings… or not, but always encode as JSON. Embedding JSON object values directly is preferably, no extra JSON encoding, but that should be a purposeful protocol version change rather than ambiguously, inadvertently supporting multiple message formats.
117 lines
2.9 KiB
Ruby
117 lines
2.9 KiB
Ruby
require 'test_helper'
|
|
require 'concurrent'
|
|
|
|
require 'active_support/core_ext/hash/indifferent_access'
|
|
require 'pathname'
|
|
|
|
module CommonSubscriptionAdapterTest
|
|
WAIT_WHEN_EXPECTING_EVENT = 3
|
|
WAIT_WHEN_NOT_EXPECTING_EVENT = 0.2
|
|
|
|
def setup
|
|
server = ActionCable::Server::Base.new
|
|
server.config.cable = cable_config.with_indifferent_access
|
|
server.config.use_faye = ENV['FAYE'].present?
|
|
|
|
adapter_klass = server.config.pubsub_adapter
|
|
|
|
@rx_adapter = adapter_klass.new(server)
|
|
@tx_adapter = adapter_klass.new(server)
|
|
end
|
|
|
|
def teardown
|
|
[@rx_adapter, @tx_adapter].uniq.each(&:shutdown)
|
|
end
|
|
|
|
|
|
def subscribe_as_queue(channel, adapter = @rx_adapter)
|
|
queue = Queue.new
|
|
|
|
callback = -> data { queue << data }
|
|
subscribed = Concurrent::Event.new
|
|
adapter.subscribe(channel, callback, Proc.new { subscribed.set })
|
|
subscribed.wait(WAIT_WHEN_EXPECTING_EVENT)
|
|
assert subscribed.set?
|
|
|
|
yield queue
|
|
|
|
sleep WAIT_WHEN_NOT_EXPECTING_EVENT
|
|
assert_empty queue
|
|
ensure
|
|
adapter.unsubscribe(channel, callback) if subscribed.set?
|
|
end
|
|
|
|
|
|
def test_subscribe_and_unsubscribe
|
|
subscribe_as_queue('channel') do |queue|
|
|
end
|
|
end
|
|
|
|
def test_basic_broadcast
|
|
subscribe_as_queue('channel') do |queue|
|
|
@tx_adapter.broadcast('channel', 'hello world')
|
|
|
|
assert_equal 'hello world', queue.pop
|
|
end
|
|
end
|
|
|
|
def test_broadcast_after_unsubscribe
|
|
keep_queue = nil
|
|
subscribe_as_queue('channel') do |queue|
|
|
keep_queue = queue
|
|
|
|
@tx_adapter.broadcast('channel', 'hello world')
|
|
|
|
assert_equal 'hello world', queue.pop
|
|
end
|
|
|
|
@tx_adapter.broadcast('channel', 'hello void')
|
|
|
|
sleep WAIT_WHEN_NOT_EXPECTING_EVENT
|
|
assert_empty keep_queue
|
|
end
|
|
|
|
def test_multiple_broadcast
|
|
subscribe_as_queue('channel') do |queue|
|
|
@tx_adapter.broadcast('channel', 'bananas')
|
|
@tx_adapter.broadcast('channel', 'apples')
|
|
|
|
received = []
|
|
2.times { received << queue.pop }
|
|
assert_equal ['apples', 'bananas'], received.sort
|
|
end
|
|
end
|
|
|
|
def test_identical_subscriptions
|
|
subscribe_as_queue('channel') do |queue|
|
|
subscribe_as_queue('channel') do |queue_2|
|
|
@tx_adapter.broadcast('channel', 'hello')
|
|
|
|
assert_equal 'hello', queue_2.pop
|
|
end
|
|
|
|
assert_equal 'hello', queue.pop
|
|
end
|
|
end
|
|
|
|
def test_simultaneous_subscriptions
|
|
subscribe_as_queue('channel') do |queue|
|
|
subscribe_as_queue('other channel') do |queue_2|
|
|
@tx_adapter.broadcast('channel', 'apples')
|
|
@tx_adapter.broadcast('other channel', 'oranges')
|
|
|
|
assert_equal 'apples', queue.pop
|
|
assert_equal 'oranges', queue_2.pop
|
|
end
|
|
end
|
|
end
|
|
|
|
def test_channel_filtered_broadcast
|
|
subscribe_as_queue('channel') do |queue|
|
|
@tx_adapter.broadcast('other channel', 'one')
|
|
@tx_adapter.broadcast('channel', 'two')
|
|
|
|
assert_equal 'two', queue.pop
|
|
end
|
|
end
|
|
end
|