1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionpack/test
Genadi Samokovarov 872e22c603 Show proper traces on Windows for the error pages
This is an issue brought up by @daniel-rikowski in rails/web-console#91.

Citing his PR proposal here:

> Prior to this, backtrace lines were simply split by a single colon.
>
> Unfortunately that is also the drive letter delimiter in Windows paths
> which resulted in a lot of empty source fragments of "C:0". ("C" from
> the drive letter and 0 from "/path/to/rails/file.rb:16".to_i)
>
> Now the trace line is split by the first colon followed by some digits,
> which works for both Windows and Unix path styles.

Now, the PR was sent against web-console, because of the templates copy
issue we used to had. Instead of bothering the contributor to reopen the
issue against upstream Rails itself, I will make sure he gets the credit
by putting his name in [rails-contributors/hard_coded_authors.rb][].

  [rails-contributors/hard_coded_authors.rb]: (https://github.com/fxn/rails-contributors/blob/master/app/models/names_manager/hard_coded_authors.rb).
2015-02-01 12:00:18 +02:00
..
abstract Deprecate all *_filter callbacks in favor of *_action callbacks 2015-01-08 20:52:36 +00:00
assertions
controller Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846 2015-01-31 23:12:41 -05:00
dispatch Show proper traces on Windows for the error pages 2015-02-01 12:00:18 +02:00
fixtures Typo: Hello = Guten Tag (in German) 2014-12-05 12:54:15 +07:00
journey make OR in journey patterns compile to a valid regular expression 2014-11-29 01:26:10 +01:00
lib/controller Removing unused fake models 2014-09-07 22:51:14 -03:00
routing Remove deprecate *_path helpers in email views 2015-01-04 11:58:42 -03:00
tmp
abstract_unit.rb Merge pull request #17862 from lucasmazza/lm-hide-action 2014-12-02 11:40:11 -02:00