1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/activestorage/test
Ryuta Kamizono 88cbe13741 Fix activestorage CI failure due to ffprove version differece
Our CI environment is upgraded from stretch to buster then ffprove
version is also upgraded from 3.2.14 to 4.1.3.

https://packages.debian.org/stretch/ffmpeg
https://packages.debian.org/buster/ffmpeg

Somehow those ffprove returns different metadata for
`rotated_video.mp4`.

```
$ ffprobe -print_format json -show_streams -v error rotated_video.mp4 > ffprobe41.json
$ diff -ub ffprobe32.json ffprobe41.json
--- ffprobe32.json      2019-07-14 20:02:13.000000000 +0900
+++ ffprobe41.json      2019-07-14 19:59:08.000000000 +0900
@@ -27,8 +27,8 @@
             "time_base": "1/17594",
             "start_pts": 3976,
             "start_time": "0.225986",
-            "duration_ts": 91981,
-            "duration": "5.227975",
+            "duration_ts": 88000,
+            "duration": "5.001705",
             "bit_rate": "321546",
             "bits_per_raw_sample": "8",
             "nb_frames": "44",
@@ -78,8 +78,8 @@
             "time_base": "1/44100",
             "start_pts": 0,
             "start_time": "0.000000",
-            "duration_ts": 227865,
-            "duration": "5.167007",
+            "duration_ts": 227850,
+            "duration": "5.166667",
             "bit_rate": "109732",
             "max_bit_rate": "109732",
             "nb_frames": "223",
```

In the case on the `test "analyzing a rotated video"`, most important
part is `assert_equal 90, metadata[:angle]`, the accidental difference
of duration for ffprove version is out of scope for the test.
2019-07-14 20:06:41 +09:00
..
analyzer Fix activestorage CI failure due to ffprove version differece 2019-07-14 20:06:41 +09:00
controllers Remove outdated cross-origin redirection tests 2019-05-15 15:57:45 -04:00
database Refactor migration to move migrations paths to connection 2018-01-18 08:55:03 -05:00
dummy Merge pull request #34132 from ConfusedVorlon/enable_fragment_cache_log_in_dev 2019-01-08 14:15:16 -05:00
fixtures/files Allow ActiveStorage to generate variants of BMP images 2019-04-21 19:07:22 +02:00
jobs Remove superfluous test 2018-08-19 01:10:50 -04:00
models Mirror direct uploads 2019-05-22 15:07:35 -04:00
previewer Change video preview format from PNG to JPG 2018-05-23 14:32:34 -04:00
service Mirror direct uploads 2019-05-22 15:07:35 -04:00
template url -> URL where apt except inside actionpack/ 2019-04-01 22:56:35 +05:30
test_helper.rb Mirror direct uploads 2019-05-22 15:07:35 -04:00