mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
9c65c539e2
This stems from [a comment](rails#17227 (comment)) by @dhh. In summary: * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning. * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning. For this purpose, this commit introduces a Rails configuration option: ```ruby config.active_support.halt_callback_chains_on_return_false ``` For new Rails 5.0 apps, this option will be set to `false` by a new initializer `config/initializers/callback_terminator.rb`: ```ruby Rails.application.config.active_support.halt_callback_chains_on_return_false = false ``` For existing apps ported to Rails 5.0, the initializers above will not exist. Even running `rake rails:update` will not create this initializer. Since the default value of `halt_callback_chains_on_return_false` is set to `true`, these apps will still accept `return true` as a way to halt callback chains, displaying a deprecation warning. Developers will be able to switch to the new behavior (and stop the warning) by manually adding the line above to their `config/application.rb`. A gist with the suggested release notes to add to Rails 5.0 after this commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
53 lines
2 KiB
Ruby
53 lines
2 KiB
Ruby
require "active_support"
|
|
require "active_support/i18n_railtie"
|
|
|
|
module ActiveSupport
|
|
class Railtie < Rails::Railtie # :nodoc:
|
|
config.active_support = ActiveSupport::OrderedOptions.new
|
|
|
|
config.eager_load_namespaces << ActiveSupport
|
|
|
|
initializer "active_support.deprecation_behavior" do |app|
|
|
if deprecation = app.config.active_support.deprecation
|
|
ActiveSupport::Deprecation.behavior = deprecation
|
|
end
|
|
end
|
|
|
|
initializer "active_support.halt_callback_chains_on_return_false", after: :load_config_initializers do |app|
|
|
if app.config.active_support.key? :halt_callback_chains_on_return_false
|
|
ActiveSupport::Callbacks::CallbackChain.halt_and_display_warning_on_return_false = \
|
|
app.config.active_support.halt_callback_chains_on_return_false
|
|
end
|
|
end
|
|
|
|
# Sets the default value for Time.zone
|
|
# If assigned value cannot be matched to a TimeZone, an exception will be raised.
|
|
initializer "active_support.initialize_time_zone" do |app|
|
|
require 'active_support/core_ext/time/zones'
|
|
zone_default = Time.find_zone!(app.config.time_zone)
|
|
|
|
unless zone_default
|
|
raise 'Value assigned to config.time_zone not recognized. ' \
|
|
'Run "rake -D time" for a list of tasks for finding appropriate time zone names.'
|
|
end
|
|
|
|
Time.zone_default = zone_default
|
|
end
|
|
|
|
# Sets the default week start
|
|
# If assigned value is not a valid day symbol (e.g. :sunday, :monday, ...), an exception will be raised.
|
|
initializer "active_support.initialize_beginning_of_week" do |app|
|
|
require 'active_support/core_ext/date/calculations'
|
|
beginning_of_week_default = Date.find_beginning_of_week!(app.config.beginning_of_week)
|
|
|
|
Date.beginning_of_week_default = beginning_of_week_default
|
|
end
|
|
|
|
initializer "active_support.set_configs" do |app|
|
|
app.config.active_support.each do |k, v|
|
|
k = "#{k}="
|
|
ActiveSupport.send(k, v) if ActiveSupport.respond_to? k
|
|
end
|
|
end
|
|
end
|
|
end
|