mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
4701a50b58
Today there are two common ways for Rails developers to force their applications to communicate over HTTPS: * `config.force_ssl` is a setting in environment configurations that enables the `ActionDispatch::SSL` middleware. With this middleware enabled, all HTTP communication to your application will be redirected to HTTPS. The middleware also takes care of other best practices by setting HSTS headers, upgrading all cookies to secure only, etc. * The `force_ssl` controller method redirects HTTP requests to certain controllers to HTTPS. As a consultant, I've seen many applications with misconfigured HTTPS setups due to developers adding `force_ssl` to `ApplicationController` and not enabling `config.force_ssl`. With this configuration, many application requests can be served over HTTP such as assets, requests that hit mounted engines, etc. In addition, because cookies are not upgraded to secure only in this configuration and HSTS headers are not set, it's possible for cookies that are meant to be secure to be sent over HTTP. The confusion between these two methods of forcing HTTPS is compounded by the fact that they share an identical name. This makes finding documentation on the "right" method confusing. HTTPS throughout is quickly becomming table stakes for all web sites. Sites are expected to operate over HTTPS for all communication, sensitive or otherwise. Let's encourage use of the broader-reaching `ActionDispatch::SSL` middleware and elminate this source of user confusion. If, for some reason, applications need to expose certain endpoints over HTTP they can do so by properly configuring `config.ssl_options`.
24 lines
449 B
Ruby
24 lines
449 B
Ruby
# frozen_string_literal: true
|
|
|
|
require "abstract_unit"
|
|
|
|
class ForceSSLApiController < ActionController::API
|
|
ActiveSupport::Deprecation.silence do
|
|
force_ssl
|
|
end
|
|
|
|
def one; end
|
|
def two
|
|
head :ok
|
|
end
|
|
end
|
|
|
|
class ForceSSLApiTest < ActionController::TestCase
|
|
tests ForceSSLApiController
|
|
|
|
def test_redirects_to_https
|
|
get :two
|
|
assert_response 301
|
|
assert_equal "https://test.host/force_ssl_api/two", redirect_to_url
|
|
end
|
|
end
|