mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
33fdae0584
`Minitest.plugin_rails_init` sets `Minitest.backtrace_filter` to `Rails.backtrace_cleaner` right before tests are run, overwriting the value set in test_helper.rb. `Rails.backtrace_cleaner` silences backtrace lines that do not start with `Rails.root` followed by e.g. "lib/" or "test/". Thus when `Rails.root` is a subdirectory of the project directory -- for example, when testing a plugin that has a dummy app -- all lines of the backtrace are silenced. This commit adds a fallback such that when all backtrace lines are silenced, the original `Minitest.backtrace_filter` is used instead. Additionally, this commit refactors and expands existing test coverage.
74 lines
2.3 KiB
Ruby
74 lines
2.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "active_support/core_ext/module/attribute_accessors"
|
|
require "rails/test_unit/reporter"
|
|
require "rails/test_unit/runner"
|
|
|
|
module Minitest
|
|
class BacktraceFilterWithFallback
|
|
def initialize(preferred, fallback)
|
|
@preferred = preferred
|
|
@fallback = fallback
|
|
end
|
|
|
|
def filter(backtrace)
|
|
filtered = @preferred.filter(backtrace)
|
|
filtered = @fallback.filter(backtrace) if filtered.empty?
|
|
filtered
|
|
end
|
|
end
|
|
|
|
class SuppressedSummaryReporter < SummaryReporter
|
|
# Disable extra failure output after a run if output is inline.
|
|
def aggregated_results(*)
|
|
super unless options[:output_inline]
|
|
end
|
|
end
|
|
|
|
def self.plugin_rails_options(opts, options)
|
|
::Rails::TestUnit::Runner.attach_before_load_options(opts)
|
|
|
|
opts.on("-b", "--backtrace", "Show the complete backtrace") do
|
|
options[:full_backtrace] = true
|
|
end
|
|
|
|
opts.on("-d", "--defer-output", "Output test failures and errors after the test run") do
|
|
options[:output_inline] = false
|
|
end
|
|
|
|
opts.on("-f", "--fail-fast", "Abort test run on first failure or error") do
|
|
options[:fail_fast] = true
|
|
end
|
|
|
|
opts.on("-c", "--[no-]color", "Enable color in the output") do |value|
|
|
options[:color] = value
|
|
end
|
|
|
|
options[:color] = true
|
|
options[:output_inline] = true
|
|
end
|
|
|
|
# Owes great inspiration to test runner trailblazers like RSpec,
|
|
# minitest-reporters, maxitest and others.
|
|
def self.plugin_rails_init(options)
|
|
unless options[:full_backtrace] || ENV["BACKTRACE"]
|
|
# Plugin can run without Rails loaded, check before filtering.
|
|
if ::Rails.respond_to?(:backtrace_cleaner)
|
|
Minitest.backtrace_filter = BacktraceFilterWithFallback.new(::Rails.backtrace_cleaner, Minitest.backtrace_filter)
|
|
end
|
|
end
|
|
|
|
# Suppress summary reports when outputting inline rerun snippets.
|
|
if reporter.reporters.reject! { |reporter| reporter.kind_of?(SummaryReporter) }
|
|
reporter << SuppressedSummaryReporter.new(options[:io], options)
|
|
end
|
|
|
|
# Replace progress reporter for colors.
|
|
if reporter.reporters.reject! { |reporter| reporter.kind_of?(ProgressReporter) }
|
|
reporter << ::Rails::TestUnitReporter.new(options[:io], options)
|
|
end
|
|
end
|
|
|
|
# Backwards compatibility with Rails 5.0 generated plugin test scripts
|
|
mattr_reader :run_via, default: {}
|
|
end
|