mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
dcce260edc
In other log messages like perform/performed and ActiveJob error logging, the job ID and exception message were already included, eg:
Error performing TestFailureJob (Job ID: d70ad13e-e58b-409c-a8cc-e0447fc792b5) from Resque(default) in 1446.56ms: RuntimeError (Error Message):
But log message related to retry/discard behavior from ActiveJob::Exceptions did not include the Job ID or exception message. We now include them, in a consistent format with other existing messages.
Job ID is especially useful because, while other ActiveJob-related log messages get the Job ID via tagged logging, retry-related log messages do not currently end up tagged with Job ID. And it's really useful to use Job ID to be able to collect all the log lines related to a particular job, put the error messages together with the retry and subsequent perform messages.
We also include job.executions in the enqueue_retry log message because it was available and useful, to know if this is the 1st retry or 2nd or whatever. Previously job.executions was included in retry_stopped logging, but not enqueue_retry.
|
||
|---|---|---|
| .. | ||
| adapter_test.rb | ||
| argument_serialization_test.rb | ||
| callbacks_test.rb | ||
| delayed_job_adapter_test.rb | ||
| exceptions_test.rb | ||
| job_serialization_test.rb | ||
| logging_test.rb | ||
| queue_adapter_test.rb | ||
| queue_naming_test.rb | ||
| queue_priority_test.rb | ||
| queuing_test.rb | ||
| rescue_test.rb | ||
| serializers_test.rb | ||
| test_case_test.rb | ||
| test_helper_test.rb | ||
| timezones_test.rb | ||
| translation_test.rb | ||