Tawan Sierek 221b4aead5 Avoid multiple default paths to server.pid file ... Fix bug (#22811) that occurs when rails server is started in daemon mode and optional path to the `server.pid` file is omitted. Store default path in a constant instead of evaluating it multiple time using `File.expand_path`. The bug in detail: The server startup procedure crashes, since it tries to open a file at `/tmp/pids/server.pid` instead of `<path to project>/tmp/pids/server.pid`. This bug was introduced in 51211a94bd when Rack was upgraded from version 1.x to 2.x. Since version 2.x, Rack does not memoize the options hash [1], and as a consequence `Rails::Server#default_options` will be evaluated multiple times. The hash returned by `Rails::Server#default_options` holds the default path to the `server.pid` file. The path is generated with the method `File.expand_path`. However, the return value of this method depends on the current working directory [2], which changes once `Process.daemon` is invoked by `Rack::Server#daemonize_app` and the process is detached from the current shell. Close #22811 [1]https://git.io/vzen2 [2]http://ruby-doc.org/core-2.1.5/File.html#method-c-expand_path		2016-01-16 16:16:43 +01:00
..
console_test.rb	Revert "Merge pull request #19404 from dmathieu/remove_rack_env"	2015-03-20 08:14:11 -07:00
dbconsole_test.rb	Remove legacy mysql adapter	2015-12-17 15:54:57 +00:00
dev_cache_test.rb	Clarify the need to run command twice.	2015-12-07 20:36:22 +01:00
server_test.rb	Avoid multiple default paths to server.pid file	2016-01-16 16:16:43 +01:00