mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
5411565d44
If a parameter isn't found we can suggest similar params: ``` class BooksController < ActionController::Base def create params.require(:book).require(:name) head :ok end end post :create, params: { magazine: { name: "Mjallo!" } } param is missing or the value is empty: book Did you mean? controller action magazine post :create, params: { book: { title: "Mjallo!" } } param is missing or the value is empty: name Did you mean? title ```
114 lines
3.8 KiB
Ruby
114 lines
3.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "abstract_unit"
|
|
|
|
class BooksController < ActionController::Base
|
|
def create
|
|
params.require(:book).require(:name)
|
|
head :ok
|
|
end
|
|
end
|
|
|
|
class ActionControllerRequiredParamsTest < ActionController::TestCase
|
|
tests BooksController
|
|
|
|
test "missing required parameters will raise exception" do
|
|
assert_raise ActionController::ParameterMissing do
|
|
post :create, params: { magazine: { name: "Mjallo!" } }
|
|
end
|
|
|
|
assert_raise ActionController::ParameterMissing do
|
|
post :create, params: { book: { title: "Mjallo!" } }
|
|
end
|
|
end
|
|
|
|
if defined?(DidYouMean) && DidYouMean.respond_to?(:correct_error)
|
|
test "exceptions have suggestions for fix" do
|
|
error = assert_raise ActionController::ParameterMissing do
|
|
post :create, params: { magazine: { name: "Mjallo!" } }
|
|
end
|
|
assert_match "Did you mean?", error.message
|
|
|
|
error = assert_raise ActionController::ParameterMissing do
|
|
post :create, params: { book: { title: "Mjallo!" } }
|
|
end
|
|
assert_match "Did you mean?", error.message
|
|
end
|
|
end
|
|
|
|
test "required parameters that are present will not raise" do
|
|
post :create, params: { book: { name: "Mjallo!" } }
|
|
assert_response :ok
|
|
end
|
|
|
|
test "required parameters with false value will not raise" do
|
|
post :create, params: { book: { name: false } }
|
|
assert_response :ok
|
|
end
|
|
end
|
|
|
|
class ParametersRequireTest < ActiveSupport::TestCase
|
|
test "required parameters should accept and return false value" do
|
|
assert_equal(false, ActionController::Parameters.new(person: false).require(:person))
|
|
end
|
|
|
|
test "required parameters must not be nil" do
|
|
assert_raises(ActionController::ParameterMissing) do
|
|
ActionController::Parameters.new(person: nil).require(:person)
|
|
end
|
|
end
|
|
|
|
test "required parameters must not be empty" do
|
|
assert_raises(ActionController::ParameterMissing) do
|
|
ActionController::Parameters.new(person: {}).require(:person)
|
|
end
|
|
end
|
|
|
|
test "require array when all required params are present" do
|
|
safe_params = ActionController::Parameters.new(person: { first_name: "Gaurish", title: "Mjallo", city: "Barcelona" })
|
|
.require(:person)
|
|
.require([:first_name, :title])
|
|
|
|
assert_kind_of Array, safe_params
|
|
assert_equal ["Gaurish", "Mjallo"], safe_params
|
|
end
|
|
|
|
test "require array when a required param is missing" do
|
|
assert_raises(ActionController::ParameterMissing) do
|
|
ActionController::Parameters.new(person: { first_name: "Gaurish", title: nil })
|
|
.require(:person)
|
|
.require([:first_name, :title])
|
|
end
|
|
end
|
|
|
|
test "value params" do
|
|
params = ActionController::Parameters.new(foo: "bar", dog: "cinco")
|
|
assert_equal ["bar", "cinco"], params.values
|
|
assert params.has_value?("cinco")
|
|
assert params.value?("cinco")
|
|
end
|
|
|
|
test "to_param works like in a Hash" do
|
|
params = ActionController::Parameters.new(nested: { key: "value" }).permit!
|
|
assert_equal({ nested: { key: "value" } }.to_param, params.to_param)
|
|
|
|
params = { root: ActionController::Parameters.new(nested: { key: "value" }).permit! }
|
|
assert_equal({ root: { nested: { key: "value" } } }.to_param, params.to_param)
|
|
|
|
assert_raise(ActionController::UnfilteredParameters) do
|
|
ActionController::Parameters.new(nested: { key: "value" }).to_param
|
|
end
|
|
end
|
|
|
|
test "to_query works like in a Hash" do
|
|
params = ActionController::Parameters.new(nested: { key: "value" }).permit!
|
|
assert_equal({ nested: { key: "value" } }.to_query, params.to_query)
|
|
|
|
params = { root: ActionController::Parameters.new(nested: { key: "value" }).permit! }
|
|
assert_equal({ root: { nested: { key: "value" } } }.to_query, params.to_query)
|
|
|
|
assert_raise(ActionController::UnfilteredParameters) do
|
|
ActionController::Parameters.new(nested: { key: "value" }).to_query
|
|
end
|
|
end
|
|
end
|