mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
296cc53277
A regression introduced in 764803e07a caused blobs to appear as HTML content attachments instead of file / image attachments when editing rich text content. This change restores the original intended behavior.
References: https://github.com/rails/rails/pull/35485, https://github.com/basecamp/trix/issues/706
71 lines
2.9 KiB
Ruby
71 lines
2.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "test_helper"
|
|
|
|
class ActionText::AttachmentTest < ActiveSupport::TestCase
|
|
test "from_attachable" do
|
|
attachment = ActionText::Attachment.from_attachable(attachable, caption: "Captioned")
|
|
assert_equal attachable, attachment.attachable
|
|
assert_equal "Captioned", attachment.caption
|
|
end
|
|
|
|
test "proxies missing methods to attachable" do
|
|
attachable.instance_eval { def proxied; "proxied"; end }
|
|
attachment = ActionText::Attachment.from_attachable(attachable)
|
|
assert_equal "proxied", attachment.proxied
|
|
end
|
|
|
|
test "proxies #to_param to attachable" do
|
|
attachment = ActionText::Attachment.from_attachable(attachable)
|
|
assert_equal attachable.to_param, attachment.to_param
|
|
end
|
|
|
|
test "converts to TrixAttachment" do
|
|
attachment = attachment_from_html(%Q(<action-text-attachment sgid="#{attachable.attachable_sgid}" caption="Captioned"></action-text-attachment>))
|
|
|
|
trix_attachment = attachment.to_trix_attachment
|
|
assert_kind_of ActionText::TrixAttachment, trix_attachment
|
|
|
|
assert_equal attachable.attachable_sgid, trix_attachment.attributes["sgid"]
|
|
assert_equal attachable.attachable_content_type, trix_attachment.attributes["contentType"]
|
|
assert_equal attachable.filename.to_s, trix_attachment.attributes["filename"]
|
|
assert_equal attachable.byte_size, trix_attachment.attributes["filesize"]
|
|
assert_equal "Captioned", trix_attachment.attributes["caption"]
|
|
|
|
assert_nil attachable.to_trix_content_attachment_partial_path
|
|
assert_nil trix_attachment.attributes["content"]
|
|
end
|
|
|
|
test "converts to TrixAttachment with content" do
|
|
attachable = Person.create! name: "Javan"
|
|
attachment = attachment_from_html(%Q(<action-text-attachment sgid="#{attachable.attachable_sgid}"></action-text-attachment>))
|
|
|
|
trix_attachment = attachment.to_trix_attachment
|
|
assert_kind_of ActionText::TrixAttachment, trix_attachment
|
|
|
|
assert_equal attachable.attachable_sgid, trix_attachment.attributes["sgid"]
|
|
assert_equal attachable.attachable_content_type, trix_attachment.attributes["contentType"]
|
|
|
|
assert_not_nil attachable.to_trix_content_attachment_partial_path
|
|
assert_not_nil trix_attachment.attributes["content"]
|
|
end
|
|
|
|
test "converts to plain text" do
|
|
assert_equal "[Vroom vroom]", ActionText::Attachment.from_attachable(attachable, caption: "Vroom vroom").to_plain_text
|
|
assert_equal "[racecar.jpg]", ActionText::Attachment.from_attachable(attachable).to_plain_text
|
|
end
|
|
|
|
test "defaults trix partial to model partial" do
|
|
attachable = Page.create! title: "Homepage"
|
|
assert_equal "pages/page", attachable.to_trix_content_attachment_partial_path
|
|
end
|
|
|
|
private
|
|
def attachment_from_html(html)
|
|
ActionText::Content.new(html).attachments.first
|
|
end
|
|
|
|
def attachable
|
|
@attachment ||= create_file_blob(filename: "racecar.jpg", content_type: "image/jpg")
|
|
end
|
|
end
|