mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
f243e7f0d0
`Broadcast#silence` breaks custom loggers that do not include `Logg…
170 lines
4.6 KiB
Ruby
170 lines
4.6 KiB
Ruby
require "abstract_unit"
|
|
|
|
module ActiveSupport
|
|
class BroadcastLoggerTest < TestCase
|
|
attr_reader :logger, :log1, :log2
|
|
|
|
setup do
|
|
@log1 = FakeLogger.new
|
|
@log2 = FakeLogger.new
|
|
@log1.extend Logger.broadcast @log2
|
|
@logger = @log1
|
|
end
|
|
|
|
Logger::Severity.constants.each do |level_name|
|
|
method = level_name.downcase
|
|
level = Logger::Severity.const_get(level_name)
|
|
|
|
test "##{method} adds the message to all loggers" do
|
|
logger.send(method, "msg")
|
|
|
|
assert_equal [level, "msg", nil], log1.adds.first
|
|
assert_equal [level, "msg", nil], log2.adds.first
|
|
end
|
|
end
|
|
|
|
test "#close broadcasts to all loggers" do
|
|
logger.close
|
|
|
|
assert log1.closed, "should be closed"
|
|
assert log2.closed, "should be closed"
|
|
end
|
|
|
|
test "#<< shovels the value into all loggers" do
|
|
logger << "foo"
|
|
|
|
assert_equal %w{ foo }, log1.chevrons
|
|
assert_equal %w{ foo }, log2.chevrons
|
|
end
|
|
|
|
test "#level= assigns the level to all loggers" do
|
|
assert_equal ::Logger::DEBUG, logger.level
|
|
logger.level = ::Logger::FATAL
|
|
|
|
assert_equal ::Logger::FATAL, log1.level
|
|
assert_equal ::Logger::FATAL, log2.level
|
|
end
|
|
|
|
test "#progname= assigns to all the loggers" do
|
|
assert_nil logger.progname
|
|
logger.progname = ::Logger::FATAL
|
|
|
|
assert_equal ::Logger::FATAL, log1.progname
|
|
assert_equal ::Logger::FATAL, log2.progname
|
|
end
|
|
|
|
test "#formatter= assigns to all the loggers" do
|
|
assert_nil logger.formatter
|
|
logger.formatter = ::Logger::FATAL
|
|
|
|
assert_equal ::Logger::FATAL, log1.formatter
|
|
assert_equal ::Logger::FATAL, log2.formatter
|
|
end
|
|
|
|
test "#local_level= assigns the local_level to all loggers" do
|
|
assert_equal ::Logger::DEBUG, logger.local_level
|
|
logger.local_level = ::Logger::FATAL
|
|
|
|
assert_equal ::Logger::FATAL, log1.local_level
|
|
assert_equal ::Logger::FATAL, log2.local_level
|
|
end
|
|
|
|
test "#silence does not break custom loggers" do
|
|
new_logger = FakeLogger.new
|
|
custom_logger = CustomLogger.new
|
|
custom_logger.extend(Logger.broadcast(new_logger))
|
|
|
|
custom_logger.silence do
|
|
custom_logger.error "from error"
|
|
custom_logger.unknown "from unknown"
|
|
end
|
|
|
|
assert_equal [[::Logger::ERROR, "from error", nil], [::Logger::UNKNOWN, "from unknown", nil]], custom_logger.adds
|
|
assert_equal [[::Logger::ERROR, "from error", nil], [::Logger::UNKNOWN, "from unknown", nil]], new_logger.adds
|
|
end
|
|
|
|
test "#silence silences all loggers below the default level of ERROR" do
|
|
logger.silence do
|
|
logger.debug "test"
|
|
end
|
|
|
|
assert_equal [], log1.adds
|
|
assert_equal [], log2.adds
|
|
end
|
|
|
|
test "#silence does not silence at or above ERROR" do
|
|
logger.silence do
|
|
logger.error "from error"
|
|
logger.unknown "from unknown"
|
|
end
|
|
|
|
assert_equal [[::Logger::ERROR, "from error", nil], [::Logger::UNKNOWN, "from unknown", nil]], log1.adds
|
|
assert_equal [[::Logger::ERROR, "from error", nil], [::Logger::UNKNOWN, "from unknown", nil]], log2.adds
|
|
end
|
|
|
|
test "#silence allows you to override the silence level" do
|
|
logger.silence(::Logger::FATAL) do
|
|
logger.error "unseen"
|
|
logger.fatal "seen"
|
|
end
|
|
|
|
assert_equal [[::Logger::FATAL, "seen", nil]], log1.adds
|
|
assert_equal [[::Logger::FATAL, "seen", nil]], log2.adds
|
|
end
|
|
|
|
class CustomLogger
|
|
attr_reader :adds, :closed, :chevrons
|
|
attr_accessor :level, :progname, :formatter, :local_level
|
|
|
|
def initialize
|
|
@adds = []
|
|
@closed = false
|
|
@chevrons = []
|
|
@level = ::Logger::DEBUG
|
|
@local_level = ::Logger::DEBUG
|
|
@progname = nil
|
|
@formatter = nil
|
|
end
|
|
|
|
def debug(message, &block)
|
|
add(::Logger::DEBUG, message, &block)
|
|
end
|
|
|
|
def info(message, &block)
|
|
add(::Logger::INFO, message, &block)
|
|
end
|
|
|
|
def warn(message, &block)
|
|
add(::Logger::WARN, message, &block)
|
|
end
|
|
|
|
def error(message, &block)
|
|
add(::Logger::ERROR, message, &block)
|
|
end
|
|
|
|
def fatal(message, &block)
|
|
add(::Logger::FATAL, message, &block)
|
|
end
|
|
|
|
def unknown(message, &block)
|
|
add(::Logger::UNKNOWN, message, &block)
|
|
end
|
|
|
|
def <<(x)
|
|
@chevrons << x
|
|
end
|
|
|
|
def add(message_level, message = nil, progname = nil, &block)
|
|
@adds << [message_level, message, progname] if message_level >= local_level
|
|
end
|
|
|
|
def close
|
|
@closed = true
|
|
end
|
|
end
|
|
|
|
class FakeLogger < CustomLogger
|
|
include LoggerSilence
|
|
end
|
|
end
|
|
end
|