mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
a2827ec981
Rails has some support for multiple databases but it can be hard to handle migrations with those. The easiest way to implement multiple databases is to contain migrations into their own folder ("db/migrate" for the primary db and "db/seconddb_migrate" for the second db). Without this you would need to write code that allowed you to switch connections in migrations. I can tell you from experience that is not a fun way to implement multiple databases. This refactoring is a pre-requisite for implementing other features related to parallel testing and improved handling for multiple databases. The refactoring here moves the class methods from the `Migrator` class into it's own new class `MigrationContext`. The goal was to move the `migrations_paths` method off of the `Migrator` class and onto the connection. This allows users to do the following in their `database.yml`: ``` development: adapter: mysql2 username: root password: development_seconddb: adapter: mysql2 username: root password: migrations_paths: "db/second_db_migrate" ``` Migrations for the `seconddb` can now be store in the `db/second_db_migrate` directory. Migrations for the primary database are stored in `db/migrate`". The refactoring here drastically reduces the internal API for migrations since we don't need to pass `migrations_paths` around to every single method. Additionally this change does not require any Rails applications to make changes unless they want to use the new public API. All of the class methods from the `Migrator` class were `nodoc`'d except for the `migrations_paths` and `migrations_path` getter/setters respectively.
145 lines
5.1 KiB
Ruby
145 lines
5.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "cases/helper"
|
|
|
|
class ActiveRecordSchemaTest < ActiveRecord::TestCase
|
|
self.use_transactional_tests = false
|
|
|
|
setup do
|
|
@original_verbose = ActiveRecord::Migration.verbose
|
|
ActiveRecord::Migration.verbose = false
|
|
@connection = ActiveRecord::Base.connection
|
|
ActiveRecord::SchemaMigration.drop_table
|
|
end
|
|
|
|
teardown do
|
|
@connection.drop_table :fruits rescue nil
|
|
@connection.drop_table :nep_fruits rescue nil
|
|
@connection.drop_table :nep_schema_migrations rescue nil
|
|
@connection.drop_table :has_timestamps rescue nil
|
|
@connection.drop_table :multiple_indexes rescue nil
|
|
ActiveRecord::SchemaMigration.delete_all rescue nil
|
|
ActiveRecord::Migration.verbose = @original_verbose
|
|
end
|
|
|
|
def test_has_primary_key
|
|
old_primary_key_prefix_type = ActiveRecord::Base.primary_key_prefix_type
|
|
ActiveRecord::Base.primary_key_prefix_type = :table_name_with_underscore
|
|
assert_equal "version", ActiveRecord::SchemaMigration.primary_key
|
|
|
|
ActiveRecord::SchemaMigration.create_table
|
|
assert_difference "ActiveRecord::SchemaMigration.count", 1 do
|
|
ActiveRecord::SchemaMigration.create version: 12
|
|
end
|
|
ensure
|
|
ActiveRecord::SchemaMigration.drop_table
|
|
ActiveRecord::Base.primary_key_prefix_type = old_primary_key_prefix_type
|
|
end
|
|
|
|
def test_schema_define
|
|
ActiveRecord::Schema.define(version: 7) do
|
|
create_table :fruits do |t|
|
|
t.column :color, :string
|
|
t.column :fruit_size, :string # NOTE: "size" is reserved in Oracle
|
|
t.column :texture, :string
|
|
t.column :flavor, :string
|
|
end
|
|
end
|
|
|
|
assert_nothing_raised { @connection.select_all "SELECT * FROM fruits" }
|
|
assert_nothing_raised { @connection.select_all "SELECT * FROM schema_migrations" }
|
|
assert_equal 7, @connection.migration_context.current_version
|
|
end
|
|
|
|
def test_schema_define_w_table_name_prefix
|
|
table_name = ActiveRecord::SchemaMigration.table_name
|
|
old_table_name_prefix = ActiveRecord::Base.table_name_prefix
|
|
ActiveRecord::Base.table_name_prefix = "nep_"
|
|
ActiveRecord::SchemaMigration.table_name = "nep_#{table_name}"
|
|
ActiveRecord::Schema.define(version: 7) do
|
|
create_table :fruits do |t|
|
|
t.column :color, :string
|
|
t.column :fruit_size, :string # NOTE: "size" is reserved in Oracle
|
|
t.column :texture, :string
|
|
t.column :flavor, :string
|
|
end
|
|
end
|
|
assert_equal 7, @connection.migration_context.current_version
|
|
ensure
|
|
ActiveRecord::Base.table_name_prefix = old_table_name_prefix
|
|
ActiveRecord::SchemaMigration.table_name = table_name
|
|
end
|
|
|
|
def test_schema_raises_an_error_for_invalid_column_type
|
|
assert_raise NoMethodError do
|
|
ActiveRecord::Schema.define(version: 8) do
|
|
create_table :vegetables do |t|
|
|
t.unknown :color
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def test_schema_subclass
|
|
Class.new(ActiveRecord::Schema).define(version: 9) do
|
|
create_table :fruits
|
|
end
|
|
assert_nothing_raised { @connection.select_all "SELECT * FROM fruits" }
|
|
end
|
|
|
|
def test_normalize_version
|
|
assert_equal "118", ActiveRecord::SchemaMigration.normalize_migration_number("0000118")
|
|
assert_equal "002", ActiveRecord::SchemaMigration.normalize_migration_number("2")
|
|
assert_equal "017", ActiveRecord::SchemaMigration.normalize_migration_number("0017")
|
|
assert_equal "20131219224947", ActiveRecord::SchemaMigration.normalize_migration_number("20131219224947")
|
|
end
|
|
|
|
def test_schema_load_with_multiple_indexes_for_column_of_different_names
|
|
ActiveRecord::Schema.define do
|
|
create_table :multiple_indexes do |t|
|
|
t.string "foo"
|
|
t.index ["foo"], name: "multiple_indexes_foo_1"
|
|
t.index ["foo"], name: "multiple_indexes_foo_2"
|
|
end
|
|
end
|
|
|
|
indexes = @connection.indexes("multiple_indexes")
|
|
|
|
assert_equal 2, indexes.length
|
|
assert_equal ["multiple_indexes_foo_1", "multiple_indexes_foo_2"], indexes.collect(&:name).sort
|
|
end
|
|
|
|
def test_timestamps_without_null_set_null_to_false_on_create_table
|
|
ActiveRecord::Schema.define do
|
|
create_table :has_timestamps do |t|
|
|
t.timestamps
|
|
end
|
|
end
|
|
|
|
assert !@connection.columns(:has_timestamps).find { |c| c.name == "created_at" }.null
|
|
assert !@connection.columns(:has_timestamps).find { |c| c.name == "updated_at" }.null
|
|
end
|
|
|
|
def test_timestamps_without_null_set_null_to_false_on_change_table
|
|
ActiveRecord::Schema.define do
|
|
create_table :has_timestamps
|
|
|
|
change_table :has_timestamps do |t|
|
|
t.timestamps default: Time.now
|
|
end
|
|
end
|
|
|
|
assert !@connection.columns(:has_timestamps).find { |c| c.name == "created_at" }.null
|
|
assert !@connection.columns(:has_timestamps).find { |c| c.name == "updated_at" }.null
|
|
end
|
|
|
|
def test_timestamps_without_null_set_null_to_false_on_add_timestamps
|
|
ActiveRecord::Schema.define do
|
|
create_table :has_timestamps
|
|
add_timestamps :has_timestamps, default: Time.now
|
|
end
|
|
|
|
assert !@connection.columns(:has_timestamps).find { |c| c.name == "created_at" }.null
|
|
assert !@connection.columns(:has_timestamps).find { |c| c.name == "updated_at" }.null
|
|
end
|
|
end
|