bogdanvlviv 9d0cf52096 assert_called_with should require args argument ... There are two main reasons why `assert_called_with` should require `args` argument: 1) If we want to assert that some method should be called and we don't need to check with which arguments it should be called then we should use `assert_called`. 2) `assert_called_with` without `args` argument doesn't assert anything! ```ruby assert_called_with(@object, :increment) do @object.decrement end ``` It causes false assertions in tests that could cause regressions in the project. I found this bug by working on [minitest-mock_expectations](https://github.com/bogdanvlviv/minitest-mock_expectations) gem. This gem is an extension for minitest that provides almost the same method call assertions. I was wondering whether you would consider adding "minitest-mock_expectations" to `rails/rails` instead of private `ActiveSupport::Testing::MethodCallAssertions` module. If yes, I'll send a patch - a970ecc42c		2018-10-25 21:29:39 +03:00
..
database_tasks_test.rb	Move db:migrate:status to DatabaseTasks method	2018-10-08 13:46:01 -04:00
mysql_rake_test.rb	assert_called_with should require args argument	2018-10-25 21:29:39 +03:00
postgresql_rake_test.rb	Use -X when loading structure.sql via psql	2018-09-27 10:01:24 -03:00
sqlite_rake_test.rb	Prevent leaking of user's DB credentials on rails db:create failure	2018-08-29 12:40:30 +03:00