mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
9d0cf52096
There are two main reasons why `assert_called_with` should require
`args` argument:
1) If we want to assert that some method should be called and we don't
need to check with which arguments it should be called then we should use
`assert_called`.
2) `assert_called_with` without `args` argument doesn't assert anything!
```ruby
assert_called_with(@object, :increment) do
@object.decrement
end
```
It causes false assertions in tests that could cause regressions in the project.
I found this bug by working on
[minitest-mock_expectations](https://github.com/bogdanvlviv/minitest-mock_expectations) gem.
This gem is an extension for minitest that provides almost the same method call
assertions.
I was wondering whether you would consider adding "minitest-mock_expectations"
to `rails/rails` instead of private `ActiveSupport::Testing::MethodCallAssertions` module.
If yes, I'll send a patch -
|
||
|---|---|---|
| .. | ||
| autoloading_cache_behavior.rb | ||
| cache_delete_matched_behavior.rb | ||
| cache_increment_decrement_behavior.rb | ||
| cache_instrumentation_behavior.rb | ||
| cache_store_behavior.rb | ||
| cache_store_version_behavior.rb | ||
| connection_pool_behavior.rb | ||
| encoded_key_cache_behavior.rb | ||
| failure_safety_behavior.rb | ||
| local_cache_behavior.rb | ||