mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
b168eb5819
* Introduce a connection coder responsible for encoding Cable messages as WebSocket messages, defaulting to `ActiveSupport::JSON` and duck- typing to any object responding to `#encode` and `#decode`. * Consolidate encoding responsibility to the connection. No longer explicitly JSON-encode from channels or other sources. Pass Cable messages as Hashes to `#transmit` and rely on it to encode. * Introduce stream encoders responsible for decoding pubsub messages. Preserve the currently raw encoding, but make it easy to use JSON. Same duck type as the connection encoder. * Revert recent data normalization/quoting (#23649) which treated `identifier` and `data` values as nested JSON objects rather than as opaque JSON-encoded strings. That dealt us an awkward hand where we'd decode JSON strings… or not, but always encode as JSON. Embedding JSON object values directly is preferably, no extra JSON encoding, but that should be a purposeful protocol version change rather than ambiguously, inadvertently supporting multiple message formats.
75 lines
2 KiB
Ruby
75 lines
2 KiB
Ruby
require 'test_helper'
|
|
require 'stubs/test_server'
|
|
require 'stubs/user'
|
|
|
|
class ActionCable::Connection::IdentifierTest < ActionCable::TestCase
|
|
class Connection < ActionCable::Connection::Base
|
|
identified_by :current_user
|
|
attr_reader :websocket
|
|
|
|
public :process_internal_message
|
|
|
|
def connect
|
|
self.current_user = User.new "lifo"
|
|
end
|
|
end
|
|
|
|
test "connection identifier" do
|
|
run_in_eventmachine do
|
|
open_connection_with_stubbed_pubsub
|
|
assert_equal "User#lifo", @connection.connection_identifier
|
|
end
|
|
end
|
|
|
|
test "should subscribe to internal channel on open and unsubscribe on close" do
|
|
run_in_eventmachine do
|
|
pubsub = mock('pubsub_adapter')
|
|
pubsub.expects(:subscribe).with('action_cable/User#lifo', kind_of(Proc))
|
|
pubsub.expects(:unsubscribe).with('action_cable/User#lifo', kind_of(Proc))
|
|
|
|
server = TestServer.new
|
|
server.stubs(:pubsub).returns(pubsub)
|
|
|
|
open_connection server: server
|
|
close_connection
|
|
end
|
|
end
|
|
|
|
test "processing disconnect message" do
|
|
run_in_eventmachine do
|
|
open_connection_with_stubbed_pubsub
|
|
|
|
@connection.websocket.expects(:close)
|
|
@connection.process_internal_message 'type' => 'disconnect'
|
|
end
|
|
end
|
|
|
|
test "processing invalid message" do
|
|
run_in_eventmachine do
|
|
open_connection_with_stubbed_pubsub
|
|
|
|
@connection.websocket.expects(:close).never
|
|
@connection.process_internal_message 'type' => 'unknown'
|
|
end
|
|
end
|
|
|
|
protected
|
|
def open_connection_with_stubbed_pubsub
|
|
server = TestServer.new
|
|
server.stubs(:adapter).returns(stub_everything('adapter'))
|
|
|
|
open_connection server: server
|
|
end
|
|
|
|
def open_connection(server:)
|
|
env = Rack::MockRequest.env_for "/test", 'HTTP_HOST' => 'localhost', 'HTTP_CONNECTION' => 'upgrade', 'HTTP_UPGRADE' => 'websocket'
|
|
@connection = Connection.new(server, env)
|
|
|
|
@connection.process
|
|
@connection.send :handle_open
|
|
end
|
|
|
|
def close_connection
|
|
@connection.send :handle_close
|
|
end
|
|
end
|