mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
1db49ced45
- If doing a count on a relation that has an :include and a :join, it does a distinct even though it should not.
- When doing a count on a relation that has an :include, it always falls back to a old style left join when performing the count. Looks like it was broken here:
b9599502c9
438 lines
15 KiB
Ruby
438 lines
15 KiB
Ruby
require "cases/helper"
|
|
require 'models/company'
|
|
require 'models/topic'
|
|
require 'models/edge'
|
|
require 'models/club'
|
|
require 'models/organization'
|
|
|
|
Company.has_many :accounts
|
|
|
|
class NumericData < ActiveRecord::Base
|
|
self.table_name = 'numeric_data'
|
|
end
|
|
|
|
class CalculationsTest < ActiveRecord::TestCase
|
|
fixtures :companies, :accounts, :topics
|
|
|
|
def test_should_sum_field
|
|
assert_equal 318, Account.sum(:credit_limit)
|
|
end
|
|
|
|
def test_should_average_field
|
|
value = Account.average(:credit_limit)
|
|
assert_equal 53.0, value
|
|
end
|
|
|
|
def test_should_return_decimal_average_of_integer_field
|
|
value = Account.average(:id)
|
|
assert_equal 3.5, value
|
|
end
|
|
|
|
def test_should_return_integer_average_if_db_returns_such
|
|
Account.connection.stubs :select_value => 3
|
|
value = Account.average(:id)
|
|
assert_equal 3, value
|
|
end
|
|
|
|
def test_should_return_nil_as_average
|
|
assert_nil NumericData.average(:bank_balance)
|
|
end
|
|
|
|
def test_type_cast_calculated_value_should_convert_db_averages_of_fixnum_class_to_decimal
|
|
assert_equal 0, NumericData.scoped.send(:type_cast_calculated_value, 0, nil, 'avg')
|
|
assert_equal 53.0, NumericData.scoped.send(:type_cast_calculated_value, 53, nil, 'avg')
|
|
end
|
|
|
|
def test_should_get_maximum_of_field
|
|
assert_equal 60, Account.maximum(:credit_limit)
|
|
end
|
|
|
|
def test_should_get_maximum_of_field_with_include
|
|
assert_equal 55, Account.maximum(:credit_limit, :include => :firm, :conditions => "companies.name != 'Summit'")
|
|
end
|
|
|
|
def test_should_get_maximum_of_field_with_scoped_include
|
|
Account.send :with_scope, :find => { :include => :firm, :conditions => "companies.name != 'Summit'" } do
|
|
assert_equal 55, Account.maximum(:credit_limit)
|
|
end
|
|
end
|
|
|
|
def test_should_get_minimum_of_field
|
|
assert_equal 50, Account.minimum(:credit_limit)
|
|
end
|
|
|
|
def test_should_group_by_field
|
|
c = Account.sum(:credit_limit, :group => :firm_id)
|
|
[1,6,2].each { |firm_id| assert c.keys.include?(firm_id) }
|
|
end
|
|
|
|
def test_should_group_by_multiple_fields
|
|
c = Account.count(:all, :group => ['firm_id', :credit_limit])
|
|
[ [nil, 50], [1, 50], [6, 50], [6, 55], [9, 53], [2, 60] ].each { |firm_and_limit| assert c.keys.include?(firm_and_limit) }
|
|
end
|
|
|
|
def test_should_group_by_multiple_fields_having_functions
|
|
c = Topic.group(:author_name, 'COALESCE(type, title)').count(:all)
|
|
assert_equal 1, c[["Carl", "The Third Topic of the day"]]
|
|
assert_equal 1, c[["Mary", "Reply"]]
|
|
assert_equal 1, c[["David", "The First Topic"]]
|
|
assert_equal 1, c[["Carl", "Reply"]]
|
|
end
|
|
|
|
def test_should_group_by_summed_field
|
|
c = Account.sum(:credit_limit, :group => :firm_id)
|
|
assert_equal 50, c[1]
|
|
assert_equal 105, c[6]
|
|
assert_equal 60, c[2]
|
|
end
|
|
|
|
def test_should_order_by_grouped_field
|
|
c = Account.sum(:credit_limit, :group => :firm_id, :order => "firm_id")
|
|
assert_equal [1, 2, 6, 9], c.keys.compact
|
|
end
|
|
|
|
def test_should_order_by_calculation
|
|
c = Account.sum(:credit_limit, :group => :firm_id, :order => "sum_credit_limit desc, firm_id")
|
|
assert_equal [105, 60, 53, 50, 50], c.keys.collect { |k| c[k] }
|
|
assert_equal [6, 2, 9, 1], c.keys.compact
|
|
end
|
|
|
|
def test_should_limit_calculation
|
|
c = Account.sum(:credit_limit, :conditions => "firm_id IS NOT NULL",
|
|
:group => :firm_id, :order => "firm_id", :limit => 2)
|
|
assert_equal [1, 2], c.keys.compact
|
|
end
|
|
|
|
def test_should_limit_calculation_with_offset
|
|
c = Account.sum(:credit_limit, :conditions => "firm_id IS NOT NULL",
|
|
:group => :firm_id, :order => "firm_id", :limit => 2, :offset => 1)
|
|
assert_equal [2, 6], c.keys.compact
|
|
end
|
|
|
|
def test_limit_should_apply_before_count
|
|
accounts = Account.limit(3).where('firm_id IS NOT NULL')
|
|
|
|
assert_equal 3, accounts.count(:firm_id)
|
|
assert_equal 3, accounts.select(:firm_id).count
|
|
end
|
|
|
|
def test_count_should_shortcut_with_limit_zero
|
|
accounts = Account.limit(0)
|
|
|
|
assert_no_queries { assert_equal 0, accounts.count }
|
|
end
|
|
|
|
def test_limit_is_kept
|
|
return if current_adapter?(:OracleAdapter)
|
|
|
|
queries = assert_sql { Account.limit(1).count }
|
|
assert_equal 1, queries.length
|
|
assert_match(/LIMIT/, queries.first)
|
|
end
|
|
|
|
def test_offset_is_kept
|
|
return if current_adapter?(:OracleAdapter)
|
|
|
|
queries = assert_sql { Account.offset(1).count }
|
|
assert_equal 1, queries.length
|
|
assert_match(/OFFSET/, queries.first)
|
|
end
|
|
|
|
def test_limit_with_offset_is_kept
|
|
return if current_adapter?(:OracleAdapter)
|
|
|
|
queries = assert_sql { Account.limit(1).offset(1).count }
|
|
assert_equal 1, queries.length
|
|
assert_match(/LIMIT/, queries.first)
|
|
assert_match(/OFFSET/, queries.first)
|
|
end
|
|
|
|
def test_no_limit_no_offset
|
|
queries = assert_sql { Account.count }
|
|
assert_equal 1, queries.length
|
|
assert_no_match(/LIMIT/, queries.first)
|
|
assert_no_match(/OFFSET/, queries.first)
|
|
end
|
|
|
|
def test_should_group_by_summed_field_having_condition
|
|
c = Account.sum(:credit_limit, :group => :firm_id,
|
|
:having => 'sum(credit_limit) > 50')
|
|
assert_nil c[1]
|
|
assert_equal 105, c[6]
|
|
assert_equal 60, c[2]
|
|
end
|
|
|
|
def test_should_group_by_summed_field_having_sanitized_condition
|
|
c = Account.sum(:credit_limit, :group => :firm_id,
|
|
:having => ['sum(credit_limit) > ?', 50])
|
|
assert_nil c[1]
|
|
assert_equal 105, c[6]
|
|
assert_equal 60, c[2]
|
|
end
|
|
|
|
def test_should_group_by_summed_association
|
|
c = Account.sum(:credit_limit, :group => :firm)
|
|
assert_equal 50, c[companies(:first_firm)]
|
|
assert_equal 105, c[companies(:rails_core)]
|
|
assert_equal 60, c[companies(:first_client)]
|
|
end
|
|
|
|
def test_should_sum_field_with_conditions
|
|
assert_equal 105, Account.sum(:credit_limit, :conditions => 'firm_id = 6')
|
|
end
|
|
|
|
def test_should_return_zero_if_sum_conditions_return_nothing
|
|
assert_equal 0, Account.sum(:credit_limit, :conditions => '1 = 2')
|
|
assert_equal 0, companies(:rails_core).companies.sum(:id, :conditions => '1 = 2')
|
|
end
|
|
|
|
def test_sum_should_return_valid_values_for_decimals
|
|
NumericData.create(:bank_balance => 19.83)
|
|
assert_equal 19.83, NumericData.sum(:bank_balance)
|
|
end
|
|
|
|
def test_should_group_by_summed_field_with_conditions
|
|
c = Account.sum(:credit_limit, :conditions => 'firm_id > 1',
|
|
:group => :firm_id)
|
|
assert_nil c[1]
|
|
assert_equal 105, c[6]
|
|
assert_equal 60, c[2]
|
|
end
|
|
|
|
def test_should_group_by_summed_field_with_conditions_and_having
|
|
c = Account.sum(:credit_limit, :conditions => 'firm_id > 1',
|
|
:group => :firm_id,
|
|
:having => 'sum(credit_limit) > 60')
|
|
assert_nil c[1]
|
|
assert_equal 105, c[6]
|
|
assert_nil c[2]
|
|
end
|
|
|
|
def test_should_group_by_fields_with_table_alias
|
|
c = Account.sum(:credit_limit, :group => 'accounts.firm_id')
|
|
assert_equal 50, c[1]
|
|
assert_equal 105, c[6]
|
|
assert_equal 60, c[2]
|
|
end
|
|
|
|
def test_should_calculate_with_invalid_field
|
|
assert_equal 6, Account.calculate(:count, '*')
|
|
assert_equal 6, Account.calculate(:count, :all)
|
|
end
|
|
|
|
def test_should_calculate_grouped_with_invalid_field
|
|
c = Account.count(:all, :group => 'accounts.firm_id')
|
|
assert_equal 1, c[1]
|
|
assert_equal 2, c[6]
|
|
assert_equal 1, c[2]
|
|
end
|
|
|
|
def test_should_calculate_grouped_association_with_invalid_field
|
|
c = Account.count(:all, :group => :firm)
|
|
assert_equal 1, c[companies(:first_firm)]
|
|
assert_equal 2, c[companies(:rails_core)]
|
|
assert_equal 1, c[companies(:first_client)]
|
|
end
|
|
|
|
def test_should_group_by_association_with_non_numeric_foreign_key
|
|
ActiveRecord::Base.connection.expects(:select_all).returns([{"count_all" => 1, "firm_id" => "ABC"}])
|
|
|
|
firm = mock()
|
|
firm.expects(:id).returns("ABC")
|
|
firm.expects(:class).returns(Firm)
|
|
Company.expects(:find).with(["ABC"]).returns([firm])
|
|
|
|
column = mock()
|
|
column.expects(:name).at_least_once.returns(:firm_id)
|
|
column.expects(:type_cast).with("ABC").returns("ABC")
|
|
Account.expects(:columns).at_least_once.returns([column])
|
|
|
|
c = Account.count(:all, :group => :firm)
|
|
first_key = c.keys.first
|
|
assert_equal Firm, first_key.class
|
|
assert_equal 1, c[first_key]
|
|
end
|
|
|
|
def test_should_calculate_grouped_association_with_foreign_key_option
|
|
Account.belongs_to :another_firm, :class_name => 'Firm', :foreign_key => 'firm_id'
|
|
c = Account.count(:all, :group => :another_firm)
|
|
assert_equal 1, c[companies(:first_firm)]
|
|
assert_equal 2, c[companies(:rails_core)]
|
|
assert_equal 1, c[companies(:first_client)]
|
|
end
|
|
|
|
def test_should_not_modify_options_when_using_includes
|
|
options = {:conditions => 'companies.id > 1', :include => :firm}
|
|
options_copy = options.dup
|
|
|
|
Account.count(:all, options)
|
|
assert_equal options_copy, options
|
|
end
|
|
|
|
def test_should_calculate_grouped_by_function
|
|
c = Company.count(:all, :group => "UPPER(#{QUOTED_TYPE})")
|
|
assert_equal 2, c[nil]
|
|
assert_equal 1, c['DEPENDENTFIRM']
|
|
assert_equal 4, c['CLIENT']
|
|
assert_equal 2, c['FIRM']
|
|
end
|
|
|
|
def test_should_calculate_grouped_by_function_with_table_alias
|
|
c = Company.count(:all, :group => "UPPER(companies.#{QUOTED_TYPE})")
|
|
assert_equal 2, c[nil]
|
|
assert_equal 1, c['DEPENDENTFIRM']
|
|
assert_equal 4, c['CLIENT']
|
|
assert_equal 2, c['FIRM']
|
|
end
|
|
|
|
def test_should_not_overshadow_enumerable_sum
|
|
assert_equal 6, [1, 2, 3].sum(&:abs)
|
|
end
|
|
|
|
def test_should_sum_scoped_field
|
|
assert_equal 15, companies(:rails_core).companies.sum(:id)
|
|
end
|
|
|
|
def test_should_sum_scoped_field_with_from
|
|
assert_equal Club.count, Organization.clubs.count
|
|
end
|
|
|
|
def test_should_sum_scoped_field_with_conditions
|
|
assert_equal 8, companies(:rails_core).companies.sum(:id, :conditions => 'id > 7')
|
|
end
|
|
|
|
def test_should_group_by_scoped_field
|
|
c = companies(:rails_core).companies.sum(:id, :group => :name)
|
|
assert_equal 7, c['Leetsoft']
|
|
assert_equal 8, c['Jadedpixel']
|
|
end
|
|
|
|
def test_should_group_by_summed_field_through_association_and_having
|
|
c = companies(:rails_core).companies.sum(:id, :group => :name,
|
|
:having => 'sum(id) > 7')
|
|
assert_nil c['Leetsoft']
|
|
assert_equal 8, c['Jadedpixel']
|
|
end
|
|
|
|
def test_should_count_selected_field_with_include
|
|
assert_equal 6, Account.count(:distinct => true, :include => :firm)
|
|
assert_equal 4, Account.count(:distinct => true, :include => :firm, :select => :credit_limit)
|
|
end
|
|
|
|
def test_should_not_perform_joined_include_by_default
|
|
assert_equal Account.count, Account.includes(:firm).count
|
|
queries = assert_sql { Account.includes(:firm).count }
|
|
assert_no_match(/join/i, queries.last)
|
|
end
|
|
|
|
def test_should_perform_joined_include_when_referencing_included_tables
|
|
joined_count = Account.includes(:firm).where(:companies => {:name => '37signals'}).count
|
|
assert_equal 1, joined_count
|
|
end
|
|
|
|
def test_should_count_scoped_select
|
|
Account.update_all("credit_limit = NULL")
|
|
assert_equal 0, Account.scoped(:select => "credit_limit").count
|
|
end
|
|
|
|
def test_should_count_scoped_select_with_options
|
|
Account.update_all("credit_limit = NULL")
|
|
Account.last.update_column('credit_limit', 49)
|
|
Account.first.update_column('credit_limit', 51)
|
|
|
|
assert_equal 1, Account.scoped(:select => "credit_limit").count(:conditions => ['credit_limit >= 50'])
|
|
end
|
|
|
|
def test_should_count_manual_select_with_include
|
|
assert_equal 6, Account.count(:select => "DISTINCT accounts.id", :include => :firm)
|
|
end
|
|
|
|
def test_count_with_column_parameter
|
|
assert_equal 5, Account.count(:firm_id)
|
|
end
|
|
|
|
def test_count_with_column_and_options_parameter
|
|
assert_equal 2, Account.count(:firm_id, :conditions => "credit_limit = 50 AND firm_id IS NOT NULL")
|
|
end
|
|
|
|
def test_should_count_field_in_joined_table
|
|
assert_equal 5, Account.count('companies.id', :joins => :firm)
|
|
assert_equal 4, Account.count('companies.id', :joins => :firm, :distinct => true)
|
|
end
|
|
|
|
def test_should_count_field_in_joined_table_with_group_by
|
|
c = Account.count('companies.id', :group => 'accounts.firm_id', :joins => :firm)
|
|
|
|
[1,6,2,9].each { |firm_id| assert c.keys.include?(firm_id) }
|
|
end
|
|
|
|
def test_count_with_no_parameters_isnt_deprecated
|
|
assert_not_deprecated { Account.count }
|
|
end
|
|
|
|
def test_count_with_too_many_parameters_raises
|
|
assert_raise(ArgumentError) { Account.count(1, 2, 3) }
|
|
end
|
|
|
|
def test_should_sum_expression
|
|
# Oracle adapter returns floating point value 636.0 after SUM
|
|
if current_adapter?(:OracleAdapter)
|
|
assert_equal 636, Account.sum("2 * credit_limit")
|
|
else
|
|
assert_equal 636, Account.sum("2 * credit_limit").to_i
|
|
end
|
|
end
|
|
|
|
def test_count_with_from_option
|
|
assert_equal Company.count(:all), Company.count(:all, :from => 'companies')
|
|
assert_equal Account.count(:all, :conditions => "credit_limit = 50"),
|
|
Account.count(:all, :from => 'accounts', :conditions => "credit_limit = 50")
|
|
assert_equal Company.count(:type, :conditions => {:type => "Firm"}),
|
|
Company.count(:type, :conditions => {:type => "Firm"}, :from => 'companies')
|
|
end
|
|
|
|
def test_sum_with_from_option
|
|
assert_equal Account.sum(:credit_limit), Account.sum(:credit_limit, :from => 'accounts')
|
|
assert_equal Account.sum(:credit_limit, :conditions => "credit_limit > 50"),
|
|
Account.sum(:credit_limit, :from => 'accounts', :conditions => "credit_limit > 50")
|
|
end
|
|
|
|
def test_average_with_from_option
|
|
assert_equal Account.average(:credit_limit), Account.average(:credit_limit, :from => 'accounts')
|
|
assert_equal Account.average(:credit_limit, :conditions => "credit_limit > 50"),
|
|
Account.average(:credit_limit, :from => 'accounts', :conditions => "credit_limit > 50")
|
|
end
|
|
|
|
def test_minimum_with_from_option
|
|
assert_equal Account.minimum(:credit_limit), Account.minimum(:credit_limit, :from => 'accounts')
|
|
assert_equal Account.minimum(:credit_limit, :conditions => "credit_limit > 50"),
|
|
Account.minimum(:credit_limit, :from => 'accounts', :conditions => "credit_limit > 50")
|
|
end
|
|
|
|
def test_maximum_with_from_option
|
|
assert_equal Account.maximum(:credit_limit), Account.maximum(:credit_limit, :from => 'accounts')
|
|
assert_equal Account.maximum(:credit_limit, :conditions => "credit_limit > 50"),
|
|
Account.maximum(:credit_limit, :from => 'accounts', :conditions => "credit_limit > 50")
|
|
end
|
|
|
|
def test_from_option_with_specified_index
|
|
if Edge.connection.adapter_name == 'MySQL' or Edge.connection.adapter_name == 'Mysql2'
|
|
assert_equal Edge.count(:all), Edge.count(:all, :from => 'edges USE INDEX(unique_edge_index)')
|
|
assert_equal Edge.count(:all, :conditions => 'sink_id < 5'),
|
|
Edge.count(:all, :from => 'edges USE INDEX(unique_edge_index)', :conditions => 'sink_id < 5')
|
|
end
|
|
end
|
|
|
|
def test_from_option_with_table_different_than_class
|
|
assert_equal Account.count(:all), Company.count(:all, :from => 'accounts')
|
|
end
|
|
|
|
def test_distinct_is_honored_when_used_with_count_operation_after_group
|
|
# Count the number of authors for approved topics
|
|
approved_topics_count = Topic.group(:approved).count(:author_name)[true]
|
|
assert_equal approved_topics_count, 3
|
|
# Count the number of distinct authors for approved Topics
|
|
distinct_authors_for_approved_count = Topic.group(:approved).count(:author_name, :distinct => true)[true]
|
|
assert_equal distinct_authors_for_approved_count, 2
|
|
end
|
|
end
|