rails--rails/activerecord/test/models/toy.rb at af43e719ac45ea3f8589b07d4d1d43d8bf0a31e9 - kotovalexarian-likes-github/rails--rails - Forgejo by Causa Arcana

kotovalexarian-likes-github/rails--rails

mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Jon Leighton 0a12a5f816 Deprecate eager-evaluated scopes.

Don't use this:

    scope :red, where(color: 'red')
    default_scope where(color: 'red')

Use this:

    scope :red, -> { where(color: 'red') }
    default_scope { where(color: 'red') }

The former has numerous issues. It is a common newbie gotcha to do
the following:

    scope :recent, where(published_at: Time.now - 2.weeks)

Or a more subtle variant:

    scope :recent, -> { where(published_at: Time.now - 2.weeks) }
    scope :recent_red, recent.where(color: 'red')

Eager scopes are also very complex to implement within Active
Record, and there are still bugs. For example, the following does
not do what you expect:

    scope :remove_conditions, except(:where)
    where(...).remove_conditions # => still has conditions

2012-03-21 22:18:18 +00:00

6 lines

121 B

Ruby

Raw Blame History

 class Toy < ActiveRecord::Base
   self.primary_key = :toy_id
   belongs_to :pet
   scope :with_pet, -> { joins(:pet) }
 end