1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionpack/lib
eileencodes 5d1b7c3b44 Remove literal? check to fix issue with prefixed optionals
In commit d993cb3 `build_path` was changed from using `grep` to
`find_all` to save array allocations.

This change was a little too aggressive in that when the dash comes
before the symbol like `/omg-:song` the symbol is skipped.

Removing the check for `n.right.left.literal?` fixes this issue, but
does add back some allocations. The number of allocations are still well
less than before.

I've added a regression test to test this behavior for the future.

Fixes #23069.

Array allocations as of d993cb3:

```
{:T_SYMBOL=>11}
{:T_REGEXP=>17}
{:T_STRUCT=>6500}
{:T_MATCH=>12004}
{:T_OBJECT=>91009}
{:T_DATA=>100088}
{:T_HASH=>114013}
{:T_STRING=>159637}
{:T_ARRAY=>321056}
{:T_IMEMO=>351133}
```

Array allocations after this change:

```
{:T_SYMBOL=>11}
{:T_REGEXP=>1017}
{:T_STRUCT=>6500}
{:T_MATCH=>12004}
{:T_DATA=>84092}
{:T_OBJECT=>87009}
{:T_HASH=>110015}
{:T_STRING=>166152}
{:T_ARRAY=>322056}
{:T_NODE=>343558}
```
2016-01-16 15:00:18 -05:00
..
abstract_controller Merge branch 'master' of github.com:rails/docrails 2015-12-20 12:33:46 +00:00
action_controller remove present? calls 2016-01-12 14:22:02 -08:00
action_dispatch Remove literal? check to fix issue with prefixed optionals 2016-01-16 15:00:18 -05:00
action_pack Change alpha to beta1 to prep for release of Rails 5 2015-12-18 12:14:09 -05:00
abstract_controller.rb Remove not used requires 2015-09-01 20:36:47 +02:00
action_controller.rb remove RackDelegation module 2015-08-26 11:53:15 -07:00
action_dispatch.rb Add both HTTP Response Code and Type to assertion messages 2016-01-12 13:09:00 -07:00
action_pack.rb Update copyright notices to 2016 [ci skip] 2015-12-31 18:27:19 +02:00