1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionpack/test
eileencodes 5d1b7c3b44 Remove literal? check to fix issue with prefixed optionals
In commit d993cb3 `build_path` was changed from using `grep` to
`find_all` to save array allocations.

This change was a little too aggressive in that when the dash comes
before the symbol like `/omg-:song` the symbol is skipped.

Removing the check for `n.right.left.literal?` fixes this issue, but
does add back some allocations. The number of allocations are still well
less than before.

I've added a regression test to test this behavior for the future.

Fixes #23069.

Array allocations as of d993cb3:

```
{:T_SYMBOL=>11}
{:T_REGEXP=>17}
{:T_STRUCT=>6500}
{:T_MATCH=>12004}
{:T_OBJECT=>91009}
{:T_DATA=>100088}
{:T_HASH=>114013}
{:T_STRING=>159637}
{:T_ARRAY=>321056}
{:T_IMEMO=>351133}
```

Array allocations after this change:

```
{:T_SYMBOL=>11}
{:T_REGEXP=>1017}
{:T_STRUCT=>6500}
{:T_MATCH=>12004}
{:T_DATA=>84092}
{:T_OBJECT=>87009}
{:T_HASH=>110015}
{:T_STRING=>166152}
{:T_ARRAY=>322056}
{:T_NODE=>343558}
```
2016-01-16 15:00:18 -05:00
..
abstract Revert "ActionController::Base#process() now only takes an action name" 2015-10-29 16:18:27 -07:00
assertions Add both HTTP Response Code and Type to assertion messages 2016-01-12 13:09:00 -07:00
controller Remove literal? check to fix issue with prefixed optionals 2016-01-16 15:00:18 -05:00
dispatch Merge pull request #23035 from jkowens/fix-null-byte 2016-01-12 19:46:42 -02:00
fixtures Add failing spec on utf8 filename with percent character 2015-08-04 21:27:22 +09:00
journey Remove TestRouter#add_routes 2015-09-29 13:43:11 +09:00
lib/controller
routing
tmp
abstract_unit.rb do not run in parallel on travis 2016-01-12 15:55:47 -08:00