mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
dd5cbf58ed
Previously a path starting with ./ would be replaced to start with /. IMO this didn't particularly make sense since / reads as though it's from the root of the filesystem. This commit removes that filter, preserves ./, and updates the silencer not to remove lines starting with ./
45 lines
1.7 KiB
Ruby
45 lines
1.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "abstract_unit"
|
|
require "rails/backtrace_cleaner"
|
|
|
|
class BacktraceCleanerTest < ActiveSupport::TestCase
|
|
def setup
|
|
@cleaner = Rails::BacktraceCleaner.new
|
|
end
|
|
|
|
test "should consider traces from irb lines as User code" do
|
|
backtrace = [ "(irb):1",
|
|
"/Path/to/rails/railties/lib/rails/commands/console.rb:77:in `start'",
|
|
"bin/rails:4:in `<main>'" ]
|
|
result = @cleaner.clean(backtrace)
|
|
assert_equal "(irb):1", result[0]
|
|
assert_equal 1, result.length
|
|
end
|
|
|
|
test "should show relative paths" do
|
|
backtrace = [ "./test/backtrace_cleaner_test.rb:123",
|
|
"/Path/to/rails/activesupport/some_testing_file.rb:42:in `test'",
|
|
"bin/rails:4:in `<main>'" ]
|
|
result = @cleaner.clean(backtrace)
|
|
assert_equal "./test/backtrace_cleaner_test.rb:123", result[0]
|
|
assert_equal 1, result.length
|
|
end
|
|
|
|
test "can filter for noise" do
|
|
backtrace = [ "(irb):1",
|
|
"/Path/to/rails/railties/lib/rails/commands/console.rb:77:in `start'",
|
|
"bin/rails:4:in `<main>'" ]
|
|
result = @cleaner.clean(backtrace, :noise)
|
|
assert_equal "/Path/to/rails/railties/lib/rails/commands/console.rb:77:in `start'", result[0]
|
|
assert_equal "bin/rails:4:in `<main>'", result[1]
|
|
assert_equal 2, result.length
|
|
end
|
|
|
|
test "should omit ActionView template methods names" do
|
|
method_name = ActionView::Template.new(nil, "app/views/application/index.html.erb", nil, locals: []).send :method_name
|
|
backtrace = [ "app/views/application/index.html.erb:4:in `block in #{method_name}'"]
|
|
result = @cleaner.clean(backtrace, :all)
|
|
assert_equal "app/views/application/index.html.erb:4", result[0]
|
|
end
|
|
end
|