kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
rails--rails/railties/test
History
yuuji.yaginuma be4ebc4780 Treat secrets as binary 
Until Rails 5.1.1 secrets was treated as binary inside Rails.
https://github.com/rails/rails/blob/v5.1.1/railties/lib/rails/secrets.rb#L59
https://github.com/rails/rails/blob/v5.1.1/railties/lib/rails/secrets.rb#L63

However, it is treated as String in Rails 5.1.2(changed by 157db87210).
https://github.com/rails/rails/blob/v5.1.2/railties/lib/rails/secrets.rb#L104
https://github.com/rails/rails/blob/v5.1.2/railties/lib/rails/secrets.rb#L108

As a result, when upgrading from Rails 5.1.1 to 5.1.2, to write the value
treated as binary using `File.write`, causing an error.

In order to avoid `UndefinedConversionError`, fixed it to treat it as
binary like 5.1.1.
Fixes #29696
2017-07-09 09:25:45 +09:00
..
application Merge pull request #29677 from eugeneius/parameters_configuration_tests 2017-07-05 12:24:09 -04:00
command Add rails secrets:show command 2017-07-07 07:22:01 +09:00
commands Add rails secrets:show command 2017-07-07 07:22:01 +09:00
configuration Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
engine Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
fixtures Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
generators Update default app files in app_generator_test 2017-07-06 06:42:14 +09:00
isolation Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
railties Allow mounting same engine under several locations 2017-07-05 19:17:51 +02:00
test_unit Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
abstract_unit.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
app_loader_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
backtrace_cleaner_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
code_statistics_calculator_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
code_statistics_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
engine_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
env_helpers.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
generators_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
initializable_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
json_params_parsing_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
path_generation_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
paths_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
rack_logger_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
rails_info_controller_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
rails_info_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30
secrets_test.rb Treat secrets as binary 2017-07-09 09:25:45 +09:00
version_test.rb Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 2017-07-02 02:15:17 +09:30