mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
906aebceed
Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0:2259ecf368
AR not available * This will be reimplemented with ActionORM or equivalent06182ea02e
implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically893e9eb995
Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated:199e750d46
3942cb406e
f8ea9f85d4
e3b166aab3
ae9f258e03
44423126c6
0cb020b4d6
workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change.8c5cc66a83
make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base.87e8b16246
fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
94 lines
3.1 KiB
Ruby
94 lines
3.1 KiB
Ruby
module ActionController #:nodoc:
|
|
# Cookies are read and written through ActionController#cookies.
|
|
#
|
|
# The cookies being read are the ones received along with the request, the cookies
|
|
# being written will be sent out with the response. Reading a cookie does not get
|
|
# the cookie object itself back, just the value it holds.
|
|
#
|
|
# Examples for writing:
|
|
#
|
|
# # Sets a simple session cookie.
|
|
# cookies[:user_name] = "david"
|
|
#
|
|
# # Sets a cookie that expires in 1 hour.
|
|
# cookies[:login] = { :value => "XJ-122", :expires => 1.hour.from_now }
|
|
#
|
|
# Examples for reading:
|
|
#
|
|
# cookies[:user_name] # => "david"
|
|
# cookies.size # => 2
|
|
#
|
|
# Example for deleting:
|
|
#
|
|
# cookies.delete :user_name
|
|
#
|
|
# Please note that if you specify a :domain when setting a cookie, you must also specify the domain when deleting the cookie:
|
|
#
|
|
# cookies[:key] = {
|
|
# :value => 'a yummy cookie',
|
|
# :expires => 1.year.from_now,
|
|
# :domain => 'domain.com'
|
|
# }
|
|
#
|
|
# cookies.delete(:key, :domain => 'domain.com')
|
|
#
|
|
# The option symbols for setting cookies are:
|
|
#
|
|
# * <tt>:value</tt> - The cookie's value or list of values (as an array).
|
|
# * <tt>:path</tt> - The path for which this cookie applies. Defaults to the root
|
|
# of the application.
|
|
# * <tt>:domain</tt> - The domain for which this cookie applies.
|
|
# * <tt>:expires</tt> - The time at which this cookie expires, as a Time object.
|
|
# * <tt>:secure</tt> - Whether this cookie is a only transmitted to HTTPS servers.
|
|
# Default is +false+.
|
|
# * <tt>:httponly</tt> - Whether this cookie is accessible via scripting or
|
|
# only HTTP. Defaults to +false+.
|
|
module Cookies
|
|
def self.included(base)
|
|
base.helper_method :cookies
|
|
end
|
|
|
|
protected
|
|
# Returns the cookie container, which operates as described above.
|
|
def cookies
|
|
CookieJar.new(self)
|
|
end
|
|
end
|
|
|
|
class CookieJar < Hash #:nodoc:
|
|
def initialize(controller)
|
|
@controller, @cookies = controller, controller.request.cookies
|
|
super()
|
|
update(@cookies)
|
|
end
|
|
|
|
# Returns the value of the cookie by +name+, or +nil+ if no such cookie exists.
|
|
def [](name)
|
|
super(name.to_s)
|
|
end
|
|
|
|
# Sets the cookie named +name+. The second argument may be the very cookie
|
|
# value, or a hash of options as documented above.
|
|
def []=(key, options)
|
|
if options.is_a?(Hash)
|
|
options.symbolize_keys!
|
|
else
|
|
options = { :value => options }
|
|
end
|
|
|
|
options[:path] = "/" unless options.has_key?(:path)
|
|
super(key.to_s, options[:value])
|
|
@controller.response.set_cookie(key, options)
|
|
end
|
|
|
|
# Removes the cookie on the client machine by setting the value to an empty string
|
|
# and setting its expiration date into the past. Like <tt>[]=</tt>, you can pass in
|
|
# an options hash to delete cookies with extra data such as a <tt>:path</tt>.
|
|
def delete(key, options = {})
|
|
options.symbolize_keys!
|
|
options[:path] = "/" unless options.has_key?(:path)
|
|
super(key.to_s)
|
|
@controller.response.delete_cookie(key, options)
|
|
end
|
|
end
|
|
end
|