mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
906aebceed
Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0:2259ecf368AR not available * This will be reimplemented with ActionORM or equivalent06182ea02eimplicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically893e9eb995Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated:199e750d463942cb406ef8ea9f85d4e3b166aab3ae9f258e0344423126c60cb020b4d6workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change.8c5cc66a83make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base.87e8b16246fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
90 lines
2.7 KiB
Ruby
90 lines
2.7 KiB
Ruby
require 'abstract_unit'
|
|
|
|
class MiddlewareStackTest < ActiveSupport::TestCase
|
|
class FooMiddleware; end
|
|
class BarMiddleware; end
|
|
class BazMiddleware; end
|
|
|
|
def setup
|
|
@stack = ActionDispatch::MiddlewareStack.new
|
|
@stack.use FooMiddleware
|
|
@stack.use BarMiddleware
|
|
end
|
|
|
|
test "use should push middleware as class onto the stack" do
|
|
assert_difference "@stack.size" do
|
|
@stack.use BazMiddleware
|
|
end
|
|
assert_equal BazMiddleware, @stack.last.klass
|
|
end
|
|
|
|
test "use should push middleware as a string onto the stack" do
|
|
assert_difference "@stack.size" do
|
|
@stack.use "MiddlewareStackTest::BazMiddleware"
|
|
end
|
|
assert_equal BazMiddleware, @stack.last.klass
|
|
end
|
|
|
|
test "use should push middleware as a symbol onto the stack" do
|
|
assert_difference "@stack.size" do
|
|
@stack.use :"MiddlewareStackTest::BazMiddleware"
|
|
end
|
|
assert_equal BazMiddleware, @stack.last.klass
|
|
end
|
|
|
|
test "use should push middleware class with arguments onto the stack" do
|
|
assert_difference "@stack.size" do
|
|
@stack.use BazMiddleware, true, :foo => "bar"
|
|
end
|
|
assert_equal BazMiddleware, @stack.last.klass
|
|
assert_equal([true, {:foo => "bar"}], @stack.last.args)
|
|
end
|
|
|
|
test "insert inserts middleware at the integer index" do
|
|
@stack.insert(1, BazMiddleware)
|
|
assert_equal BazMiddleware, @stack[1].klass
|
|
end
|
|
|
|
test "insert_after inserts middleware after the integer index" do
|
|
@stack.insert_after(1, BazMiddleware)
|
|
assert_equal BazMiddleware, @stack[2].klass
|
|
end
|
|
|
|
test "insert_before inserts middleware before another middleware class" do
|
|
@stack.insert_before(BarMiddleware, BazMiddleware)
|
|
assert_equal BazMiddleware, @stack[1].klass
|
|
end
|
|
|
|
test "insert_after inserts middleware after another middleware class" do
|
|
@stack.insert_after(BarMiddleware, BazMiddleware)
|
|
assert_equal BazMiddleware, @stack[2].klass
|
|
end
|
|
|
|
test "swaps one middleware out for another" do
|
|
assert_equal FooMiddleware, @stack[0].klass
|
|
@stack.swap(FooMiddleware, BazMiddleware)
|
|
assert_equal BazMiddleware, @stack[0].klass
|
|
end
|
|
|
|
test "active returns all only enabled middleware" do
|
|
assert_no_difference "@stack.active.size" do
|
|
assert_difference "@stack.size" do
|
|
@stack.use BazMiddleware, :if => lambda { false }
|
|
end
|
|
end
|
|
end
|
|
|
|
test "lazy evaluates middleware class" do
|
|
assert_difference "@stack.size" do
|
|
@stack.use lambda { BazMiddleware }
|
|
end
|
|
assert_equal BazMiddleware, @stack.last.klass
|
|
end
|
|
|
|
test "lazy evaluates middleware arguments" do
|
|
assert_difference "@stack.size" do
|
|
@stack.use BazMiddleware, lambda { :foo }
|
|
end
|
|
assert_equal [:foo], @stack.last.send(:build_args)
|
|
end
|
|
end
|