mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
8afdfdcfc9
In #33325, `deprecate_methods` is replaced from `prepend` to completely emurated `alias_method_chain`, it exposed two internal methods `xxx_with_deprecation` and `xxx_without_deprecation`. After that, #34648 restored the `prepend` implementation, which doesn't expose any internal methods, so we no longer be able to ensure to always expose that internal methods. As I said at https://github.com/rails/rails/pull/33325#issuecomment-409016725, I think that internal methods exposed is not a specification but a limitation when using `alias_method_chain`, there is no longer a reason to follow that limitation.
92 lines
3.2 KiB
Ruby
92 lines
3.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "abstract_unit"
|
|
require "active_support/deprecation"
|
|
|
|
class MethodWrappersTest < ActiveSupport::TestCase
|
|
def setup
|
|
@klass = Class.new do
|
|
def new_method; "abc" end
|
|
alias_method :old_method, :new_method
|
|
|
|
protected
|
|
|
|
def new_protected_method; "abc" end
|
|
alias_method :old_protected_method, :new_protected_method
|
|
|
|
private
|
|
|
|
def new_private_method; "abc" end
|
|
alias_method :old_private_method, :new_private_method
|
|
end
|
|
end
|
|
|
|
def test_deprecate_methods_without_alternate_method
|
|
warning = /old_method is deprecated and will be removed from Rails \d.\d./
|
|
ActiveSupport::Deprecation.deprecate_methods(@klass, :old_method)
|
|
|
|
assert_deprecated(warning) { assert_equal "abc", @klass.new.old_method }
|
|
end
|
|
|
|
def test_deprecate_methods_warning_default
|
|
warning = /old_method is deprecated and will be removed from Rails \d.\d \(use new_method instead\)/
|
|
ActiveSupport::Deprecation.deprecate_methods(@klass, old_method: :new_method)
|
|
|
|
assert_deprecated(warning) { assert_equal "abc", @klass.new.old_method }
|
|
end
|
|
|
|
def test_deprecate_methods_warning_with_optional_deprecator
|
|
warning = /old_method is deprecated and will be removed from MyGem next-release \(use new_method instead\)/
|
|
deprecator = ActiveSupport::Deprecation.new("next-release", "MyGem")
|
|
ActiveSupport::Deprecation.deprecate_methods(@klass, old_method: :new_method, deprecator: deprecator)
|
|
|
|
assert_deprecated(warning, deprecator) { assert_equal "abc", @klass.new.old_method }
|
|
end
|
|
|
|
def test_deprecate_methods_warning_when_deprecated_with_custom_deprecator
|
|
warning = /old_method is deprecated and will be removed from MyGem next-release \(use new_method instead\)/
|
|
deprecator = ActiveSupport::Deprecation.new("next-release", "MyGem")
|
|
deprecator.deprecate_methods(@klass, old_method: :new_method)
|
|
|
|
assert_deprecated(warning, deprecator) { assert_equal "abc", @klass.new.old_method }
|
|
end
|
|
|
|
def test_deprecate_methods_protected_method
|
|
ActiveSupport::Deprecation.deprecate_methods(@klass, old_protected_method: :new_protected_method)
|
|
|
|
assert(@klass.protected_method_defined?(:old_protected_method))
|
|
end
|
|
|
|
def test_deprecate_methods_private_method
|
|
ActiveSupport::Deprecation.deprecate_methods(@klass, old_private_method: :new_private_method)
|
|
|
|
assert(@klass.private_method_defined?(:old_private_method))
|
|
end
|
|
|
|
def test_deprecate_class_method
|
|
mod = Module.new do
|
|
extend self
|
|
|
|
def old_method
|
|
"abc"
|
|
end
|
|
end
|
|
ActiveSupport::Deprecation.deprecate_methods(mod, old_method: :new_method)
|
|
|
|
warning = /old_method is deprecated and will be removed from Rails \d.\d \(use new_method instead\)/
|
|
assert_deprecated(warning) { assert_equal "abc", mod.old_method }
|
|
end
|
|
|
|
def test_deprecate_method_when_class_extends_module
|
|
mod = Module.new do
|
|
def old_method
|
|
"abc"
|
|
end
|
|
end
|
|
@klass.extend mod
|
|
ActiveSupport::Deprecation.deprecate_methods(mod, old_method: :new_method)
|
|
|
|
warning = /old_method is deprecated and will be removed from Rails \d.\d \(use new_method instead\)/
|
|
assert_deprecated(warning) { assert_equal "abc", @klass.old_method }
|
|
end
|
|
end
|