Sean Griffin c80487eb1a Don't rely on relation mutability when building through associations ... Specifically, the issue is relying on `where_unscoping` mutating the where values. It does not, however, mutate the bind values, which could cause an error under certain circumstances. This was not exposed by the tests, since the only place which would have been affected is unscoping a boolean, which doesn't go through prepared statements. I had a hard time getting better test coverage to demonstrate the issue. This in turn, caused `merge` to go through proper logic, and try to clear out the binds associated with the unscoped relation, which then exposed a source of `nil` for the columns, as binds weren't expanding `{ "posts.id" => 1 }` to `{ "posts" => { "id" => 1 } }`. This has been fixed. The bulk of `create_binds` needed to be moved to a separate method, since the dot notation should not be expanded recursively. I'm pretty sure this removes a subtle quirk that a ton of code in `Relation::Merger` is working around, and I suspect that code can be greatly simplified. However, unraveling that rats nest is no small task.		2015-01-24 19:51:26 -07:00
..
active_record	Don't rely on relation mutability when building through associations	2015-01-24 19:51:26 -07:00
rails/generators	Add Secure Token Generator	2015-01-11 14:42:54 -05:00
active_record.rb	Add has_secure_token to Active Record	2015-01-04 11:31:37 -05:00