eileencodes 73f8c16601 Ensure suppressor runs before validations ... I ran into an issue where validations on a suppressed record were causing validation errors to be thrown on a record that was never going to be saved. There isn't a reason to run the validations on a record that doesn't matter. This change moves the suppressor up the chain to be run on the `save` or `save!` in the validations rather than in persistence. The issue with running it when we hit persistence is that the validations are run first, then we hit persistance, and then we hit the suppressor. The suppressor comes first. The change to the test was required since I added the `validates_presence_of` validations. Adding this alone was enough to demonstrate the issue. I added a new test to demonstrate the new behavior is explict.		2016-02-24 14:33:22 -05:00
..
admin	Add line endings to files which are missing them	2015-02-17 13:28:06 -07:00
autoloadable	Fix ActiveRecord subclass_from_attrs when eager_load is false.	2013-03-06 11:46:07 +04:00
publisher	Fix has_and_belongs_to_many in a namespaced model pointing to a non namespaced model	2014-06-19 14:59:48 -03:00
admin.rb	Add line endings to files which are missing them	2015-02-17 13:28:06 -07:00
aircraft.rb	Fix counter_cache for polymorphic associations	2015-07-19 15:52:29 -06:00
arunit2_model.rb
author.rb	Typos in AR tests	2016-02-03 22:08:13 +09:00
auto_id.rb	✂️ [ci skip]	2013-09-10 19:49:42 +02:00
binary.rb	Add line endings to files which are missing them	2015-02-17 13:28:06 -07:00
bird.rb	Deprecate false as the way to halt AR callbacks	2015-01-02 15:31:56 -08:00
book.rb	Use the database type to deserialize enum	2016-01-23 08:44:16 -07:00
boolean.rb
bulb.rb	Bugfix collection association #create method …	2015-11-23 16:22:03 +02:00
cake_designer.rb	scope_chain should not be mutated for other reflections	2013-10-14 11:59:59 -04:00
car.rb	Fixed where for polymorphic associations when passed an array containing different types.	2016-02-16 10:41:26 -08:00
carrier.rb	Skip statement cache on through association reader	2015-08-12 21:17:30 -03:00
categorization.rb	Require explicit counter_cache option for has_many	2015-04-07 17:50:41 +10:00
category.rb	Pass a base relation to build_default_scope when joining	2014-02-21 17:58:40 -05:00
chef.rb	Add missing source_type if provided on hmt which belongs to an sti record	2016-01-24 22:25:12 +05:30
citation.rb	More unused associations in AR test models	2013-09-10 19:50:00 +02:00
club.rb	Merge pull request #15772 from nbudin/sti_through_bug	2014-06-19 15:07:11 -03:00
college.rb	Fix error when using with_options with lambda.	2014-04-03 10:26:37 -03:00
column.rb	Fix the test defining the models in the right place	2014-04-04 19:44:17 -03:00
column_name.rb	Changing the def self.table_name to self.table_name in the column_name.rb	2013-08-03 23:59:28 +05:30
comment.rb	Allow joins to be unscoped	2016-01-31 02:30:09 +09:00
company.rb	Revert "Merge pull request #21994 from mtodd/inherit-scopes"	2015-10-27 01:12:03 -02:00
company_in_module.rb	Deprecate ActiveModel::Errors add_on_empty and add_on_blank methods	2015-02-19 14:10:38 +01:00
computer.rb
contact.rb	introduce conn.data_source_exists? and conn.data_sources.	2015-09-22 19:48:44 +02:00
content.rb	Add support for bidirectional destroy dependencies	2015-01-16 11:41:43 +00:00
contract.rb	adding a test to demonstrate how to use STI subclasses on the far right	2013-09-27 16:56:49 -07:00
country.rb
course.rb
customer.rb	Pass symbol as an argument instead of a block	2014-11-29 11:53:24 +01:00
customer_carrier.rb	Skip statement cache on through association reader	2015-08-12 21:17:30 -03:00
dashboard.rb
default.rb
department.rb	scope_chain should not be mutated for other reflections	2013-10-14 11:59:59 -04:00
developer.rb	Fix merge conflicts for #19938	2015-10-20 16:57:47 -06:00
dog.rb	Update other counter caches on destroy	2013-03-20 13:43:07 -07:00
dog_lover.rb	Update other counter caches on destroy	2013-03-20 13:43:07 -07:00
doubloon.rb	Fix crash when loading fixture with belongs_to association defined in abstract base class.	2015-06-04 12:38:00 -04:00
drink_designer.rb	scope_chain should not be mutated for other reflections	2013-10-14 11:59:59 -04:00
edge.rb
electron.rb	Revert "Merge pull request #20080 from robertjlooby/fix_overwriting_by_dynamic_finders"	2015-09-09 06:08:57 -03:00
engine.rb
entrant.rb
essay.rb
event.rb	Add line endings to files which are missing them	2015-02-17 13:28:06 -07:00
eye.rb
face.rb	Typo fix [ci skip]	2015-09-07 21:29:00 +05:30
friendship.rb	Refactor Person/Friendship relationships to be more intuitive	2013-03-17 02:11:19 -04:00
guid.rb	Add line endings to files which are missing them	2015-02-17 13:28:06 -07:00
guitar.rb	Errors can be indexed with nested attributes	2015-04-17 14:11:16 -04:00
hotel.rb	Add missing source_type if provided on hmt which belongs to an sti record	2016-01-24 22:25:12 +05:30
image.rb	Add foreign_type option for polymorphic has_one and has_many.	2014-12-08 18:13:15 -02:00
interest.rb	Getting rid of the +automatic_inverse_of: false+ option in associations in favor	2013-06-08 10:16:51 -07:00
invoice.rb
item.rb
job.rb
joke.rb
keyboard.rb
legacy_thing.rb
lesson.rb
line_item.rb
liquid.rb	rename Relation#uniq to Relation#distinct. #uniq still works.	2013-03-15 14:15:47 +01:00
man.rb	Address ORA-00972: identifier is too long when tested with Oracle	2014-07-14 21:54:17 +09:00
matey.rb
member.rb	Skip statement cache on through association reader	2015-08-12 21:17:30 -03:00
member_detail.rb	Fix misleading errors for has_one through relations	2015-07-22 00:51:23 +03:00
member_type.rb
membership.rb	Skip statement cache on through association reader	2015-08-12 21:17:30 -03:00
mentor.rb	Fix for activerecord join dependency instantiate bug	2015-05-04 18:06:06 +03:00
minimalistic.rb
minivan.rb
mixed_case_monkey.rb	docs, AR already auto-detects primary keys. Closes #13946. [ci skip]	2014-02-05 08:52:59 +01:00
mocktail_designer.rb	Add missing source_type if provided on hmt which belongs to an sti record	2016-01-24 22:25:12 +05:30
molecule.rb	Add test case for autosave HasMany with accepts_nested_attributes.	2014-02-08 18:57:26 -02:00
movie.rb	AR .persisted? throws SystemStackError for an unsaved model with a	2014-03-27 15:01:31 -03:00
node.rb	Add pending test for the great-grandparent touching bug from #19324	2015-06-25 14:23:06 +02:00
notification.rb	Ensure suppressor runs before validations	2016-02-24 14:33:22 -05:00
order.rb
organization.rb	Add setting of FK for throgh associations while building	2014-05-25 21:08:11 +07:00
owner.rb	AR specific length validator to respect marked_for_destruction.	2014-12-30 10:25:58 +01:00
parrot.rb	Remove unused scopes	2015-10-01 23:42:45 -05:00
person.rb	Remove unused scopes	2015-10-01 23:42:45 -05:00
personal_legacy_thing.rb	Dynamically modified schema and association would not be correctly reset	2014-09-06 23:28:18 +09:00
pet.rb	Add missing require to inheritance test	2013-04-03 14:48:57 -03:00
pirate.rb	Add line endings to files which are missing them	2015-02-17 13:28:06 -07:00
possession.rb
post.rb	Skip the STI condition when evaluating a default scope	2016-01-12 05:43:58 +10:30
price_estimate.rb
professor.rb	use correct DB connection for generated HABTM table	2015-08-07 12:33:09 -07:00
project.rb	Ensure has_and_belongs_to_many works with belongs_to_required_by_default	2015-10-29 16:53:49 -06:00
publisher.rb	Fix how to compute class name on habtm namespaced.	2014-05-13 11:26:46 -03:00
randomly_named_c1.rb	Fixes #18492	2015-01-14 21:36:58 +05:30
rating.rb	Revert "Merge pull request #14544 from jefflai2/named_scope_sti"	2014-05-21 12:15:57 -03:00
reader.rb	Merge pull request #14573 from habermann24/has_many_through_fix	2014-04-22 17:20:52 -05:00
recipe.rb	Fix leaky chain on polymorphic association	2015-03-15 10:39:42 -04:00
record.rb	Fix the test defining the models in the right place	2014-04-04 19:44:17 -03:00
reference.rb	Rename update_attributes method to update, keep update_attributes as an alias	2013-01-03 11:51:21 -05:00
reply.rb	Add test to AR's counter_cache_test.rb	2013-05-18 17:12:46 +09:00
ship.rb	Only nullify persisted has_one target associations	2015-08-24 11:49:43 +03:00
ship_part.rb	Always perform validations on nested attribute associations	2015-01-30 07:27:20 -07:00
shop.rb	Don't try to get the subclass if the inheritance column doesn't exist	2014-01-14 18:53:45 +05:30
shop_account.rb	Skip statement cache on through association reader	2015-08-12 21:17:30 -03:00
speedometer.rb	test case to prevent duplicated associations with custom PK.	2013-02-24 16:49:47 +01:00
sponsor.rb
string_key_object.rb
student.rb	Fix error when using with_options with lambda.	2014-04-03 10:26:37 -03:00
subject.rb
subscriber.rb
subscription.rb
tag.rb	The source option for has_many => through should accept String	2014-04-09 14:57:30 -03:00
tagging.rb	Deprecate automatic counter caches on has_many :through	2014-06-26 07:24:34 -06:00
task.rb	Revert "Unused methods, module, etc."	2013-01-24 21:44:02 +09:00
topic.rb	Deprecate passing conditions to AR::Relation destroy_all and delete_all methods	2015-09-06 16:14:16 +02:00
toy.rb
traffic_light.rb	test case for serialize default values.	2013-03-07 17:26:35 +01:00
treasure.rb	Add tests for associations without counter_cache	2015-04-09 14:53:34 +10:00
treaty.rb
tree.rb	Add pending test for the great-grandparent touching bug from #19324	2015-06-25 14:23:06 +02:00
tuning_peg.rb	Errors can be indexed with nested attributes	2015-04-17 14:11:16 -04:00
tyre.rb	Don't perform statement caching for find when called from a scope	2014-12-22 15:38:58 -07:00
user.rb	Revert "Merge pull request #20835 from glittershark/if-and-unless-in-secure-token"	2016-01-14 21:52:03 +01:00
uuid_child.rb	Auto-generate stable fixture UUIDs on PostgreSQL.	2014-01-07 19:05:50 +01:00
uuid_item.rb	Fix issue #23625	2016-02-18 00:32:38 -05:00
uuid_parent.rb	Auto-generate stable fixture UUIDs on PostgreSQL.	2014-01-07 19:05:50 +01:00
vegetables.rb
vehicle.rb	Prevent duplicating where clauses when model is extended from an abstract class	2015-04-15 23:02:32 +03:00
vertex.rb
warehouse_thing.rb
wheel.rb
without_table.rb
zine.rb