mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
4f107da4ff
When calling a query method on an attribute that was not selected by an ActiveRecord query, an ActiveModel::MissingAttributeError is not raised. Instead, a nil value is returned, which will return false once cast to boolean. This is undesirable, as we should not give the impression that we know the attribute's boolean value when we haven't loaded the attribute's (possibly) non-boolean value from the database. This issue is present on versions going back as far as 2.3, at least.
847 lines
32 KiB
Ruby
847 lines
32 KiB
Ruby
require "cases/helper"
|
|
require 'models/post'
|
|
require 'models/author'
|
|
require 'models/categorization'
|
|
require 'models/comment'
|
|
require 'models/company'
|
|
require 'models/topic'
|
|
require 'models/reply'
|
|
require 'models/entrant'
|
|
require 'models/project'
|
|
require 'models/developer'
|
|
require 'models/customer'
|
|
require 'models/toy'
|
|
|
|
class FinderTest < ActiveRecord::TestCase
|
|
fixtures :companies, :topics, :entrants, :developers, :developers_projects, :posts, :comments, :accounts, :authors, :customers, :categories, :categorizations
|
|
|
|
def test_find
|
|
assert_equal(topics(:first).title, Topic.find(1).title)
|
|
end
|
|
|
|
# find should handle strings that come from URLs
|
|
# (example: Category.find(params[:id]))
|
|
def test_find_with_string
|
|
assert_equal(Topic.find(1).title,Topic.find("1").title)
|
|
end
|
|
|
|
def test_exists
|
|
assert Topic.exists?(1)
|
|
assert Topic.exists?("1")
|
|
assert Topic.exists?(:author_name => "David")
|
|
assert Topic.exists?(:author_name => "Mary", :approved => true)
|
|
assert Topic.exists?(["parent_id = ?", 1])
|
|
assert !Topic.exists?(45)
|
|
assert !Topic.exists?(Topic.new)
|
|
|
|
begin
|
|
assert !Topic.exists?("foo")
|
|
rescue ActiveRecord::StatementInvalid
|
|
# PostgreSQL complains about string comparison with integer field
|
|
rescue Exception
|
|
flunk
|
|
end
|
|
|
|
assert_raise(NoMethodError) { Topic.exists?([1,2]) }
|
|
end
|
|
|
|
def test_exists_does_not_select_columns_without_alias
|
|
assert_sql(/SELECT\W+1 AS one FROM ["`]topics["`]/i) do
|
|
Topic.exists?
|
|
end
|
|
end
|
|
|
|
def test_exists_returns_true_with_one_record_and_no_args
|
|
assert Topic.exists?
|
|
end
|
|
|
|
def test_exists_returns_false_with_false_arg
|
|
assert !Topic.exists?(false)
|
|
end
|
|
|
|
# exists? should handle nil for id's that come from URLs and always return false
|
|
# (example: Topic.exists?(params[:id])) where params[:id] is nil
|
|
def test_exists_with_nil_arg
|
|
assert !Topic.exists?(nil)
|
|
assert Topic.exists?
|
|
assert !Topic.first.replies.exists?(nil)
|
|
assert Topic.first.replies.exists?
|
|
end
|
|
|
|
# ensures +exists?+ runs valid SQL by excluding order value
|
|
def test_exists_with_order
|
|
assert Topic.order(:id).uniq.exists?
|
|
end
|
|
|
|
def test_exists_with_includes_limit_and_empty_result
|
|
assert !Topic.includes(:replies).limit(0).exists?
|
|
assert !Topic.includes(:replies).limit(1).where('0 = 1').exists?
|
|
end
|
|
|
|
def test_exists_with_empty_table_and_no_args_given
|
|
Topic.delete_all
|
|
assert !Topic.exists?
|
|
end
|
|
|
|
def test_exists_with_aggregate_having_three_mappings
|
|
existing_address = customers(:david).address
|
|
assert Customer.exists?(:address => existing_address)
|
|
end
|
|
|
|
def test_exists_with_aggregate_having_three_mappings_with_one_difference
|
|
existing_address = customers(:david).address
|
|
assert !Customer.exists?(:address =>
|
|
Address.new(existing_address.street, existing_address.city, existing_address.country + "1"))
|
|
assert !Customer.exists?(:address =>
|
|
Address.new(existing_address.street, existing_address.city + "1", existing_address.country))
|
|
assert !Customer.exists?(:address =>
|
|
Address.new(existing_address.street + "1", existing_address.city, existing_address.country))
|
|
end
|
|
|
|
def test_exists_does_not_instantiate_records
|
|
Developer.expects(:instantiate).never
|
|
Developer.exists?
|
|
end
|
|
|
|
def test_find_by_array_of_one_id
|
|
assert_kind_of(Array, Topic.find([ 1 ]))
|
|
assert_equal(1, Topic.find([ 1 ]).length)
|
|
end
|
|
|
|
def test_find_by_ids
|
|
assert_equal 2, Topic.find(1, 2).size
|
|
assert_equal topics(:second).title, Topic.find([2]).first.title
|
|
end
|
|
|
|
def test_find_by_ids_with_limit_and_offset
|
|
assert_equal 2, Entrant.all.merge!(:limit => 2).find([1,3,2]).size
|
|
assert_equal 1, Entrant.all.merge!(:limit => 3, :offset => 2).find([1,3,2]).size
|
|
|
|
# Also test an edge case: If you have 11 results, and you set a
|
|
# limit of 3 and offset of 9, then you should find that there
|
|
# will be only 2 results, regardless of the limit.
|
|
devs = Developer.all
|
|
last_devs = Developer.all.merge!(:limit => 3, :offset => 9).find devs.map(&:id)
|
|
assert_equal 2, last_devs.size
|
|
end
|
|
|
|
def test_find_an_empty_array
|
|
assert_equal [], Topic.find([])
|
|
end
|
|
|
|
def test_find_doesnt_have_implicit_ordering
|
|
assert_sql(/^((?!ORDER).)*$/) { Topic.find(1) }
|
|
end
|
|
|
|
def test_find_by_ids_missing_one
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.find(1, 2, 45) }
|
|
end
|
|
|
|
def test_find_with_group_and_sanitized_having_method
|
|
developers = Developer.group(:salary).having("sum(salary) > ?", 10000).select('salary').to_a
|
|
assert_equal 3, developers.size
|
|
assert_equal 3, developers.map(&:salary).uniq.size
|
|
assert developers.all? { |developer| developer.salary > 10000 }
|
|
end
|
|
|
|
def test_find_with_entire_select_statement
|
|
topics = Topic.find_by_sql "SELECT * FROM topics WHERE author_name = 'Mary'"
|
|
|
|
assert_equal(1, topics.size)
|
|
assert_equal(topics(:second).title, topics.first.title)
|
|
end
|
|
|
|
def test_find_with_prepared_select_statement
|
|
topics = Topic.find_by_sql ["SELECT * FROM topics WHERE author_name = ?", "Mary"]
|
|
|
|
assert_equal(1, topics.size)
|
|
assert_equal(topics(:second).title, topics.first.title)
|
|
end
|
|
|
|
def test_find_by_sql_with_sti_on_joined_table
|
|
accounts = Account.find_by_sql("SELECT * FROM accounts INNER JOIN companies ON companies.id = accounts.firm_id")
|
|
assert_equal [Account], accounts.collect(&:class).uniq
|
|
end
|
|
|
|
def test_take
|
|
assert_equal topics(:first), Topic.take
|
|
end
|
|
|
|
def test_take_failing
|
|
assert_nil Topic.where("title = 'This title does not exist'").take
|
|
end
|
|
|
|
def test_take_bang_present
|
|
assert_nothing_raised do
|
|
assert_equal topics(:second), Topic.where("title = 'The Second Topic of the day'").take!
|
|
end
|
|
end
|
|
|
|
def test_take_bang_missing
|
|
assert_raises ActiveRecord::RecordNotFound do
|
|
Topic.where("title = 'This title does not exist'").take!
|
|
end
|
|
end
|
|
|
|
def test_first
|
|
assert_equal topics(:second).title, Topic.where("title = 'The Second Topic of the day'").first.title
|
|
end
|
|
|
|
def test_first_failing
|
|
assert_nil Topic.where("title = 'The Second Topic of the day!'").first
|
|
end
|
|
|
|
def test_first_bang_present
|
|
assert_nothing_raised do
|
|
assert_equal topics(:second), Topic.where("title = 'The Second Topic of the day'").first!
|
|
end
|
|
end
|
|
|
|
def test_first_bang_missing
|
|
assert_raises ActiveRecord::RecordNotFound do
|
|
Topic.where("title = 'This title does not exist'").first!
|
|
end
|
|
end
|
|
|
|
def test_first_have_primary_key_order_by_default
|
|
expected = topics(:first)
|
|
expected.touch # PostgreSQL changes the default order if no order clause is used
|
|
assert_equal expected, Topic.first
|
|
end
|
|
|
|
def test_model_class_responds_to_first_bang
|
|
assert Topic.first!
|
|
Topic.delete_all
|
|
assert_raises ActiveRecord::RecordNotFound do
|
|
Topic.first!
|
|
end
|
|
end
|
|
|
|
def test_last_bang_present
|
|
assert_nothing_raised do
|
|
assert_equal topics(:second), Topic.where("title = 'The Second Topic of the day'").last!
|
|
end
|
|
end
|
|
|
|
def test_last_bang_missing
|
|
assert_raises ActiveRecord::RecordNotFound do
|
|
Topic.where("title = 'This title does not exist'").last!
|
|
end
|
|
end
|
|
|
|
def test_model_class_responds_to_last_bang
|
|
assert_equal topics(:fourth), Topic.last!
|
|
assert_raises ActiveRecord::RecordNotFound do
|
|
Topic.delete_all
|
|
Topic.last!
|
|
end
|
|
end
|
|
|
|
def test_take_and_first_and_last_with_integer_should_use_sql_limit
|
|
assert_sql(/LIMIT 3|ROWNUM <= 3/) { Topic.take(3).entries }
|
|
assert_sql(/LIMIT 2|ROWNUM <= 2/) { Topic.first(2).entries }
|
|
assert_sql(/LIMIT 5|ROWNUM <= 5/) { Topic.last(5).entries }
|
|
end
|
|
|
|
def test_last_with_integer_and_order_should_keep_the_order
|
|
assert_equal Topic.order("title").to_a.last(2), Topic.order("title").last(2)
|
|
end
|
|
|
|
def test_last_with_integer_and_order_should_not_use_sql_limit
|
|
query = assert_sql { Topic.order("title").last(5).entries }
|
|
assert_equal 1, query.length
|
|
assert_no_match(/LIMIT/, query.first)
|
|
end
|
|
|
|
def test_last_with_integer_and_reorder_should_not_use_sql_limit
|
|
query = assert_sql { Topic.reorder("title").last(5).entries }
|
|
assert_equal 1, query.length
|
|
assert_no_match(/LIMIT/, query.first)
|
|
end
|
|
|
|
def test_take_and_first_and_last_with_integer_should_return_an_array
|
|
assert_kind_of Array, Topic.take(5)
|
|
assert_kind_of Array, Topic.first(5)
|
|
assert_kind_of Array, Topic.last(5)
|
|
end
|
|
|
|
def test_unexisting_record_exception_handling
|
|
assert_raise(ActiveRecord::RecordNotFound) {
|
|
Topic.find(1).parent
|
|
}
|
|
|
|
Topic.find(2).topic
|
|
end
|
|
|
|
def test_find_only_some_columns
|
|
topic = Topic.all.merge!(:select => "author_name").find(1)
|
|
assert_raise(ActiveModel::MissingAttributeError) {topic.title}
|
|
assert_raise(ActiveModel::MissingAttributeError) {topic.title?}
|
|
assert_nil topic.read_attribute("title")
|
|
assert_equal "David", topic.author_name
|
|
assert !topic.attribute_present?("title")
|
|
assert !topic.attribute_present?(:title)
|
|
assert topic.attribute_present?("author_name")
|
|
assert_respond_to topic, "author_name"
|
|
end
|
|
|
|
def test_find_on_array_conditions
|
|
assert Topic.all.merge!(:where => ["approved = ?", false]).find(1)
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => ["approved = ?", true]).find(1) }
|
|
end
|
|
|
|
def test_find_on_hash_conditions
|
|
assert Topic.all.merge!(:where => { :approved => false }).find(1)
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :approved => true }).find(1) }
|
|
end
|
|
|
|
def test_find_on_hash_conditions_with_explicit_table_name
|
|
assert Topic.all.merge!(:where => { 'topics.approved' => false }).find(1)
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { 'topics.approved' => true }).find(1) }
|
|
end
|
|
|
|
def test_find_on_hash_conditions_with_hashed_table_name
|
|
assert Topic.all.merge!(:where => {:topics => { :approved => false }}).find(1)
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => {:topics => { :approved => true }}).find(1) }
|
|
end
|
|
|
|
def test_find_with_hash_conditions_on_joined_table
|
|
firms = Firm.joins(:account).where(:accounts => { :credit_limit => 50 })
|
|
assert_equal 1, firms.size
|
|
assert_equal companies(:first_firm), firms.first
|
|
end
|
|
|
|
def test_find_with_hash_conditions_on_joined_table_and_with_range
|
|
firms = DependentFirm.all.merge!(:joins => :account, :where => {:name => 'RailsCore', :accounts => { :credit_limit => 55..60 }})
|
|
assert_equal 1, firms.size
|
|
assert_equal companies(:rails_core), firms.first
|
|
end
|
|
|
|
def test_find_on_hash_conditions_with_explicit_table_name_and_aggregate
|
|
david = customers(:david)
|
|
assert Customer.where('customers.name' => david.name, :address => david.address).find(david.id)
|
|
assert_raise(ActiveRecord::RecordNotFound) {
|
|
Customer.where('customers.name' => david.name + "1", :address => david.address).find(david.id)
|
|
}
|
|
end
|
|
|
|
def test_find_on_association_proxy_conditions
|
|
assert_equal [1, 2, 3, 5, 6, 7, 8, 9, 10, 12], Comment.where(post_id: authors(:david).posts).map(&:id).sort
|
|
end
|
|
|
|
def test_find_on_hash_conditions_with_range
|
|
assert_equal [1,2], Topic.all.merge!(:where => { :id => 1..2 }).to_a.map(&:id).sort
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :id => 2..3 }).find(1) }
|
|
end
|
|
|
|
def test_find_on_hash_conditions_with_end_exclusive_range
|
|
assert_equal [1,2,3], Topic.all.merge!(:where => { :id => 1..3 }).to_a.map(&:id).sort
|
|
assert_equal [1,2], Topic.all.merge!(:where => { :id => 1...3 }).to_a.map(&:id).sort
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :id => 2...3 }).find(3) }
|
|
end
|
|
|
|
def test_find_on_hash_conditions_with_multiple_ranges
|
|
assert_equal [1,2,3], Comment.all.merge!(:where => { :id => 1..3, :post_id => 1..2 }).to_a.map(&:id).sort
|
|
assert_equal [1], Comment.all.merge!(:where => { :id => 1..1, :post_id => 1..10 }).to_a.map(&:id).sort
|
|
end
|
|
|
|
def test_find_on_hash_conditions_with_array_of_integers_and_ranges
|
|
assert_equal [1,2,3,5,6,7,8,9], Comment.all.merge!(:where => {:id => [1..2, 3, 5, 6..8, 9]}).to_a.map(&:id).sort
|
|
end
|
|
|
|
def test_find_on_multiple_hash_conditions
|
|
assert Topic.all.merge!(:where => { :author_name => "David", :title => "The First Topic", :replies_count => 1, :approved => false }).find(1)
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :author_name => "David", :title => "The First Topic", :replies_count => 1, :approved => true }).find(1) }
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :author_name => "David", :title => "HHC", :replies_count => 1, :approved => false }).find(1) }
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :author_name => "David", :title => "The First Topic", :replies_count => 1, :approved => true }).find(1) }
|
|
end
|
|
|
|
def test_condition_interpolation
|
|
assert_kind_of Firm, Company.where("name = '%s'", "37signals").first
|
|
assert_nil Company.all.merge!(:where => ["name = '%s'", "37signals!"]).first
|
|
assert_nil Company.all.merge!(:where => ["name = '%s'", "37signals!' OR 1=1"]).first
|
|
assert_kind_of Time, Topic.all.merge!(:where => ["id = %d", 1]).first.written_on
|
|
end
|
|
|
|
def test_condition_array_interpolation
|
|
assert_kind_of Firm, Company.all.merge!(:where => ["name = '%s'", "37signals"]).first
|
|
assert_nil Company.all.merge!(:where => ["name = '%s'", "37signals!"]).first
|
|
assert_nil Company.all.merge!(:where => ["name = '%s'", "37signals!' OR 1=1"]).first
|
|
assert_kind_of Time, Topic.all.merge!(:where => ["id = %d", 1]).first.written_on
|
|
end
|
|
|
|
def test_condition_hash_interpolation
|
|
assert_kind_of Firm, Company.all.merge!(:where => { :name => "37signals"}).first
|
|
assert_nil Company.all.merge!(:where => { :name => "37signals!"}).first
|
|
assert_kind_of Time, Topic.all.merge!(:where => {:id => 1}).first.written_on
|
|
end
|
|
|
|
def test_hash_condition_find_malformed
|
|
assert_raise(ActiveRecord::StatementInvalid) {
|
|
Company.all.merge!(:where => { :id => 2, :dhh => true }).first
|
|
}
|
|
end
|
|
|
|
def test_hash_condition_find_with_escaped_characters
|
|
Company.create("name" => "Ain't noth'n like' \#stuff")
|
|
assert Company.all.merge!(:where => { :name => "Ain't noth'n like' \#stuff" }).first
|
|
end
|
|
|
|
def test_hash_condition_find_with_array
|
|
p1, p2 = Post.all.merge!(:limit => 2, :order => 'id asc').to_a
|
|
assert_equal [p1, p2], Post.all.merge!(:where => { :id => [p1, p2] }, :order => 'id asc').to_a
|
|
assert_equal [p1, p2], Post.all.merge!(:where => { :id => [p1, p2.id] }, :order => 'id asc').to_a
|
|
end
|
|
|
|
def test_hash_condition_find_with_nil
|
|
topic = Topic.all.merge!(:where => { :last_read => nil } ).first
|
|
assert_not_nil topic
|
|
assert_nil topic.last_read
|
|
end
|
|
|
|
def test_hash_condition_find_with_aggregate_having_one_mapping
|
|
balance = customers(:david).balance
|
|
assert_kind_of Money, balance
|
|
found_customer = Customer.where(:balance => balance).first
|
|
assert_equal customers(:david), found_customer
|
|
end
|
|
|
|
def test_hash_condition_find_with_aggregate_attribute_having_same_name_as_field_and_key_value_being_aggregate
|
|
gps_location = customers(:david).gps_location
|
|
assert_kind_of GpsLocation, gps_location
|
|
found_customer = Customer.where(:gps_location => gps_location).first
|
|
assert_equal customers(:david), found_customer
|
|
end
|
|
|
|
def test_hash_condition_find_with_aggregate_having_one_mapping_and_key_value_being_attribute_value
|
|
balance = customers(:david).balance
|
|
assert_kind_of Money, balance
|
|
found_customer = Customer.where(:balance => balance.amount).first
|
|
assert_equal customers(:david), found_customer
|
|
end
|
|
|
|
def test_hash_condition_find_with_aggregate_attribute_having_same_name_as_field_and_key_value_being_attribute_value
|
|
gps_location = customers(:david).gps_location
|
|
assert_kind_of GpsLocation, gps_location
|
|
found_customer = Customer.where(:gps_location => gps_location.gps_location).first
|
|
assert_equal customers(:david), found_customer
|
|
end
|
|
|
|
def test_hash_condition_find_with_aggregate_having_three_mappings
|
|
address = customers(:david).address
|
|
assert_kind_of Address, address
|
|
found_customer = Customer.where(:address => address).first
|
|
assert_equal customers(:david), found_customer
|
|
end
|
|
|
|
def test_hash_condition_find_with_one_condition_being_aggregate_and_another_not
|
|
address = customers(:david).address
|
|
assert_kind_of Address, address
|
|
found_customer = Customer.where(:address => address, :name => customers(:david).name).first
|
|
assert_equal customers(:david), found_customer
|
|
end
|
|
|
|
def test_condition_utc_time_interpolation_with_default_timezone_local
|
|
with_env_tz 'America/New_York' do
|
|
with_active_record_default_timezone :local do
|
|
topic = Topic.first
|
|
assert_equal topic, Topic.all.merge!(:where => ['written_on = ?', topic.written_on.getutc]).first
|
|
end
|
|
end
|
|
end
|
|
|
|
def test_hash_condition_utc_time_interpolation_with_default_timezone_local
|
|
with_env_tz 'America/New_York' do
|
|
with_active_record_default_timezone :local do
|
|
topic = Topic.first
|
|
assert_equal topic, Topic.all.merge!(:where => {:written_on => topic.written_on.getutc}).first
|
|
end
|
|
end
|
|
end
|
|
|
|
def test_condition_local_time_interpolation_with_default_timezone_utc
|
|
with_env_tz 'America/New_York' do
|
|
with_active_record_default_timezone :utc do
|
|
topic = Topic.first
|
|
assert_equal topic, Topic.all.merge!(:where => ['written_on = ?', topic.written_on.getlocal]).first
|
|
end
|
|
end
|
|
end
|
|
|
|
def test_hash_condition_local_time_interpolation_with_default_timezone_utc
|
|
with_env_tz 'America/New_York' do
|
|
with_active_record_default_timezone :utc do
|
|
topic = Topic.first
|
|
assert_equal topic, Topic.all.merge!(:where => {:written_on => topic.written_on.getlocal}).first
|
|
end
|
|
end
|
|
end
|
|
|
|
def test_bind_variables
|
|
assert_kind_of Firm, Company.all.merge!(:where => ["name = ?", "37signals"]).first
|
|
assert_nil Company.all.merge!(:where => ["name = ?", "37signals!"]).first
|
|
assert_nil Company.all.merge!(:where => ["name = ?", "37signals!' OR 1=1"]).first
|
|
assert_kind_of Time, Topic.all.merge!(:where => ["id = ?", 1]).first.written_on
|
|
assert_raise(ActiveRecord::PreparedStatementInvalid) {
|
|
Company.all.merge!(:where => ["id=? AND name = ?", 2]).first
|
|
}
|
|
assert_raise(ActiveRecord::PreparedStatementInvalid) {
|
|
Company.all.merge!(:where => ["id=?", 2, 3, 4]).first
|
|
}
|
|
end
|
|
|
|
def test_bind_variables_with_quotes
|
|
Company.create("name" => "37signals' go'es agains")
|
|
assert Company.all.merge!(:where => ["name = ?", "37signals' go'es agains"]).first
|
|
end
|
|
|
|
def test_named_bind_variables_with_quotes
|
|
Company.create("name" => "37signals' go'es agains")
|
|
assert Company.all.merge!(:where => ["name = :name", {:name => "37signals' go'es agains"}]).first
|
|
end
|
|
|
|
def test_bind_arity
|
|
assert_nothing_raised { bind '' }
|
|
assert_raise(ActiveRecord::PreparedStatementInvalid) { bind '', 1 }
|
|
|
|
assert_raise(ActiveRecord::PreparedStatementInvalid) { bind '?' }
|
|
assert_nothing_raised { bind '?', 1 }
|
|
assert_raise(ActiveRecord::PreparedStatementInvalid) { bind '?', 1, 1 }
|
|
end
|
|
|
|
def test_named_bind_variables
|
|
assert_equal '1', bind(':a', :a => 1) # ' ruby-mode
|
|
assert_equal '1 1', bind(':a :a', :a => 1) # ' ruby-mode
|
|
|
|
assert_nothing_raised { bind("'+00:00'", :foo => "bar") }
|
|
|
|
assert_kind_of Firm, Company.all.merge!(:where => ["name = :name", { :name => "37signals" }]).first
|
|
assert_nil Company.all.merge!(:where => ["name = :name", { :name => "37signals!" }]).first
|
|
assert_nil Company.all.merge!(:where => ["name = :name", { :name => "37signals!' OR 1=1" }]).first
|
|
assert_kind_of Time, Topic.all.merge!(:where => ["id = :id", { :id => 1 }]).first.written_on
|
|
end
|
|
|
|
class SimpleEnumerable
|
|
include Enumerable
|
|
|
|
def initialize(ary)
|
|
@ary = ary
|
|
end
|
|
|
|
def each(&b)
|
|
@ary.each(&b)
|
|
end
|
|
end
|
|
|
|
def test_bind_enumerable
|
|
quoted_abc = %(#{ActiveRecord::Base.connection.quote('a')},#{ActiveRecord::Base.connection.quote('b')},#{ActiveRecord::Base.connection.quote('c')})
|
|
|
|
assert_equal '1,2,3', bind('?', [1, 2, 3])
|
|
assert_equal quoted_abc, bind('?', %w(a b c))
|
|
|
|
assert_equal '1,2,3', bind(':a', :a => [1, 2, 3])
|
|
assert_equal quoted_abc, bind(':a', :a => %w(a b c)) # '
|
|
|
|
assert_equal '1,2,3', bind('?', SimpleEnumerable.new([1, 2, 3]))
|
|
assert_equal quoted_abc, bind('?', SimpleEnumerable.new(%w(a b c)))
|
|
|
|
assert_equal '1,2,3', bind(':a', :a => SimpleEnumerable.new([1, 2, 3]))
|
|
assert_equal quoted_abc, bind(':a', :a => SimpleEnumerable.new(%w(a b c))) # '
|
|
end
|
|
|
|
def test_bind_empty_enumerable
|
|
quoted_nil = ActiveRecord::Base.connection.quote(nil)
|
|
assert_equal quoted_nil, bind('?', [])
|
|
assert_equal " in (#{quoted_nil})", bind(' in (?)', [])
|
|
assert_equal "foo in (#{quoted_nil})", bind('foo in (?)', [])
|
|
end
|
|
|
|
def test_bind_empty_string
|
|
quoted_empty = ActiveRecord::Base.connection.quote('')
|
|
assert_equal quoted_empty, bind('?', '')
|
|
end
|
|
|
|
def test_bind_chars
|
|
quoted_bambi = ActiveRecord::Base.connection.quote("Bambi")
|
|
quoted_bambi_and_thumper = ActiveRecord::Base.connection.quote("Bambi\nand\nThumper")
|
|
assert_equal "name=#{quoted_bambi}", bind('name=?', "Bambi")
|
|
assert_equal "name=#{quoted_bambi_and_thumper}", bind('name=?', "Bambi\nand\nThumper")
|
|
assert_equal "name=#{quoted_bambi}", bind('name=?', "Bambi".mb_chars)
|
|
assert_equal "name=#{quoted_bambi_and_thumper}", bind('name=?', "Bambi\nand\nThumper".mb_chars)
|
|
end
|
|
|
|
def test_bind_record
|
|
o = Struct.new(:quoted_id).new(1)
|
|
assert_equal '1', bind('?', o)
|
|
|
|
os = [o] * 3
|
|
assert_equal '1,1,1', bind('?', os)
|
|
end
|
|
|
|
def test_named_bind_with_postgresql_type_casts
|
|
l = Proc.new { bind(":a::integer '2009-01-01'::date", :a => '10') }
|
|
assert_nothing_raised(&l)
|
|
assert_equal "#{ActiveRecord::Base.quote_value('10')}::integer '2009-01-01'::date", l.call
|
|
end
|
|
|
|
def test_string_sanitation
|
|
assert_not_equal "'something ' 1=1'", ActiveRecord::Base.sanitize("something ' 1=1")
|
|
assert_equal "'something; select table'", ActiveRecord::Base.sanitize("something; select table")
|
|
end
|
|
|
|
def test_count_by_sql
|
|
assert_equal(0, Entrant.count_by_sql("SELECT COUNT(*) FROM entrants WHERE id > 3"))
|
|
assert_equal(1, Entrant.count_by_sql(["SELECT COUNT(*) FROM entrants WHERE id > ?", 2]))
|
|
assert_equal(2, Entrant.count_by_sql(["SELECT COUNT(*) FROM entrants WHERE id > ?", 1]))
|
|
end
|
|
|
|
def test_find_by_one_attribute
|
|
assert_equal topics(:first), Topic.find_by_title("The First Topic")
|
|
assert_nil Topic.find_by_title("The First Topic!")
|
|
end
|
|
|
|
def test_find_by_one_attribute_bang
|
|
assert_equal topics(:first), Topic.find_by_title!("The First Topic")
|
|
assert_raise(ActiveRecord::RecordNotFound) { Topic.find_by_title!("The First Topic!") }
|
|
end
|
|
|
|
def test_find_by_one_attribute_that_is_an_alias
|
|
assert_equal topics(:first), Topic.find_by_heading("The First Topic")
|
|
assert_nil Topic.find_by_heading("The First Topic!")
|
|
end
|
|
|
|
def test_find_by_one_attribute_with_conditions
|
|
assert_equal accounts(:rails_core_account), Account.where('firm_id = ?', 6).find_by_credit_limit(50)
|
|
end
|
|
|
|
def test_find_by_one_attribute_that_is_an_aggregate
|
|
address = customers(:david).address
|
|
assert_kind_of Address, address
|
|
found_customer = Customer.find_by_address(address)
|
|
assert_equal customers(:david), found_customer
|
|
end
|
|
|
|
def test_find_by_one_attribute_that_is_an_aggregate_with_one_attribute_difference
|
|
address = customers(:david).address
|
|
assert_kind_of Address, address
|
|
missing_address = Address.new(address.street, address.city, address.country + "1")
|
|
assert_nil Customer.find_by_address(missing_address)
|
|
missing_address = Address.new(address.street, address.city + "1", address.country)
|
|
assert_nil Customer.find_by_address(missing_address)
|
|
missing_address = Address.new(address.street + "1", address.city, address.country)
|
|
assert_nil Customer.find_by_address(missing_address)
|
|
end
|
|
|
|
def test_find_by_two_attributes_that_are_both_aggregates
|
|
balance = customers(:david).balance
|
|
address = customers(:david).address
|
|
assert_kind_of Money, balance
|
|
assert_kind_of Address, address
|
|
found_customer = Customer.find_by_balance_and_address(balance, address)
|
|
assert_equal customers(:david), found_customer
|
|
end
|
|
|
|
def test_find_by_two_attributes_with_one_being_an_aggregate
|
|
balance = customers(:david).balance
|
|
assert_kind_of Money, balance
|
|
found_customer = Customer.find_by_balance_and_name(balance, customers(:david).name)
|
|
assert_equal customers(:david), found_customer
|
|
end
|
|
|
|
def test_dynamic_finder_on_one_attribute_with_conditions_returns_same_results_after_caching
|
|
# ensure this test can run independently of order
|
|
class << Account; self; end.send(:remove_method, :find_by_credit_limit) if Account.public_methods.include?(:find_by_credit_limit)
|
|
a = Account.where('firm_id = ?', 6).find_by_credit_limit(50)
|
|
assert_equal a, Account.where('firm_id = ?', 6).find_by_credit_limit(50) # find_by_credit_limit has been cached
|
|
end
|
|
|
|
def test_find_by_one_attribute_with_several_options
|
|
assert_equal accounts(:unknown), Account.order('id DESC').where('id != ?', 3).find_by_credit_limit(50)
|
|
end
|
|
|
|
def test_find_by_one_missing_attribute
|
|
assert_raise(NoMethodError) { Topic.find_by_undertitle("The First Topic!") }
|
|
end
|
|
|
|
def test_find_by_invalid_method_syntax
|
|
assert_raise(NoMethodError) { Topic.fail_to_find_by_title("The First Topic") }
|
|
assert_raise(NoMethodError) { Topic.find_by_title?("The First Topic") }
|
|
assert_raise(NoMethodError) { Topic.fail_to_find_or_create_by_title("Nonexistent Title") }
|
|
assert_raise(NoMethodError) { Topic.find_or_create_by_title?("Nonexistent Title") }
|
|
end
|
|
|
|
def test_find_by_two_attributes
|
|
assert_equal topics(:first), Topic.find_by_title_and_author_name("The First Topic", "David")
|
|
assert_nil Topic.find_by_title_and_author_name("The First Topic", "Mary")
|
|
end
|
|
|
|
def test_find_by_two_attributes_but_passing_only_one
|
|
assert_raise(ArgumentError) { Topic.find_by_title_and_author_name("The First Topic") }
|
|
end
|
|
|
|
def test_find_by_nil_attribute
|
|
topic = Topic.find_by_last_read nil
|
|
assert_not_nil topic
|
|
assert_nil topic.last_read
|
|
end
|
|
|
|
def test_find_by_nil_and_not_nil_attributes
|
|
topic = Topic.find_by_last_read_and_author_name nil, "Mary"
|
|
assert_equal "Mary", topic.author_name
|
|
end
|
|
|
|
def test_find_with_bad_sql
|
|
assert_raise(ActiveRecord::StatementInvalid) { Topic.find_by_sql "select 1 from badtable" }
|
|
end
|
|
|
|
def test_find_all_with_join
|
|
developers_on_project_one = Developer.all.merge!(
|
|
:joins => 'LEFT JOIN developers_projects ON developers.id = developers_projects.developer_id',
|
|
:where => 'project_id=1'
|
|
).to_a
|
|
assert_equal 3, developers_on_project_one.length
|
|
developer_names = developers_on_project_one.map { |d| d.name }
|
|
assert developer_names.include?('David')
|
|
assert developer_names.include?('Jamis')
|
|
end
|
|
|
|
def test_joins_dont_clobber_id
|
|
first = Firm.all.merge!(
|
|
:joins => 'INNER JOIN companies clients ON clients.firm_id = companies.id',
|
|
:where => 'companies.id = 1'
|
|
).first
|
|
assert_equal 1, first.id
|
|
end
|
|
|
|
def test_joins_with_string_array
|
|
person_with_reader_and_post = Post.all.merge!(
|
|
:joins => [
|
|
"INNER JOIN categorizations ON categorizations.post_id = posts.id",
|
|
"INNER JOIN categories ON categories.id = categorizations.category_id AND categories.type = 'SpecialCategory'"
|
|
]
|
|
)
|
|
assert_equal 1, person_with_reader_and_post.size
|
|
end
|
|
|
|
def test_find_by_id_with_conditions_with_or
|
|
assert_nothing_raised do
|
|
Post.where("posts.id <= 3 OR posts.#{QUOTED_TYPE} = 'Post'").find([1,2,3])
|
|
end
|
|
end
|
|
|
|
# http://dev.rubyonrails.org/ticket/6778
|
|
def test_find_ignores_previously_inserted_record
|
|
Post.create!(:title => 'test', :body => 'it out')
|
|
assert_equal [], Post.where(id: nil)
|
|
end
|
|
|
|
def test_find_by_empty_ids
|
|
assert_equal [], Post.find([])
|
|
end
|
|
|
|
def test_find_by_empty_in_condition
|
|
assert_equal [], Post.where('id in (?)', [])
|
|
end
|
|
|
|
def test_find_by_records
|
|
p1, p2 = Post.all.merge!(:limit => 2, :order => 'id asc').to_a
|
|
assert_equal [p1, p2], Post.all.merge!(:where => ['id in (?)', [p1, p2]], :order => 'id asc')
|
|
assert_equal [p1, p2], Post.all.merge!(:where => ['id in (?)', [p1, p2.id]], :order => 'id asc')
|
|
end
|
|
|
|
def test_select_value
|
|
assert_equal "37signals", Company.connection.select_value("SELECT name FROM companies WHERE id = 1")
|
|
assert_nil Company.connection.select_value("SELECT name FROM companies WHERE id = -1")
|
|
# make sure we didn't break count...
|
|
assert_equal 0, Company.count_by_sql("SELECT COUNT(*) FROM companies WHERE name = 'Halliburton'")
|
|
assert_equal 1, Company.count_by_sql("SELECT COUNT(*) FROM companies WHERE name = '37signals'")
|
|
end
|
|
|
|
def test_select_values
|
|
assert_equal ["1","2","3","4","5","6","7","8","9", "10"], Company.connection.select_values("SELECT id FROM companies ORDER BY id").map! { |i| i.to_s }
|
|
assert_equal ["37signals","Summit","Microsoft", "Flamboyant Software", "Ex Nihilo", "RailsCore", "Leetsoft", "Jadedpixel", "Odegy", "Ex Nihilo Part Deux"], Company.connection.select_values("SELECT name FROM companies ORDER BY id")
|
|
end
|
|
|
|
def test_select_rows
|
|
assert_equal(
|
|
[["1", "1", nil, "37signals"],
|
|
["2", "1", "2", "Summit"],
|
|
["3", "1", "1", "Microsoft"]],
|
|
Company.connection.select_rows("SELECT id, firm_id, client_of, name FROM companies WHERE id IN (1,2,3) ORDER BY id").map! {|i| i.map! {|j| j.to_s unless j.nil?}})
|
|
assert_equal [["1", "37signals"], ["2", "Summit"], ["3", "Microsoft"]],
|
|
Company.connection.select_rows("SELECT id, name FROM companies WHERE id IN (1,2,3) ORDER BY id").map! {|i| i.map! {|j| j.to_s unless j.nil?}}
|
|
end
|
|
|
|
def test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct
|
|
assert_equal 2, Post.all.merge!(:includes => { :authors => :author_address }, :order => 'author_addresses.id DESC ', :limit => 2).to_a.size
|
|
|
|
assert_equal 3, Post.all.merge!(:includes => { :author => :author_address, :authors => :author_address},
|
|
:order => 'author_addresses_authors.id DESC ', :limit => 3).to_a.size
|
|
end
|
|
|
|
def test_find_with_nil_inside_set_passed_for_one_attribute
|
|
client_of = Company.all.merge!(
|
|
:where => {
|
|
:client_of => [2, 1, nil],
|
|
:name => ['37signals', 'Summit', 'Microsoft'] },
|
|
:order => 'client_of DESC'
|
|
).map { |x| x.client_of }
|
|
|
|
assert client_of.include?(nil)
|
|
assert_equal [2, 1].sort, client_of.compact.sort
|
|
end
|
|
|
|
def test_find_with_nil_inside_set_passed_for_attribute
|
|
client_of = Company.all.merge!(
|
|
:where => { :client_of => [nil] },
|
|
:order => 'client_of DESC'
|
|
).map { |x| x.client_of }
|
|
|
|
assert_equal [], client_of.compact
|
|
end
|
|
|
|
def test_with_limiting_with_custom_select
|
|
posts = Post.references(:authors).merge(
|
|
:includes => :author, :select => ' posts.*, authors.id as "author_id"',
|
|
:limit => 3, :order => 'posts.id'
|
|
).to_a
|
|
assert_equal 3, posts.size
|
|
assert_equal [0, 1, 1], posts.map(&:author_id).sort
|
|
end
|
|
|
|
def test_find_one_message_with_custom_primary_key
|
|
Toy.primary_key = :name
|
|
begin
|
|
Toy.find 'Hello World!'
|
|
rescue ActiveRecord::RecordNotFound => e
|
|
assert_equal 'Couldn\'t find Toy with name=Hello World!', e.message
|
|
end
|
|
end
|
|
|
|
def test_finder_with_offset_string
|
|
assert_nothing_raised(ActiveRecord::StatementInvalid) { Topic.all.merge!(:offset => "3").to_a }
|
|
end
|
|
|
|
protected
|
|
def bind(statement, *vars)
|
|
if vars.first.is_a?(Hash)
|
|
ActiveRecord::Base.send(:replace_named_bind_variables, statement, vars.first)
|
|
else
|
|
ActiveRecord::Base.send(:replace_bind_variables, statement, vars)
|
|
end
|
|
end
|
|
|
|
def with_env_tz(new_tz = 'US/Eastern')
|
|
old_tz, ENV['TZ'] = ENV['TZ'], new_tz
|
|
yield
|
|
ensure
|
|
old_tz ? ENV['TZ'] = old_tz : ENV.delete('TZ')
|
|
end
|
|
|
|
def with_active_record_default_timezone(zone)
|
|
old_zone, ActiveRecord::Base.default_timezone = ActiveRecord::Base.default_timezone, zone
|
|
yield
|
|
ensure
|
|
ActiveRecord::Base.default_timezone = old_zone
|
|
end
|
|
end
|