rails--rails

kotovalexarian-likes-github/rails--rails

mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

History

Yves Senn 7d196cf360 `#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399 . The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key) states that it returns `nil` if there are no key attributes. `to_param` needs to be aware of that fact and return `nil` as well. Previously it raised the following exception: ``` 1) Error: ConversionTest#test_to_param_returns_nil_if_to_key_is_nil: NoMethodError: undefined method `join' for nil:NilClass /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param' /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>' ```	2014-02-04 10:27:46 +01:00
..
active_model	`#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399 .	2014-02-04 10:27:46 +01:00
active_model.rb	Fix eager load of Serializers on Active Model	2014-01-17 15:30:09 -02:00

Yves Senn 7d196cf360 #to_param returns nil if to_key returns nil. Closes #11399 .

The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key)
states that it returns `nil` if there are no key attributes. `to_param` needs
to be aware of that fact and return `nil` as well.

Previously it raised the following exception:

```
  1) Error:
ConversionTest#test_to_param_returns_nil_if_to_key_is_nil:
NoMethodError: undefined method `join' for nil:NilClass
    /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param'
    /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>'
```

2014-02-04 10:27:46 +01:00

active_model #to_param returns nil if to_key returns nil. Closes #11399 . 2014-02-04 10:27:46 +01:00

active_model.rb Fix eager load of Serializers on Active Model 2014-01-17 15:30:09 -02:00