1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionpack/lib/action_dispatch/middleware
eileencodes 75a121a2c5 Fix bug where cookies mutated by request were not persisted
With changes made in 8363b8 and ae29142 cookies that are mutated on the
request like `cookies.signed = x` were not retained in subsequent tests,
breaking cookie authentiation in controller tests.

The test added demonstrates the issue.

The reason we need to select from non-deleted cookies is because without
checking the `@delete_cookies` the `cookie_jar` `@cookies` will send the
wrong cookies to be updated. The code must check for `@deleted_cookies`
before sending an `#update` with the requests cookie_jar cookies.
This follows how the cookie_jar cookies from the request were updated
before these changes.
2015-09-01 08:42:30 -04:00
..
session use a request object in the session middleware 2015-08-22 17:57:45 -07:00
templates Change filter on /rails/info/routes to use an actual path regexp from rails 2015-02-23 19:57:01 +03:00
callbacks.rb [ci skip] Fix comment of ActionDispatch::Callbacks 2014-11-23 13:22:36 +09:00
cookies.rb Fix bug where cookies mutated by request were not persisted 2015-09-01 08:42:30 -04:00
debug_exceptions.rb remove env access from debug_exceptions 2015-08-23 17:18:02 -07:00
exception_wrapper.rb ExceptionWrapper doesn't need to know about env 2015-08-06 15:59:44 -07:00
flash.rb remove usage of @env 2015-08-23 16:16:28 -07:00
load_interlock.rb Fix the Interlock middleware 2015-07-09 03:31:31 +09:30
params_parser.rb stop using @env in the GET / POST methods 2015-08-24 14:57:05 -07:00
public_exceptions.rb use Request#path_info instead of direct ENV access 2015-08-23 17:22:21 -07:00
reloader.rb Use ruby 1.9 lambda syntax in documentations [ci skip] 2015-05-03 02:50:31 +03:00
remote_ip.rb use a request object to access info from env in GetIp 2015-08-06 16:20:47 -07:00
request_id.rb add a branch to eliminate multiple nil checks 2015-05-23 11:38:23 -07:00
show_exceptions.rb use methods on the request object instead of accessing env 2015-08-23 17:25:13 -07:00
ssl.rb ActionDispatch::SSL should keep original header's behavior 2015-06-14 23:20:04 +09:00
stack.rb Make assert_index private 2015-08-25 17:58:51 +02:00
static.rb reuse the request object in the File serving middleware 2015-08-06 15:18:35 -07:00