1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/activejob/lib/active_job
Kasper Timm Hansen d258bfe8ac
Consolidate and give context to after callback deprecation
The existing message only mentioned one type of before/after callback,
but the config was named generally. That mismatch is confusing and users
wouldn't necessarily know what the total effect of the config would be.

So instead of handwriting the deprecation warning in the specific instances,
consolidate it in one place and give the appropriate context. That context
is the above, but also that users shouldn't update their app config,
they should uncomment the line in the new defaults file, which now also
has more context.

I'm not totally convinced that we can't move this to when
`after_enqueue`/`after_perform` is called in the job class. Doesn't
seem worth it to blare this after every job enqueue/perform, when we
the score at boot time.

cc @Edouard-chin
2019-12-15 03:20:07 +01:00
..
queue_adapters Run inline jobs in separate threads 2019-11-01 20:14:40 -04:00
serializers Serialize classes and modules with ActiveJob 2019-09-09 16:45:12 -04:00
arguments.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
base.rb Extract ActiveJob::Instrumentation 2019-09-23 12:29:52 -04:00
callbacks.rb Consolidate and give context to after callback deprecation 2019-12-15 03:20:07 +01:00
configured_job.rb [Active Job] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
core.rb Use try only when we're unsure if the receiver would respond_to the method 2019-08-01 17:58:00 +09:00
enqueuing.rb Consolidate and give context to after callback deprecation 2019-12-15 03:20:07 +01:00
exceptions.rb Set default directly with default: 2019-12-13 02:09:08 +01:00
execution.rb Consolidate and give context to after callback deprecation 2019-12-15 03:20:07 +01:00
gem_version.rb Start Rails 6.1 development 2019-04-24 15:57:14 -04:00
instrumentation.rb Fix ActiveJob logging when callback chain is halted: 2019-12-09 16:17:55 +01:00
log_subscriber.rb Fix ActiveJob logging when callback chain is halted: 2019-12-09 16:17:55 +01:00
logging.rb Add an option to disable logging for jobs with sensitive arguments 2019-11-08 13:53:23 -05:00
queue_adapter.rb Remove errant default option 2019-09-24 14:08:09 -04:00
queue_adapters.rb Fix links in gemspec and docs from http to https. 2019-03-09 19:42:35 +05:30
queue_name.rb Stop queue_name_prefix from being global 2019-09-13 18:30:19 -03:00
queue_priority.rb [Active Job] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
railtie.rb Include test helpers when ActionDispatch::IntegrationTest is loaded 2018-09-12 16:58:14 -05:00
serializers.rb Serialize classes and modules with ActiveJob 2019-09-09 16:45:12 -04:00
test_case.rb [Active Job] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
test_helper.rb Implicitly assert no exception is raised in block assertions 2019-10-07 11:01:24 +02:00
timezones.rb Remove passing extra arguments to ActiveJob Callbacks 2018-02-23 00:58:00 +02:00
translation.rb Remove passing extra arguments to ActiveJob Callbacks 2018-02-23 00:58:00 +02:00
version.rb [Active Job] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00