1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/activerecord/test/cases
Vladimir Kochnev 41b92914f8 Abandon TOP support.
Initially, `TOP` was introduced to support `limit` for MSSQL database.
Unlike PostgreSQL/MySQL/SQLite, MSSQL does not have native `LIMIT`/`OFFSET` support.
The commit adding `TOP` is 1a246f7161.

However, it figured out that `TOP` implementation was weak and it's not sufficient
to also support `OFFSET`, then `TOP` was substituted with
`ROW_NUMBER()` subquery in be48ed3071.
This is a well known trick in MSSQL -
https://stackoverflow.com/questions/2135418/equivalent-of-limit-and-offset-for-sql-server.

So now we don't need this `visit_Arel_Nodes_Top` at all.
It does nothing useful but also adds an extra space after `SELECT` when `LIMIT` is being
used for **any** database.
2018-09-25 15:39:14 +04:00
..
adapters Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
arel Abandon TOP support. 2018-09-25 15:39:14 +04:00
associations Don't update counter cache unless the record is actually saved 2018-09-19 05:29:21 +09:00
attribute_methods Add AR::Base.base_class? predicate 2018-04-02 14:34:32 +03:00
coders
connection_adapters Refactors Active Record connection management 2018-08-30 10:06:45 -04:00
connection_specification Refactors Active Record connection management 2018-08-30 10:06:45 -04:00
fixture_set
migration SQLite3: Fix rename reference column not to lose foreign key constraint 2018-08-20 02:27:14 +09:00
relation Use table name qualified column name for update counters 2018-09-16 08:57:09 +09:00
scoping Don't expose current_scope for internal use 2018-09-11 21:41:11 +09:00
tasks Ignore psqlrc files when executing psql commands 2018-09-17 12:13:42 -03:00
type Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
validations Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
adapter_test.rb Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
aggregations_test.rb Handle FrozenError if it is available 2017-12-20 11:52:01 +00:00
ar_schema_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
associations_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
attribute_decorators_test.rb
attribute_methods_test.rb Call initialize after allocate 2018-06-26 09:29:53 -07:00
attributes_test.rb Make a deep copy of the _default_attributes in column_defaults 2018-09-20 00:03:15 -04:00
autosave_association_test.rb Merge pull request #33378 from numbata/subclass-redefine-autosave-callbacks 2018-09-13 15:50:38 -04:00
base_test.rb add mysql and sqlite3 default test 2018-09-01 22:09:01 -04:00
batches_test.rb Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
binary_test.rb Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
bind_parameter_test.rb Fallback to unprepared statement only when bind params limit is exceeded 2018-09-14 07:00:45 +09:00
boolean_test.rb Ensure casting by boolean attribute when querying 2018-05-29 05:22:31 +09:00
cache_key_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
calculations_test.rb Avoid creating temporary arrays in ActiveRecord::Result#cast_values in order to speed up pluck 2018-06-19 11:11:46 +10:00
callbacks_test.rb Merge pull request #30919 from seanlinsley/17622-before_save_strict_arguments 2018-07-23 04:19:37 +09:00
clone_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
collection_cache_key_test.rb Avoid passing unnecessary arguments to relation 2018-01-24 16:49:35 -05:00
column_alias_test.rb
column_definition_test.rb
comment_test.rb
connection_management_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
connection_pool_test.rb Merge pull request #31696 from BrentWheeldon/bmw-connection-pool-load-deadlock 2018-08-24 01:42:22 +09:30
core_test.rb Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
counter_cache_test.rb Fix touch option to behave consistently with Persistence#touch method 2018-06-18 19:08:41 +09:00
custom_locking_test.rb
database_statements_test.rb
date_test.rb
date_time_precision_test.rb Apply time column precision on assignment 2018-03-11 18:19:20 +00:00
date_time_test.rb
defaults_test.rb Subsecond precision is not supported until MySQL 5.6.4 2018-07-09 04:27:35 +09:00
dirty_test.rb Remove redundant travel_back 2018-08-31 16:19:58 +09:00
disconnected_test.rb
dup_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
enum_test.rb Remove extra whitespace 2018-01-25 23:32:59 -05:00
errors_test.rb
explain_subscriber_test.rb Permit list usage cleanup and clearer documentation 2018-08-27 09:51:46 -04:00
explain_test.rb Remove usage of strip_heredoc in the framework in favor of <<~ 2018-02-16 19:28:30 -05:00
filter_attributes_test.rb DRY activerecord/lib/active_record/core.rb and fix tests 2018-09-12 18:51:55 +03:00
finder_respond_to_test.rb Use respond_to test helpers 2018-01-25 23:32:58 -05:00
finder_test.rb Don't return the same object when using find with an empty array 2018-09-19 14:32:18 -04:00
fixtures_test.rb Merge pull request #33391 from utilum/method_call_assertions_instead_of_mocha 2018-07-19 19:21:30 +09:00
forbidden_attributes_protection_test.rb
habtm_destroy_order_test.rb Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00
helper.rb Add method_call_assertions and use them instead of Mocha 2018-08-13 13:05:14 +02:00
hot_compatibility_test.rb
i18n_test.rb
inheritance_test.rb Enable Layout/EmptyLinesAroundBlockBody to reduce review cost in the future 2018-07-12 21:29:48 +09:00
instrumentation_test.rb
integration_test.rb
invalid_connection_test.rb
invertible_migration_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
json_attribute_test.rb Use :string instead of :text for JsonAttributeTest 2017-12-06 08:42:51 +09:00
json_serialization_test.rb Use respond_to test helpers 2018-01-25 23:32:58 -05:00
json_shared_test_cases.rb Deprecate update_attributes and update_attributes! 2018-02-17 13:58:54 -08:00
legacy_configurations_test.rb Refactors Active Record connection management 2018-08-30 10:06:45 -04:00
locking_test.rb Fix touch option to behave consistently with Persistence#touch method 2018-06-18 19:08:41 +09:00
log_subscriber_test.rb Omit BEGIN/COMMIT statements for empty transactions 2018-08-13 16:51:54 +01:00
migration_test.rb Remove meaningless ActiveRecord::MigrationContext.new(old_path) in ensure block 2018-09-17 19:53:02 +09:00
migrator_test.rb Remove meaningless ActiveRecord::MigrationContext.new(old_path) in ensure block 2018-09-17 19:53:02 +09:00
mixin_test.rb
modules_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
multiparameter_attributes_test.rb Autocorrect refute RuboCop violations 2018-04-03 22:35:49 -04:00
multiple_db_test.rb
nested_attributes_test.rb Fixes #33610 2018-09-11 00:13:09 -07:00
nested_attributes_with_callbacks_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
null_relation_test.rb
numeric_data_test.rb Fix occurrences Fixnum|Bignum 2018-03-04 20:44:30 +02:00
persistence_test.rb Persistence#increment! requires an attribute argument which is incremented 2018-09-24 03:03:04 +09:00
pooled_connections_test.rb
primary_keys_test.rb SQLite: Don't leak internal schema objects 2018-07-09 11:23:37 +09:00
query_cache_test.rb No private def in the codebase 2018-09-21 16:19:42 -04:00
quoting_test.rb Normalize time value not to be affected by summer time 2018-07-25 09:46:39 +09:00
readonly_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
reaper_test.rb Improve tests for ActiveRecord::ConnectionAdapters::ConnectionPool configurations. 2018-08-19 23:07:04 +08:00
reflection_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
relation_test.rb Remove Rubocop's comments from Rails code base 2018-07-26 23:37:31 +03:00
relations_test.rb Extract {update,delete}_all_test.rb from persistence_test.rb and relations_test.rb 2018-09-16 08:41:08 +09:00
reload_models_test.rb
reserved_word_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
result_test.rb Deprecate ActiveRecord::Result#to_hash in favor of #to_a 2018-09-18 16:40:10 -04:00
sanitize_test.rb Deprecate expand_hash_conditions_for_aggregates 2018-01-29 21:35:30 +09:00
schema_dumper_test.rb SQLite3 adapter supports expression indexes 2018-09-13 16:11:09 -04:00
schema_loading_test.rb
secure_token_test.rb
serialization_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
serialized_attribute_test.rb Address intermittent CI failure due to non-determined sort order 2018-08-19 12:22:46 +09:00
statement_cache_test.rb Autocorrect refute RuboCop violations 2018-04-03 22:35:49 -04:00
store_test.rb Update prefix and allow suffix options for store accessors 2018-06-12 07:10:09 -07:00
suppressor_test.rb
test_case.rb Omit BEGIN/COMMIT statements for empty transactions 2018-08-13 16:51:54 +01:00
test_fixtures_test.rb
time_precision_test.rb Apply time column precision on assignment 2018-03-11 18:19:20 +00:00
timestamp_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
touch_later_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
transaction_callbacks_test.rb Fix save in after_create_commit won't invoke extra after_create_commit 2018-06-04 08:22:55 +09:00
transaction_isolation_test.rb Fix typo s/Topic/Tag/ 2018-08-23 21:24:35 +09:00
transactions_test.rb Omit BEGIN/COMMIT statements for empty transactions 2018-08-13 16:51:54 +01:00
type_test.rb
types_test.rb
unconnected_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
unsafe_raw_sql_test.rb whitelist NULLS { FIRST | LAST } in order clauses 2018-03-06 02:27:16 +01:00
validations_repair_helper.rb
validations_test.rb Fix numericality validator not to be affected by custom getter 2018-08-13 23:28:46 +09:00
view_test.rb
yaml_serialization_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00