mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
bf33510d86
The bulk of the optimization is to generate code rather than use
`define_method` with a closure.
```
Warming up --------------------------------------
original 207.468k i/100ms
code-generator 340.849k i/100ms
Calculating -------------------------------------
original 2.127M (± 1.1%) i/s - 10.788M in 5.073860s
code-generator 3.426M (± 0.9%) i/s - 17.383M in 5.073965s
Comparison:
code-generator: 3426241.0 i/s
original: 2126539.2 i/s - 1.61x (± 0.00) slower
```
```ruby
require 'benchmark/ips'
require 'active_support/all'
class Original < ActiveSupport::CurrentAttributes
attribute :foo
end
class CodeGen < ActiveSupport::CurrentAttributes
class << self
def attribute(*names)
ActiveSupport::CodeGenerator.batch(generated_attribute_methods, __FILE__, __LINE__) do |owner|
names.each do |name|
owner.define_cached_method(name, namespace: :current_attributes) do |batch|
batch <<
"def #{name}" <<
"attributes[:#{name}]" <<
"end"
end
owner.define_cached_method("#{name}=", namespace: :current_attributes) do |batch|
batch <<
"def #{name}=(value)" <<
"attributes[:#{name}] = value" <<
"end"
end
end
end
ActiveSupport::CodeGenerator.batch(singleton_class, __FILE__, __LINE__) do |owner|
names.each do |name|
owner.define_cached_method(name, namespace: :current_attributes_delegation) do |batch|
batch <<
"def #{name}" <<
"instance.#{name}" <<
"end"
end
owner.define_cached_method("#{name}=", namespace: :current_attributes_delegation) do |batch|
batch <<
"def #{name}=(value)" <<
"instance.#{name} = value" <<
"end"
end
end
end
end
end
attribute :foo
end
Benchmark.ips do |x|
x.report('original') { Original.foo }
x.report('code-generator') { CodeGen.foo }
x.compare!
end
```
539 lines
19 KiB
Ruby
539 lines
19 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "concurrent/map"
|
|
|
|
module ActiveModel
|
|
# Raised when an attribute is not defined.
|
|
#
|
|
# class User < ActiveRecord::Base
|
|
# has_many :pets
|
|
# end
|
|
#
|
|
# user = User.first
|
|
# user.pets.select(:id).first.user_id
|
|
# # => ActiveModel::MissingAttributeError: missing attribute: user_id
|
|
class MissingAttributeError < NoMethodError
|
|
end
|
|
|
|
# == Active \Model \Attribute \Methods
|
|
#
|
|
# Provides a way to add prefixes and suffixes to your methods as
|
|
# well as handling the creation of <tt>ActiveRecord::Base</tt>-like
|
|
# class methods such as +table_name+.
|
|
#
|
|
# The requirements to implement <tt>ActiveModel::AttributeMethods</tt> are to:
|
|
#
|
|
# * <tt>include ActiveModel::AttributeMethods</tt> in your class.
|
|
# * Call each of its methods you want to add, such as +attribute_method_suffix+
|
|
# or +attribute_method_prefix+.
|
|
# * Call +define_attribute_methods+ after the other methods are called.
|
|
# * Define the various generic +_attribute+ methods that you have declared.
|
|
# * Define an +attributes+ method which returns a hash with each
|
|
# attribute name in your model as hash key and the attribute value as hash value.
|
|
# Hash keys must be strings.
|
|
#
|
|
# A minimal implementation could be:
|
|
#
|
|
# class Person
|
|
# include ActiveModel::AttributeMethods
|
|
#
|
|
# attribute_method_affix prefix: 'reset_', suffix: '_to_default!'
|
|
# attribute_method_suffix '_contrived?'
|
|
# attribute_method_prefix 'clear_'
|
|
# define_attribute_methods :name
|
|
#
|
|
# attr_accessor :name
|
|
#
|
|
# def attributes
|
|
# { 'name' => @name }
|
|
# end
|
|
#
|
|
# private
|
|
#
|
|
# def attribute_contrived?(attr)
|
|
# true
|
|
# end
|
|
#
|
|
# def clear_attribute(attr)
|
|
# send("#{attr}=", nil)
|
|
# end
|
|
#
|
|
# def reset_attribute_to_default!(attr)
|
|
# send("#{attr}=", 'Default Name')
|
|
# end
|
|
# end
|
|
module AttributeMethods
|
|
extend ActiveSupport::Concern
|
|
|
|
NAME_COMPILABLE_REGEXP = /\A[a-zA-Z_]\w*[!?=]?\z/
|
|
CALL_COMPILABLE_REGEXP = /\A[a-zA-Z_]\w*[!?]?\z/
|
|
FORWARD_PARAMETERS = "*args"
|
|
|
|
included do
|
|
class_attribute :attribute_aliases, instance_writer: false, default: {}
|
|
class_attribute :attribute_method_matchers, instance_writer: false, default: [ ClassMethods::AttributeMethodMatcher.new ]
|
|
end
|
|
|
|
module ClassMethods
|
|
# Declares a method available for all attributes with the given prefix.
|
|
# Uses +method_missing+ and <tt>respond_to?</tt> to rewrite the method.
|
|
#
|
|
# #{prefix}#{attr}(*args, &block)
|
|
#
|
|
# to
|
|
#
|
|
# #{prefix}attribute(#{attr}, *args, &block)
|
|
#
|
|
# An instance method <tt>#{prefix}attribute</tt> must exist and accept
|
|
# at least the +attr+ argument.
|
|
#
|
|
# class Person
|
|
# include ActiveModel::AttributeMethods
|
|
#
|
|
# attr_accessor :name
|
|
# attribute_method_prefix 'clear_'
|
|
# define_attribute_methods :name
|
|
#
|
|
# private
|
|
#
|
|
# def clear_attribute(attr)
|
|
# send("#{attr}=", nil)
|
|
# end
|
|
# end
|
|
#
|
|
# person = Person.new
|
|
# person.name = 'Bob'
|
|
# person.name # => "Bob"
|
|
# person.clear_name
|
|
# person.name # => nil
|
|
def attribute_method_prefix(*prefixes, parameters: nil)
|
|
self.attribute_method_matchers += prefixes.map! { |prefix| AttributeMethodMatcher.new(prefix: prefix, parameters: parameters) }
|
|
undefine_attribute_methods
|
|
end
|
|
|
|
# Declares a method available for all attributes with the given suffix.
|
|
# Uses +method_missing+ and <tt>respond_to?</tt> to rewrite the method.
|
|
#
|
|
# #{attr}#{suffix}(*args, &block)
|
|
#
|
|
# to
|
|
#
|
|
# attribute#{suffix}(#{attr}, *args, &block)
|
|
#
|
|
# An <tt>attribute#{suffix}</tt> instance method must exist and accept at
|
|
# least the +attr+ argument.
|
|
#
|
|
# class Person
|
|
# include ActiveModel::AttributeMethods
|
|
#
|
|
# attr_accessor :name
|
|
# attribute_method_suffix '_short?'
|
|
# define_attribute_methods :name
|
|
#
|
|
# private
|
|
#
|
|
# def attribute_short?(attr)
|
|
# send(attr).length < 5
|
|
# end
|
|
# end
|
|
#
|
|
# person = Person.new
|
|
# person.name = 'Bob'
|
|
# person.name # => "Bob"
|
|
# person.name_short? # => true
|
|
def attribute_method_suffix(*suffixes, parameters: nil)
|
|
self.attribute_method_matchers += suffixes.map! { |suffix| AttributeMethodMatcher.new(suffix: suffix, parameters: parameters) }
|
|
undefine_attribute_methods
|
|
end
|
|
|
|
# Declares a method available for all attributes with the given prefix
|
|
# and suffix. Uses +method_missing+ and <tt>respond_to?</tt> to rewrite
|
|
# the method.
|
|
#
|
|
# #{prefix}#{attr}#{suffix}(*args, &block)
|
|
#
|
|
# to
|
|
#
|
|
# #{prefix}attribute#{suffix}(#{attr}, *args, &block)
|
|
#
|
|
# An <tt>#{prefix}attribute#{suffix}</tt> instance method must exist and
|
|
# accept at least the +attr+ argument.
|
|
#
|
|
# class Person
|
|
# include ActiveModel::AttributeMethods
|
|
#
|
|
# attr_accessor :name
|
|
# attribute_method_affix prefix: 'reset_', suffix: '_to_default!'
|
|
# define_attribute_methods :name
|
|
#
|
|
# private
|
|
#
|
|
# def reset_attribute_to_default!(attr)
|
|
# send("#{attr}=", 'Default Name')
|
|
# end
|
|
# end
|
|
#
|
|
# person = Person.new
|
|
# person.name # => 'Gem'
|
|
# person.reset_name_to_default!
|
|
# person.name # => 'Default Name'
|
|
def attribute_method_affix(*affixes)
|
|
self.attribute_method_matchers += affixes.map! { |affix| AttributeMethodMatcher.new(**affix) }
|
|
undefine_attribute_methods
|
|
end
|
|
|
|
# Allows you to make aliases for attributes.
|
|
#
|
|
# class Person
|
|
# include ActiveModel::AttributeMethods
|
|
#
|
|
# attr_accessor :name
|
|
# attribute_method_suffix '_short?'
|
|
# define_attribute_methods :name
|
|
#
|
|
# alias_attribute :nickname, :name
|
|
#
|
|
# private
|
|
#
|
|
# def attribute_short?(attr)
|
|
# send(attr).length < 5
|
|
# end
|
|
# end
|
|
#
|
|
# person = Person.new
|
|
# person.name = 'Bob'
|
|
# person.name # => "Bob"
|
|
# person.nickname # => "Bob"
|
|
# person.name_short? # => true
|
|
# person.nickname_short? # => true
|
|
def alias_attribute(new_name, old_name)
|
|
self.attribute_aliases = attribute_aliases.merge(new_name.to_s => old_name.to_s)
|
|
ActiveSupport::CodeGenerator.batch(self, __FILE__, __LINE__) do |code_generator|
|
|
attribute_method_matchers.each do |matcher|
|
|
method_name = matcher.method_name(new_name).to_s
|
|
target_name = matcher.method_name(old_name).to_s
|
|
parameters = matcher.parameters
|
|
|
|
mangled_name = target_name
|
|
unless NAME_COMPILABLE_REGEXP.match?(target_name)
|
|
mangled_name = "__temp__#{target_name.unpack1("h*")}"
|
|
end
|
|
|
|
code_generator.define_cached_method(method_name, as: mangled_name, namespace: :alias_attribute) do |batch|
|
|
body = if CALL_COMPILABLE_REGEXP.match?(target_name)
|
|
"self.#{target_name}(#{parameters || ''})"
|
|
else
|
|
call_args = [":'#{target_name}'"]
|
|
call_args << parameters if parameters
|
|
"send(#{call_args.join(", ")})"
|
|
end
|
|
|
|
modifier = matcher.parameters == FORWARD_PARAMETERS ? "ruby2_keywords " : ""
|
|
|
|
batch <<
|
|
"#{modifier}def #{mangled_name}(#{parameters || ''})" <<
|
|
body <<
|
|
"end"
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
# Is +new_name+ an alias?
|
|
def attribute_alias?(new_name)
|
|
attribute_aliases.key? new_name.to_s
|
|
end
|
|
|
|
# Returns the original name for the alias +name+
|
|
def attribute_alias(name)
|
|
attribute_aliases[name.to_s]
|
|
end
|
|
|
|
# Declares the attributes that should be prefixed and suffixed by
|
|
# <tt>ActiveModel::AttributeMethods</tt>.
|
|
#
|
|
# To use, pass attribute names (as strings or symbols). Be sure to declare
|
|
# +define_attribute_methods+ after you define any prefix, suffix or affix
|
|
# methods, or they will not hook in.
|
|
#
|
|
# class Person
|
|
# include ActiveModel::AttributeMethods
|
|
#
|
|
# attr_accessor :name, :age, :address
|
|
# attribute_method_prefix 'clear_'
|
|
#
|
|
# # Call to define_attribute_methods must appear after the
|
|
# # attribute_method_prefix, attribute_method_suffix or
|
|
# # attribute_method_affix declarations.
|
|
# define_attribute_methods :name, :age, :address
|
|
#
|
|
# private
|
|
#
|
|
# def clear_attribute(attr)
|
|
# send("#{attr}=", nil)
|
|
# end
|
|
# end
|
|
def define_attribute_methods(*attr_names)
|
|
ActiveSupport::CodeGenerator.batch(generated_attribute_methods, __FILE__, __LINE__) do |owner|
|
|
attr_names.flatten.each { |attr_name| define_attribute_method(attr_name, _owner: owner) }
|
|
end
|
|
end
|
|
|
|
# Declares an attribute that should be prefixed and suffixed by
|
|
# <tt>ActiveModel::AttributeMethods</tt>.
|
|
#
|
|
# To use, pass an attribute name (as string or symbol). Be sure to declare
|
|
# +define_attribute_method+ after you define any prefix, suffix or affix
|
|
# method, or they will not hook in.
|
|
#
|
|
# class Person
|
|
# include ActiveModel::AttributeMethods
|
|
#
|
|
# attr_accessor :name
|
|
# attribute_method_suffix '_short?'
|
|
#
|
|
# # Call to define_attribute_method must appear after the
|
|
# # attribute_method_prefix, attribute_method_suffix or
|
|
# # attribute_method_affix declarations.
|
|
# define_attribute_method :name
|
|
#
|
|
# private
|
|
#
|
|
# def attribute_short?(attr)
|
|
# send(attr).length < 5
|
|
# end
|
|
# end
|
|
#
|
|
# person = Person.new
|
|
# person.name = 'Bob'
|
|
# person.name # => "Bob"
|
|
# person.name_short? # => true
|
|
def define_attribute_method(attr_name, _owner: generated_attribute_methods)
|
|
ActiveSupport::CodeGenerator.batch(_owner, __FILE__, __LINE__) do |owner|
|
|
attribute_method_matchers.each do |matcher|
|
|
method_name = matcher.method_name(attr_name)
|
|
|
|
unless instance_method_already_implemented?(method_name)
|
|
generate_method = "define_method_#{matcher.target}"
|
|
|
|
if respond_to?(generate_method, true)
|
|
send(generate_method, attr_name.to_s, owner: owner)
|
|
else
|
|
define_proxy_call(owner, method_name, matcher.target, matcher.parameters, attr_name.to_s, namespace: :active_model)
|
|
end
|
|
end
|
|
end
|
|
attribute_method_matchers_cache.clear
|
|
end
|
|
end
|
|
|
|
# Removes all the previously dynamically defined methods from the class.
|
|
#
|
|
# class Person
|
|
# include ActiveModel::AttributeMethods
|
|
#
|
|
# attr_accessor :name
|
|
# attribute_method_suffix '_short?'
|
|
# define_attribute_method :name
|
|
#
|
|
# private
|
|
#
|
|
# def attribute_short?(attr)
|
|
# send(attr).length < 5
|
|
# end
|
|
# end
|
|
#
|
|
# person = Person.new
|
|
# person.name = 'Bob'
|
|
# person.name_short? # => true
|
|
#
|
|
# Person.undefine_attribute_methods
|
|
#
|
|
# person.name_short? # => NoMethodError
|
|
def undefine_attribute_methods
|
|
generated_attribute_methods.module_eval do
|
|
undef_method(*instance_methods)
|
|
end
|
|
attribute_method_matchers_cache.clear
|
|
end
|
|
|
|
private
|
|
def generated_attribute_methods
|
|
@generated_attribute_methods ||= Module.new.tap { |mod| include mod }
|
|
end
|
|
|
|
def instance_method_already_implemented?(method_name)
|
|
generated_attribute_methods.method_defined?(method_name)
|
|
end
|
|
|
|
# The methods +method_missing+ and +respond_to?+ of this module are
|
|
# invoked often in a typical rails, both of which invoke the method
|
|
# +matched_attribute_method+. The latter method iterates through an
|
|
# array doing regular expression matches, which results in a lot of
|
|
# object creations. Most of the time it returns a +nil+ match. As the
|
|
# match result is always the same given a +method_name+, this cache is
|
|
# used to alleviate the GC, which ultimately also speeds up the app
|
|
# significantly (in our case our test suite finishes 10% faster with
|
|
# this cache).
|
|
def attribute_method_matchers_cache
|
|
@attribute_method_matchers_cache ||= Concurrent::Map.new(initial_capacity: 4)
|
|
end
|
|
|
|
def attribute_method_matchers_matching(method_name)
|
|
attribute_method_matchers_cache.compute_if_absent(method_name) do
|
|
attribute_method_matchers.filter_map { |matcher| matcher.match(method_name) }
|
|
end
|
|
end
|
|
|
|
# Define a method `name` in `mod` that dispatches to `send`
|
|
# using the given `extra` args. This falls back on `send`
|
|
# if the called name cannot be compiled.
|
|
def define_proxy_call(code_generator, name, target, parameters, *call_args, namespace:)
|
|
mangled_name = name
|
|
unless NAME_COMPILABLE_REGEXP.match?(name)
|
|
mangled_name = "__temp__#{name.unpack1("h*")}"
|
|
end
|
|
|
|
code_generator.define_cached_method(name, as: mangled_name, namespace: namespace) do |batch|
|
|
call_args.map!(&:inspect)
|
|
call_args << parameters if parameters
|
|
|
|
body = if CALL_COMPILABLE_REGEXP.match?(target)
|
|
"self.#{target}(#{call_args.join(", ")})"
|
|
else
|
|
call_args.unshift(":'#{target}'")
|
|
"send(#{call_args.join(", ")})"
|
|
end
|
|
|
|
modifier = parameters == FORWARD_PARAMETERS ? "ruby2_keywords " : ""
|
|
|
|
batch <<
|
|
"#{modifier}def #{mangled_name}(#{parameters || ''})" <<
|
|
body <<
|
|
"end"
|
|
end
|
|
end
|
|
|
|
class AttributeMethodMatcher # :nodoc:
|
|
attr_reader :prefix, :suffix, :target, :parameters
|
|
|
|
AttributeMethodMatch = Struct.new(:target, :attr_name)
|
|
|
|
def initialize(prefix: "", suffix: "", parameters: nil)
|
|
@prefix = prefix
|
|
@suffix = suffix
|
|
@parameters = parameters.nil? ? FORWARD_PARAMETERS : parameters
|
|
@regex = /^(?:#{Regexp.escape(@prefix)})(.*)(?:#{Regexp.escape(@suffix)})$/
|
|
@target = "#{@prefix}attribute#{@suffix}"
|
|
@method_name = "#{prefix}%s#{suffix}"
|
|
end
|
|
|
|
def match(method_name)
|
|
if @regex =~ method_name
|
|
AttributeMethodMatch.new(target, $1)
|
|
end
|
|
end
|
|
|
|
def method_name(attr_name)
|
|
@method_name % attr_name
|
|
end
|
|
end
|
|
end
|
|
|
|
# Allows access to the object attributes, which are held in the hash
|
|
# returned by <tt>attributes</tt>, as though they were first-class
|
|
# methods. So a +Person+ class with a +name+ attribute can for example use
|
|
# <tt>Person#name</tt> and <tt>Person#name=</tt> and never directly use
|
|
# the attributes hash -- except for multiple assignments with
|
|
# <tt>ActiveRecord::Base#attributes=</tt>.
|
|
#
|
|
# It's also possible to instantiate related objects, so a <tt>Client</tt>
|
|
# class belonging to the +clients+ table with a +master_id+ foreign key
|
|
# can instantiate master through <tt>Client#master</tt>.
|
|
def method_missing(method, *args, &block)
|
|
if respond_to_without_attributes?(method, true)
|
|
super
|
|
else
|
|
match = matched_attribute_method(method.to_s)
|
|
match ? attribute_missing(match, *args, &block) : super
|
|
end
|
|
end
|
|
ruby2_keywords(:method_missing)
|
|
|
|
# +attribute_missing+ is like +method_missing+, but for attributes. When
|
|
# +method_missing+ is called we check to see if there is a matching
|
|
# attribute method. If so, we tell +attribute_missing+ to dispatch the
|
|
# attribute. This method can be overloaded to customize the behavior.
|
|
def attribute_missing(match, *args, &block)
|
|
__send__(match.target, match.attr_name, *args, &block)
|
|
end
|
|
|
|
# A +Person+ instance with a +name+ attribute can ask
|
|
# <tt>person.respond_to?(:name)</tt>, <tt>person.respond_to?(:name=)</tt>,
|
|
# and <tt>person.respond_to?(:name?)</tt> which will all return +true+.
|
|
alias :respond_to_without_attributes? :respond_to?
|
|
def respond_to?(method, include_private_methods = false)
|
|
if super
|
|
true
|
|
elsif !include_private_methods && super(method, true)
|
|
# If we're here then we haven't found among non-private methods
|
|
# but found among all methods. Which means that the given method is private.
|
|
false
|
|
else
|
|
!matched_attribute_method(method.to_s).nil?
|
|
end
|
|
end
|
|
|
|
private
|
|
def attribute_method?(attr_name)
|
|
respond_to_without_attributes?(:attributes) && attributes.include?(attr_name)
|
|
end
|
|
|
|
# Returns a struct representing the matching attribute method.
|
|
# The struct's attributes are prefix, base and suffix.
|
|
def matched_attribute_method(method_name)
|
|
matches = self.class.send(:attribute_method_matchers_matching, method_name)
|
|
matches.detect { |match| attribute_method?(match.attr_name) }
|
|
end
|
|
|
|
def missing_attribute(attr_name, stack)
|
|
raise ActiveModel::MissingAttributeError, "missing attribute: #{attr_name}", stack
|
|
end
|
|
|
|
def _read_attribute(attr)
|
|
__send__(attr)
|
|
end
|
|
|
|
module AttrNames # :nodoc:
|
|
DEF_SAFE_NAME = /\A[a-zA-Z_]\w*\z/
|
|
|
|
# We want to generate the methods via module_eval rather than
|
|
# define_method, because define_method is slower on dispatch.
|
|
#
|
|
# But sometimes the database might return columns with
|
|
# characters that are not allowed in normal method names (like
|
|
# 'my_column(omg)'. So to work around this we first define with
|
|
# the __temp__ identifier, and then use alias method to rename
|
|
# it to what we want.
|
|
#
|
|
# We are also defining a constant to hold the frozen string of
|
|
# the attribute name. Using a constant means that we do not have
|
|
# to allocate an object on each call to the attribute method.
|
|
# Making it frozen means that it doesn't get duped when used to
|
|
# key the @attributes in read_attribute.
|
|
def self.define_attribute_accessor_method(owner, attr_name, writer: false)
|
|
method_name = "#{attr_name}#{'=' if writer}"
|
|
if attr_name.ascii_only? && DEF_SAFE_NAME.match?(attr_name)
|
|
yield method_name, "'#{attr_name}'"
|
|
else
|
|
safe_name = attr_name.unpack1("h*")
|
|
const_name = "ATTR_#{safe_name}"
|
|
const_set(const_name, attr_name) unless const_defined?(const_name)
|
|
temp_method_name = "__temp__#{safe_name}#{'=' if writer}"
|
|
attr_name_expr = "::ActiveModel::AttributeMethods::AttrNames::#{const_name}"
|
|
yield temp_method_name, attr_name_expr
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|