mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
4838c1716a
* Use Webpacker by default on new apps * Stop including coffee-rails by default * Drop using a js_compressor by default * Drop extra test for coffeescript inclusion by default * Stick with skip_javascript to signify skipping webpack * Don't install a JS runtime by default any more * app/javascript will be the new default directory for JS * Make it clear that this is just for configuring the default Webpack framework setup now * Start using the Webpack tag in the default layout * Irrelevant test * jQuery is long gone * Stop having asset pipeline compile default application.js * Add rails-ujs by default to the Webpack setup * Add Active Storage JavaScript to application.js pack by default * Consistent quoting * Add Turbolinks to default pack * Add Action Cable to default pack Need some work on how to set the global consumer that channels will work with. @javan? * Require all channels by default and use a separate consumer stub * Channel generator now targets Webpack style * Update task docs to match new generator style * Use uniform import style * Drop the JS assets generator It was barely helpful as it was. It’s no longer helpful in a Webpacked world. Sayonara! * Add app/javascript to the stats directories * Simpler import style Which match the other imports. * Address test failures from dropping JS compilation (and compression) * webpacker-default: Modify `AssetsGeneratorTest` Before: ``` $ bin/test test/generators/assets_generator_test.rb Run options: --seed 46201 F Failure: AssetsGeneratorTest#test_assets [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/assets_generator_test.rb:12]: Expected file "app/assets/javascripts/posts.js" to exist, but does not bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/assets_generator_test.rb:10 . Finished in 0.031343s, 63.8101 runs/s, 95.7152 assertions/s. 2 runs, 3 assertions, 1 failures, 0 errors, 0 skips ``` After: ``` $ bin/test test/generators/assets_generator_test.rb Run options: --seed 43571 .. Finished in 0.030370s, 65.8545 runs/s, 65.8545 assertions/s. 2 runs, 2 assertions, 0 failures, 0 errors, 0 skips ``` * webpacker-default: Modify `ChannelGeneratorTest` Before: ``` $ bin/test test/generators/channel_generator_test.rb Run options: --seed 8986 .F Failure: ChannelGeneratorTest#test_channel_with_multiple_actions_is_created [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:43]: Expected file "app/assets/javascripts/channels/chat.js" to exist, but does not bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:34 .F Failure: ChannelGeneratorTest#test_channel_is_created [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:29]: Expected file "app/assets/javascripts/channels/chat.js" to exist, but does not bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:22 E Error: ChannelGeneratorTest#test_cable_js_is_created_if_not_present_already: Errno::ENOENT: No such file or directory @ apply2files - /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/fixtures/tmp/app/assets/javascripts/cable.js bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:60 F Failure: ChannelGeneratorTest#test_channel_suffix_is_not_duplicated [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:87]: Expected file "app/assets/javascripts/channels/chat.js" to exist, but does not bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:80 F Failure: ChannelGeneratorTest#test_channel_on_revoke [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:77]: Expected file "app/assets/javascripts/cable.js" to exist, but does not bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:68 Finished in 0.064384s, 108.7227 runs/s, 481.4861 assertions/s. 7 runs, 31 assertions, 4 failures, 1 errors, 0 skips ``` After: ``` $ bin/test test/generators/channel_generator_test.rb Run options: --seed 44857 ....... Finished in 0.060243s, 116.1961 runs/s, 697.1764 assertions/s. 7 runs, 42 assertions, 0 failures, 0 errors, 0 skips ``` * Fix shared generator tests. * webpacker-default: Modify `ControllerGeneratorTest` The JS assets generator was dropped. ref.46215b1794
* Revert "Simpler import style". It's currently failing with an error of "TypeError: undefined is not an object (evaluating '__WEBPACK_IMPORTED_MODULE_2_activestorage___default.a.start')". Waiting for @javan to have a look. This reverts commit5d3ebb7105
. * require webpacker in test app * Add webpacker without making the build hang/timeout. (#33640) * use yarn workspaces to allow for installing unreleased packages and only generate js/bootsnap when required * no longer need to have webpacker in env templates as webpacker moved this config to yml file * Fix rubocop violation * Got the test passing for the running scaffold * update expected lines of code * update middleware tests to account for webpacker * disable js in plugins be default to get the tests passing (#34009) * clear codeclimate report issues * Anything newer than currently released is good * Use Webpacker development version during development of Rails * Edge should get development webpacker as well * Add changelog entry for Webpacker change
254 lines
7.6 KiB
Ruby
254 lines
7.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "isolation/abstract_unit"
|
|
require "env_helpers"
|
|
|
|
module ApplicationTests
|
|
class RakeTest < ActiveSupport::TestCase
|
|
include ActiveSupport::Testing::Isolation, EnvHelpers
|
|
|
|
def setup
|
|
build_app
|
|
end
|
|
|
|
def teardown
|
|
teardown_app
|
|
end
|
|
|
|
def test_gems_tasks_are_loaded_first_than_application_ones
|
|
app_file "lib/tasks/app.rake", <<-RUBY
|
|
$task_loaded = Rake::Task.task_defined?("db:create:all")
|
|
RUBY
|
|
|
|
require "#{app_path}/config/environment"
|
|
::Rails.application.load_tasks
|
|
assert $task_loaded
|
|
end
|
|
|
|
test "task is protected when previous migration was production" do
|
|
with_rails_env "production" do
|
|
rails "generate", "model", "product", "name:string"
|
|
rails "db:create", "db:migrate"
|
|
output = rails("db:test:prepare", allow_failure: true)
|
|
|
|
assert_match(/ActiveRecord::ProtectedEnvironmentError/, output)
|
|
end
|
|
end
|
|
|
|
def test_not_protected_when_previous_migration_was_not_production
|
|
with_rails_env "test" do
|
|
rails "generate", "model", "product", "name:string"
|
|
rails "db:create", "db:migrate"
|
|
output = rails("db:test:prepare", "test")
|
|
|
|
assert_no_match(/ActiveRecord::ProtectedEnvironmentError/, output)
|
|
end
|
|
end
|
|
|
|
def test_environment_is_required_in_rake_tasks
|
|
app_file "config/environment.rb", <<-RUBY
|
|
SuperMiddleware = Struct.new(:app)
|
|
|
|
Rails.application.configure do
|
|
config.middleware.use SuperMiddleware
|
|
end
|
|
|
|
Rails.application.initialize!
|
|
RUBY
|
|
|
|
assert_match("SuperMiddleware", rails("middleware"))
|
|
end
|
|
|
|
def test_initializers_are_executed_in_rake_tasks
|
|
add_to_config <<-RUBY
|
|
initializer "do_something" do
|
|
puts "Doing something..."
|
|
end
|
|
|
|
rake_tasks do
|
|
task do_nothing: :environment do
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
output = rails("do_nothing")
|
|
assert_match "Doing something...", output
|
|
end
|
|
|
|
def test_does_not_explode_when_accessing_a_model
|
|
add_to_config <<-RUBY
|
|
rake_tasks do
|
|
task do_nothing: :environment do
|
|
Hello.new.world
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
app_file "app/models/hello.rb", <<-RUBY
|
|
class Hello
|
|
def world
|
|
puts 'Hello world'
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
output = rails("do_nothing")
|
|
assert_match "Hello world", output
|
|
end
|
|
|
|
def test_should_not_eager_load_model_for_rake
|
|
add_to_config <<-RUBY
|
|
rake_tasks do
|
|
task do_nothing: :environment do
|
|
puts 'There is nothing'
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
add_to_env_config "production", <<-RUBY
|
|
config.eager_load = true
|
|
RUBY
|
|
|
|
app_file "app/models/hello.rb", <<-RUBY
|
|
raise 'should not be pre-required for rake even eager_load=true'
|
|
RUBY
|
|
|
|
output = rails("do_nothing", "RAILS_ENV=production")
|
|
assert_match "There is nothing", output
|
|
end
|
|
|
|
def test_code_statistics_sanity
|
|
assert_match "Code LOC: 32 Test LOC: 0 Code to Test Ratio: 1:0.0",
|
|
rails("stats")
|
|
end
|
|
|
|
def test_logger_is_flushed_when_exiting_production_rake_tasks
|
|
add_to_config <<-RUBY
|
|
rake_tasks do
|
|
task log_something: :environment do
|
|
Rails.logger.error("Sample log message")
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
rails "log_something", "RAILS_ENV=production"
|
|
assert_match "Sample log message", File.read("#{app_path}/log/production.log")
|
|
end
|
|
|
|
def test_loading_specific_fixtures
|
|
rails "generate", "model", "user", "username:string", "password:string"
|
|
rails "generate", "model", "product", "name:string"
|
|
rails "db:migrate"
|
|
|
|
require "#{rails_root}/config/environment"
|
|
|
|
# loading a specific fixture
|
|
rails "db:fixtures:load", "FIXTURES=products"
|
|
|
|
assert_equal 2, ::AppTemplate::Application::Product.count
|
|
assert_equal 0, ::AppTemplate::Application::User.count
|
|
end
|
|
|
|
def test_loading_only_yml_fixtures
|
|
rails "db:migrate"
|
|
|
|
app_file "test/fixtures/products.csv", ""
|
|
|
|
require "#{rails_root}/config/environment"
|
|
rails "db:fixtures:load"
|
|
end
|
|
|
|
def test_scaffold_tests_pass_by_default
|
|
rails "generate", "scaffold", "user", "username:string", "password:string"
|
|
with_rails_env("test") { rails("db:migrate") }
|
|
output = rails("test")
|
|
|
|
assert_match(/7 runs, 9 assertions, 0 failures, 0 errors/, output)
|
|
assert_no_match(/Errors running/, output)
|
|
end
|
|
|
|
def test_api_scaffold_tests_pass_by_default
|
|
add_to_config <<-RUBY
|
|
config.api_only = true
|
|
RUBY
|
|
|
|
app_file "app/controllers/application_controller.rb", <<-RUBY
|
|
class ApplicationController < ActionController::API
|
|
end
|
|
RUBY
|
|
|
|
rails "generate", "scaffold", "user", "username:string", "password:string"
|
|
with_rails_env("test") { rails("db:migrate") }
|
|
output = rails("test")
|
|
|
|
assert_match(/5 runs, 7 assertions, 0 failures, 0 errors/, output)
|
|
assert_no_match(/Errors running/, output)
|
|
end
|
|
|
|
def test_scaffold_with_references_columns_tests_pass_by_default
|
|
rails "generate", "model", "Product"
|
|
rails "generate", "model", "Cart"
|
|
rails "generate", "scaffold", "LineItems", "product:references", "cart:belongs_to"
|
|
with_rails_env("test") { rails("db:migrate") }
|
|
rails("webpacker:compile")
|
|
output = rails("test")
|
|
|
|
assert_match(/7 runs, 9 assertions, 0 failures, 0 errors/, output)
|
|
assert_no_match(/Errors running/, output)
|
|
end
|
|
|
|
def test_db_test_prepare_when_using_sql_format
|
|
add_to_config "config.active_record.schema_format = :sql"
|
|
rails "generate", "scaffold", "user", "username:string"
|
|
rails "db:migrate"
|
|
output = rails("db:test:prepare", "--trace")
|
|
assert_match(/Execute db:test:load_structure/, output)
|
|
end
|
|
|
|
def test_rake_dump_structure_should_respect_db_structure_env_variable
|
|
# ensure we have a schema_migrations table to dump
|
|
rails "db:migrate", "db:structure:dump", "SCHEMA=db/my_structure.sql"
|
|
assert File.exist?(File.join(app_path, "db", "my_structure.sql"))
|
|
end
|
|
|
|
def test_rake_dump_structure_should_be_called_twice_when_migrate_redo
|
|
add_to_config "config.active_record.schema_format = :sql"
|
|
|
|
rails "g", "model", "post", "title:string"
|
|
output = rails("db:migrate:redo", "--trace")
|
|
|
|
# expect only Invoke db:structure:dump (first_time)
|
|
assert_no_match(/^\*\* Invoke db:structure:dump\s+$/, output)
|
|
end
|
|
|
|
def test_rake_dump_schema_cache
|
|
rails "generate", "model", "post", "title:string"
|
|
rails "generate", "model", "product", "name:string"
|
|
rails "db:migrate", "db:schema:cache:dump"
|
|
assert File.exist?(File.join(app_path, "db", "schema_cache.yml"))
|
|
end
|
|
|
|
def test_rake_clear_schema_cache
|
|
rails "db:schema:cache:dump", "db:schema:cache:clear"
|
|
assert_not File.exist?(File.join(app_path, "db", "schema_cache.yml"))
|
|
end
|
|
|
|
def test_copy_templates
|
|
rails "app:templates:copy"
|
|
%w(controller mailer scaffold).each do |dir|
|
|
assert File.exist?(File.join(app_path, "lib", "templates", "erb", dir))
|
|
end
|
|
%w(controller helper scaffold_controller assets).each do |dir|
|
|
assert File.exist?(File.join(app_path, "lib", "templates", "rails", dir))
|
|
end
|
|
end
|
|
|
|
def test_template_load_initializers
|
|
app_file "config/initializers/dummy.rb", "puts 'Hello, World!'"
|
|
app_file "template.rb", ""
|
|
|
|
output = rails("app:template", "LOCATION=template.rb")
|
|
assert_match(/Hello, World!/, output)
|
|
end
|
|
end
|
|
end
|