mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
56cdc81c08
In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964
117 lines
3.2 KiB
Ruby
117 lines
3.2 KiB
Ruby
# encoding: utf-8
|
|
require 'isolation/abstract_unit'
|
|
require 'rack/test'
|
|
|
|
module ApplicationTests
|
|
class MiddlewareExceptionsTest < ActiveSupport::TestCase
|
|
include ActiveSupport::Testing::Isolation
|
|
include Rack::Test::Methods
|
|
|
|
def setup
|
|
build_app
|
|
boot_rails
|
|
end
|
|
|
|
def teardown
|
|
teardown_app
|
|
end
|
|
|
|
test "show exceptions middleware filter backtrace before logging" do
|
|
controller :foo, <<-RUBY
|
|
class FooController < ActionController::Base
|
|
def index
|
|
raise 'oops'
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
get "/foo"
|
|
assert_equal 500, last_response.status
|
|
|
|
log = File.read(Rails.application.config.paths["log"].first)
|
|
assert_no_match(/action_dispatch/, log, log)
|
|
assert_match(/oops/, log, log)
|
|
end
|
|
|
|
test "renders active record exceptions as 404" do
|
|
controller :foo, <<-RUBY
|
|
class FooController < ActionController::Base
|
|
def index
|
|
raise ActiveRecord::RecordNotFound
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
get "/foo"
|
|
assert_equal 404, last_response.status
|
|
end
|
|
|
|
test "uses custom exceptions app" do
|
|
add_to_config <<-RUBY
|
|
config.exceptions_app = lambda do |env|
|
|
[404, { "Content-Type" => "text/plain" }, ["YOU FAILED BRO"]]
|
|
end
|
|
RUBY
|
|
|
|
app.config.action_dispatch.show_exceptions = true
|
|
|
|
get "/foo"
|
|
assert_equal 404, last_response.status
|
|
assert_equal "YOU FAILED BRO", last_response.body
|
|
end
|
|
|
|
test "unspecified route when action_dispatch.show_exceptions is not set raises an exception" do
|
|
app.config.action_dispatch.show_exceptions = false
|
|
|
|
assert_raise(ActionController::RoutingError) do
|
|
get '/foo'
|
|
end
|
|
end
|
|
|
|
test "unspecified route when action_dispatch.show_exceptions is set shows 404" do
|
|
app.config.action_dispatch.show_exceptions = true
|
|
|
|
assert_nothing_raised(ActionController::RoutingError) do
|
|
get '/foo'
|
|
assert_match "The page you were looking for doesn't exist.", last_response.body
|
|
end
|
|
end
|
|
|
|
test "unspecified route when action_dispatch.show_exceptions and consider_all_requests_local are set shows diagnostics" do
|
|
app.config.action_dispatch.show_exceptions = true
|
|
app.config.consider_all_requests_local = true
|
|
|
|
assert_nothing_raised(ActionController::RoutingError) do
|
|
get '/foo'
|
|
assert_match "No route matches", last_response.body
|
|
end
|
|
end
|
|
|
|
test "displays diagnostics message when exception raised in template that contains UTF-8" do
|
|
app.config.action_dispatch.show_exceptions = true
|
|
app.config.consider_all_requests_local = true
|
|
|
|
controller :foo, <<-RUBY
|
|
class FooController < ActionController::Base
|
|
def index
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
app_file 'app/views/foo/index.html.erb', <<-ERB
|
|
<% raise 'boooom' %>
|
|
✓測試テスト시험
|
|
ERB
|
|
|
|
app_file 'config/routes.rb', <<-RUBY
|
|
AppTemplate::Application.routes.draw do
|
|
post ':controller(/:action)'
|
|
end
|
|
RUBY
|
|
|
|
post '/foo', :utf8 => '✓'
|
|
assert_match(/boooom/, last_response.body)
|
|
assert_match(/測試テスト시험/, last_response.body)
|
|
end
|
|
end
|
|
end
|