mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
88ee52f9d9
- ### Problem ActionPack requires "action_view/base" at boot time, this causes a variety of issue that I described in detail in #38024. There is no real reason to require av/base in the ActionDispatch::Debugexceptions class. ### Solution Like any other components (such as ActiveRecord, ActiveJob...), ActionView::Base shouldn't be loaded at boot time. Here are the two main changes needed for this: 1) Actionview has a special initializer that needs to run before the app is fully booted (adding a executor needs to be done before application is done booting)63ec70e700/actionview/lib/action_view/railtie.rb (L81-L84)That initializer used a lazy load hooks but we can't do that anymore because Action::Base view won't be triggered during booting process. When it will get triggered, (presumably on the first request), it's too late to add an executor. ------------------------------------------------ 2) Compare to other components, ActionView doesn't use `Base` for configuration flag. A lot of flags ares instead set on modules (FormHelper, FormTagHelper). The problem is that those module depends on AV::Base to be loaded, as otherwise configuration set by the user aren't applied. (Since the lazy load hooks hasn't been triggered)63ec70e700/actionview/lib/action_view/railtie.rb (L66-L69)We shouldn't wait for AB::Base to be loaded in order to set these configuration. However, we need to do it inside an `after_initialize` block in order to let application set it to the value they want. Closes #28538 Co-authored-by: betesh <iybetesh@gmail.com>"
100 lines
2.9 KiB
Ruby
100 lines
2.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
#--
|
|
# Copyright (c) 2004-2019 David Heinemeier Hansson
|
|
#
|
|
# Permission is hereby granted, free of charge, to any person obtaining
|
|
# a copy of this software and associated documentation files (the
|
|
# "Software"), to deal in the Software without restriction, including
|
|
# without limitation the rights to use, copy, modify, merge, publish,
|
|
# distribute, sublicense, and/or sell copies of the Software, and to
|
|
# permit persons to whom the Software is furnished to do so, subject to
|
|
# the following conditions:
|
|
#
|
|
# The above copyright notice and this permission notice shall be
|
|
# included in all copies or substantial portions of the Software.
|
|
#
|
|
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
|
|
# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
|
|
# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
|
|
# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
#++
|
|
|
|
require "active_support"
|
|
require "active_support/rails"
|
|
require "action_view/version"
|
|
|
|
module ActionView
|
|
extend ActiveSupport::Autoload
|
|
|
|
ENCODING_FLAG = '#.*coding[:=]\s*(\S+)[ \t]*'
|
|
|
|
eager_autoload do
|
|
autoload :Base
|
|
autoload :Context
|
|
autoload :Digestor
|
|
autoload :Helpers
|
|
autoload :LookupContext
|
|
autoload :Layouts
|
|
autoload :PathSet
|
|
autoload :RecordIdentifier
|
|
autoload :Rendering
|
|
autoload :RoutingUrlFor
|
|
autoload :Template
|
|
autoload :UnboundTemplate
|
|
autoload :ViewPaths
|
|
|
|
autoload_under "renderer" do
|
|
autoload :Renderer
|
|
autoload :AbstractRenderer
|
|
autoload :PartialRenderer
|
|
autoload :TemplateRenderer
|
|
autoload :StreamingTemplateRenderer
|
|
end
|
|
|
|
autoload_at "action_view/template/resolver" do
|
|
autoload :Resolver
|
|
autoload :PathResolver
|
|
autoload :FileSystemResolver
|
|
autoload :OptimizedFileSystemResolver
|
|
autoload :FallbackFileSystemResolver
|
|
end
|
|
|
|
autoload_at "action_view/buffers" do
|
|
autoload :OutputBuffer
|
|
autoload :StreamingBuffer
|
|
end
|
|
|
|
autoload_at "action_view/flows" do
|
|
autoload :OutputFlow
|
|
autoload :StreamingFlow
|
|
end
|
|
|
|
autoload_at "action_view/template/error" do
|
|
autoload :MissingTemplate
|
|
autoload :ActionViewError
|
|
autoload :EncodingError
|
|
autoload :TemplateError
|
|
autoload :SyntaxErrorInTemplate
|
|
autoload :WrongEncodingError
|
|
end
|
|
end
|
|
|
|
autoload :CacheExpiry
|
|
autoload :TestCase
|
|
|
|
def self.eager_load!
|
|
super
|
|
ActionView::Helpers.eager_load!
|
|
ActionView::Template.eager_load!
|
|
end
|
|
end
|
|
|
|
require "active_support/core_ext/string/output_safety"
|
|
|
|
ActiveSupport.on_load(:i18n) do
|
|
I18n.load_path << File.expand_path("action_view/locale/en.yml", __dir__)
|
|
end
|