rails--rails/activerecord/test/models/price_estimate.rb at e77293786c7f80e4b75f229836a7e8ffbddda30d - kotovalexarian-likes-github/rails--rails - Forgejo by Causa Arcana

kotovalexarian-likes-github/rails--rails

mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Ryuta Kamizono 2fece9036d Fix numericality validator not to be affected by custom getter

Since fe9547b6, numericality validator would parse raw value only when a
value came from user to work type casting to a value from database.

But that was caused a regression that the validator would work against
getter value instead of parsed raw value, a getter is sometimes
customized by people. #33550

There we never guarantees that the value before type cast was going to
the used in this validation (actually here is only place that getter
value might not be used), but we should not change the behavior unless
there is some particular reason.

The purpose of fe9547b6 is to work type casting to a value from
database. We could achieve the purpose by using `read_attribute`,
without using getter value.

Fixes #33550.

2018-08-13 23:28:46 +09:00

14 lines

283 B

Ruby

Raw Blame History

 # frozen_string_literal: true
 class PriceEstimate < ActiveRecord::Base
   include ActiveSupport::NumberHelper
   belongs_to :estimate_of, polymorphic: true
   belongs_to :thing, polymorphic: true
   validates_numericality_of :price
   def price
     number_to_currency super
   end
 end