mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
ea3185ebdd
Previously if you did `app.config.active_support.deprecation = :silence`, some work would still be done on each call to `ActiveSupport::Deprecation.warn`. Specifically [checking the backtrace](12372c5482/activesupport/lib/active_support/deprecation/reporting.rb (L21)), generating the [deprecation warning](12372c5482/activesupport/lib/active_support/deprecation/reporting.rb (L22)), and [checking if the warning is disallowed](12372c5482/activesupport/lib/active_support/deprecation/reporting.rb (L23)). In very hot paths, this could cause performance issues. This PR lets you turn off deprecation reporting entirely for a specific environment. ```ruby config.active_support.report_deprecations = false ``` ^ so has the same outcome as: ```ruby config.active_support.deprecation = :silence config.active_support.disallowed_deprecation = :silence ``` But it will short circuit [here](12372c5482/activesupport/lib/active_support/deprecation/reporting.rb (L19)).
942 lines
28 KiB
Ruby
942 lines
28 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require_relative "abstract_unit"
|
|
require "active_support/testing/stream"
|
|
|
|
class Deprecatee
|
|
def initialize
|
|
@request = ActiveSupport::Deprecation::DeprecatedInstanceVariableProxy.new(self, :request)
|
|
@_request = "there we go"
|
|
end
|
|
def request; @_request end
|
|
def old_request; @request end
|
|
|
|
def partially(foo = nil)
|
|
ActiveSupport::Deprecation.warn("calling with foo=nil is out") if foo.nil?
|
|
end
|
|
|
|
def not() 2 end
|
|
def none() 1 end
|
|
def one(a) a end
|
|
def multi(a, b, c) [a, b, c] end
|
|
deprecate :none, :one, :multi
|
|
|
|
def a; end
|
|
def b; end
|
|
def c; end
|
|
def d; end
|
|
def e; end
|
|
deprecate :a, :b, c: :e, d: "you now need to do something extra for this one"
|
|
|
|
def f=(v); end
|
|
deprecate :f=
|
|
|
|
deprecate :g
|
|
def g(h) h end
|
|
|
|
module B
|
|
C = 1
|
|
end
|
|
A = ActiveSupport::Deprecation::DeprecatedConstantProxy.new("Deprecatee::A", "Deprecatee::B::C")
|
|
|
|
module New
|
|
class Descendant; end
|
|
end
|
|
Old = ActiveSupport::Deprecation::DeprecatedConstantProxy.new("Deprecatee::Old", "Deprecatee::New")
|
|
end
|
|
|
|
class DeprecateeWithAccessor
|
|
include ActiveSupport::Deprecation::DeprecatedConstantAccessor
|
|
|
|
module B
|
|
C = 1
|
|
end
|
|
deprecate_constant "A", "DeprecateeWithAccessor::B::C"
|
|
|
|
class NewException < StandardError; end
|
|
deprecate_constant "OldException", "DeprecateeWithAccessor::NewException"
|
|
end
|
|
|
|
class DeprecationTest < ActiveSupport::TestCase
|
|
include ActiveSupport::Testing::Stream
|
|
|
|
def setup
|
|
# Track the last warning.
|
|
@old_behavior = ActiveSupport::Deprecation.behavior
|
|
@last_message = nil
|
|
ActiveSupport::Deprecation.behavior = Proc.new { |message| @last_message = message }
|
|
|
|
@dtc = Deprecatee.new
|
|
end
|
|
|
|
def teardown
|
|
ActiveSupport::Deprecation.behavior = @old_behavior
|
|
end
|
|
|
|
def test_inline_deprecation_warning
|
|
assert_deprecated(/foo=nil/) do
|
|
@dtc.partially
|
|
end
|
|
end
|
|
|
|
def test_undeprecated
|
|
assert_not_deprecated do
|
|
assert_equal 2, @dtc.not
|
|
end
|
|
end
|
|
|
|
def test_deprecate_method_on_class
|
|
assert_deprecated(/none is deprecated/) do
|
|
assert_equal 1, @dtc.none
|
|
end
|
|
|
|
assert_deprecated(/one is deprecated/) do
|
|
assert_equal 1, @dtc.one(1)
|
|
end
|
|
|
|
assert_deprecated(/multi is deprecated/) do
|
|
assert_equal [1, 2, 3], @dtc.multi(1, 2, 3)
|
|
end
|
|
end
|
|
|
|
def test_deprecate_method_doesnt_expand_positional_argument_hash
|
|
hash = { k: 1 }
|
|
|
|
assert_deprecated(/one is deprecated/) do
|
|
assert_same hash, @dtc.one(hash)
|
|
end
|
|
|
|
assert_deprecated(/g is deprecated/) do
|
|
assert_same hash, @dtc.g(hash)
|
|
end
|
|
end
|
|
|
|
def test_deprecate_object
|
|
deprecated_object = ActiveSupport::Deprecation::DeprecatedObjectProxy.new(Object.new, ":bomb:")
|
|
assert_deprecated(/:bomb:/) { deprecated_object.to_s }
|
|
end
|
|
|
|
def test_nil_behavior_is_ignored
|
|
ActiveSupport::Deprecation.behavior = nil
|
|
assert_deprecated(/foo=nil/) { @dtc.partially }
|
|
end
|
|
|
|
def test_several_behaviors
|
|
@a, @b, @c = nil, nil, nil
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @a = msg },
|
|
lambda { |msg, callstack| @b = msg },
|
|
lambda { |*args| @c = args },
|
|
]
|
|
|
|
@dtc.partially
|
|
assert_match(/foo=nil/, @a)
|
|
assert_match(/foo=nil/, @b)
|
|
assert_equal 4, @c.size
|
|
end
|
|
|
|
def test_raise_behaviour
|
|
ActiveSupport::Deprecation.behavior = :raise
|
|
|
|
message = "Revise this deprecated stuff now!"
|
|
callstack = caller_locations
|
|
|
|
e = assert_raise ActiveSupport::DeprecationException do
|
|
ActiveSupport::Deprecation.behavior.first.call(message, callstack, "horizon", "gem")
|
|
end
|
|
assert_equal message, e.message
|
|
assert_equal callstack.map(&:to_s), e.backtrace.map(&:to_s)
|
|
end
|
|
|
|
def test_default_stderr_behavior
|
|
ActiveSupport::Deprecation.behavior = :stderr
|
|
behavior = ActiveSupport::Deprecation.behavior.first
|
|
|
|
content = capture(:stderr) {
|
|
assert_nil behavior.call("Some error!", ["call stack!"], "horizon", "gem")
|
|
}
|
|
assert_match(/Some error!/, content)
|
|
assert_match(/call stack!/, content)
|
|
end
|
|
|
|
def test_default_stderr_behavior_with_warn_method
|
|
ActiveSupport::Deprecation.behavior = :stderr
|
|
|
|
content = capture(:stderr) {
|
|
ActiveSupport::Deprecation.warn("Instance error!", ["instance call stack!"])
|
|
}
|
|
|
|
assert_match(/Instance error!/, content)
|
|
assert_match(/instance call stack!/, content)
|
|
end
|
|
|
|
def test_default_silence_behavior
|
|
ActiveSupport::Deprecation.behavior = :silence
|
|
behavior = ActiveSupport::Deprecation.behavior.first
|
|
|
|
stderr_output = capture(:stderr) {
|
|
assert_nil behavior.call("Some error!", ["call stack!"], "horizon", "gem")
|
|
}
|
|
assert_empty stderr_output
|
|
end
|
|
|
|
def test_default_notify_behavior
|
|
ActiveSupport::Deprecation.behavior = :notify
|
|
behavior = ActiveSupport::Deprecation.behavior.first
|
|
|
|
begin
|
|
events = []
|
|
ActiveSupport::Notifications.subscribe("deprecation.my_gem_custom") { |*args|
|
|
events << args.extract_options!
|
|
}
|
|
|
|
assert_nil behavior.call("Some error!", ["call stack!"], "horizon", "MyGem::Custom")
|
|
assert_equal 1, events.size
|
|
assert_equal "Some error!", events.first[:message]
|
|
assert_equal ["call stack!"], events.first[:callstack]
|
|
assert_equal "horizon", events.first[:deprecation_horizon]
|
|
assert_equal "MyGem::Custom", events.first[:gem_name]
|
|
ensure
|
|
ActiveSupport::Notifications.unsubscribe("deprecation.my_gem_custom")
|
|
end
|
|
end
|
|
|
|
def test_default_invalid_behavior
|
|
e = assert_raises(ArgumentError) do
|
|
ActiveSupport::Deprecation.behavior = :invalid
|
|
end
|
|
|
|
assert_equal ":invalid is not a valid deprecation behavior.", e.message
|
|
end
|
|
|
|
def test_deprecated_instance_variable_proxy
|
|
assert_not_deprecated { @dtc.request.size }
|
|
|
|
assert_deprecated("@request.size") { assert_equal @dtc.request.size, @dtc.old_request.size }
|
|
assert_deprecated("@request.to_s") { assert_equal @dtc.request.to_s, @dtc.old_request.to_s }
|
|
end
|
|
|
|
def test_deprecated_instance_variable_proxy_shouldnt_warn_on_inspect
|
|
assert_not_deprecated { assert_equal @dtc.request.inspect, @dtc.old_request.inspect }
|
|
end
|
|
|
|
def test_deprecated_constant_proxy
|
|
assert_not_deprecated { Deprecatee::B::C }
|
|
assert_deprecated("Deprecatee::A") { assert_equal Deprecatee::B::C, Deprecatee::A }
|
|
assert_not_deprecated { assert_equal Deprecatee::B::C.class, Deprecatee::A.class }
|
|
end
|
|
|
|
def test_deprecated_constant_descendant
|
|
assert_not_deprecated { Deprecatee::New::Descendant }
|
|
|
|
assert_deprecated("Deprecatee::Old") do
|
|
assert_equal Deprecatee::Old::Descendant, Deprecatee::New::Descendant
|
|
end
|
|
|
|
assert_raises(NameError) do
|
|
assert_deprecated("Deprecatee::Old") { Deprecatee::Old::NON_EXISTENCE }
|
|
end
|
|
end
|
|
|
|
def test_deprecated_constant_accessor
|
|
assert_not_deprecated { DeprecateeWithAccessor::B::C }
|
|
assert_deprecated("DeprecateeWithAccessor::A") { assert_equal DeprecateeWithAccessor::B::C, DeprecateeWithAccessor::A }
|
|
end
|
|
|
|
def test_deprecated_constant_accessor_exception
|
|
raise DeprecateeWithAccessor::NewException.new("Test")
|
|
rescue DeprecateeWithAccessor::OldException => e
|
|
assert_kind_of DeprecateeWithAccessor::NewException, e
|
|
end
|
|
|
|
def test_assert_deprecated_raises_when_method_not_deprecated
|
|
assert_raises(Minitest::Assertion) { assert_deprecated { @dtc.not } }
|
|
end
|
|
|
|
def test_assert_not_deprecated
|
|
assert_raises(Minitest::Assertion) { assert_not_deprecated { @dtc.partially } }
|
|
end
|
|
|
|
def test_assert_deprecation_without_match
|
|
assert_deprecated do
|
|
@dtc.partially
|
|
end
|
|
end
|
|
|
|
def test_assert_deprecated_matches_any_warning
|
|
assert_deprecated "abc" do
|
|
ActiveSupport::Deprecation.warn "abc"
|
|
ActiveSupport::Deprecation.warn "def"
|
|
end
|
|
rescue Minitest::Assertion
|
|
flunk "assert_deprecated should match any warning in block, not just the last one"
|
|
end
|
|
|
|
def test_assert_not_deprecated_returns_result_of_block
|
|
assert_equal 123, assert_not_deprecated { 123 }
|
|
end
|
|
|
|
def test_assert_deprecated_returns_result_of_block
|
|
result = assert_deprecated("abc") do
|
|
ActiveSupport::Deprecation.warn "abc"
|
|
123
|
|
end
|
|
assert_equal 123, result
|
|
end
|
|
|
|
def test_assert_deprecated_warn_work_with_default_behavior
|
|
ActiveSupport::Deprecation.instance_variable_set("@behavior", nil)
|
|
assert_deprecated("abc") do
|
|
ActiveSupport::Deprecation.warn "abc"
|
|
end
|
|
end
|
|
|
|
def test_silence
|
|
ActiveSupport::Deprecation.silence do
|
|
assert_not_deprecated { @dtc.partially }
|
|
end
|
|
|
|
ActiveSupport::Deprecation.silenced = true
|
|
assert ActiveSupport::Deprecation.silenced
|
|
|
|
assert_not_deprecated { @dtc.partially }
|
|
|
|
ActiveSupport::Deprecation.silenced = false
|
|
assert_not ActiveSupport::Deprecation.silenced
|
|
end
|
|
|
|
def test_silence_threaded
|
|
barrier = Concurrent::CyclicBarrier.new(2)
|
|
|
|
th = Thread.new do
|
|
ActiveSupport::Deprecation.silence do
|
|
barrier.wait
|
|
barrier.wait
|
|
assert_not_deprecated { ActiveSupport::Deprecation.warn "abc" }
|
|
end
|
|
assert_deprecated("abc") { ActiveSupport::Deprecation.warn "abc" }
|
|
end
|
|
|
|
barrier.wait
|
|
|
|
assert_deprecated("abc") { ActiveSupport::Deprecation.warn "abc" }
|
|
|
|
ActiveSupport::Deprecation.silence do
|
|
assert_not_deprecated { ActiveSupport::Deprecation.warn "abc" }
|
|
end
|
|
|
|
assert_deprecated("abc") { ActiveSupport::Deprecation.warn "abc" }
|
|
|
|
barrier.wait
|
|
th.join
|
|
ensure
|
|
th.kill
|
|
end
|
|
|
|
def test_deprecation_without_explanation
|
|
assert_deprecated { @dtc.a }
|
|
assert_deprecated { @dtc.b }
|
|
assert_deprecated { @dtc.f = :foo }
|
|
end
|
|
|
|
def test_deprecation_with_alternate_method
|
|
assert_deprecated(/use e instead/) { @dtc.c }
|
|
end
|
|
|
|
def test_deprecation_with_explicit_message
|
|
assert_deprecated(/you now need to do something extra for this one/) { @dtc.d }
|
|
end
|
|
|
|
def test_deprecation_in_other_object
|
|
messages = []
|
|
|
|
klass = Class.new do
|
|
delegate :warn, :behavior=, to: ActiveSupport::Deprecation
|
|
end
|
|
|
|
o = klass.new
|
|
o.behavior = Proc.new { |message, callstack| messages << message }
|
|
assert_difference("messages.size") do
|
|
o.warn("warning")
|
|
end
|
|
end
|
|
|
|
def test_deprecated_method_with_custom_method_warning
|
|
deprecator = deprecator_with_messages
|
|
|
|
class << deprecator
|
|
private
|
|
def deprecated_method_warning(method, message)
|
|
"deprecator.deprecated_method_warning.#{method}"
|
|
end
|
|
end
|
|
|
|
deprecatee = Class.new do
|
|
def method
|
|
end
|
|
deprecate :method, deprecator: deprecator
|
|
end
|
|
|
|
deprecatee.new.method
|
|
assert deprecator.messages.first.match("DEPRECATION WARNING: deprecator.deprecated_method_warning.method")
|
|
end
|
|
|
|
def test_deprecate_with_custom_deprecator
|
|
custom_deprecator = Struct.new(:deprecation_warning).new
|
|
|
|
assert_called_with(custom_deprecator, :deprecation_warning, [:method, nil]) do
|
|
klass = Class.new do
|
|
def method
|
|
end
|
|
deprecate :method, deprecator: custom_deprecator
|
|
end
|
|
|
|
klass.new.method
|
|
end
|
|
end
|
|
|
|
def test_deprecated_constant_with_deprecator_given
|
|
deprecator = deprecator_with_messages
|
|
klass = Class.new
|
|
klass.const_set(:OLD, ActiveSupport::Deprecation::DeprecatedConstantProxy.new("klass::OLD", "Object", deprecator))
|
|
assert_difference("deprecator.messages.size") do
|
|
klass::OLD.to_s
|
|
end
|
|
end
|
|
|
|
def test_deprecated_constant_with_custom_message
|
|
deprecator = deprecator_with_messages
|
|
|
|
klass = Class.new
|
|
klass.const_set(:OLD, ActiveSupport::Deprecation::DeprecatedConstantProxy.new("klass::OLD", "Object", deprecator, message: "foo"))
|
|
|
|
klass::OLD.to_s
|
|
assert_match "foo", deprecator.messages.last
|
|
end
|
|
|
|
def test_deprecated_instance_variable_with_instance_deprecator
|
|
deprecator = deprecator_with_messages
|
|
|
|
klass = Class.new() do
|
|
def initialize(deprecator)
|
|
@request = ActiveSupport::Deprecation::DeprecatedInstanceVariableProxy.new(self, :request, :@request, deprecator)
|
|
@_request = :a_request
|
|
end
|
|
def request; @_request end
|
|
def old_request; @request end
|
|
end
|
|
|
|
assert_difference("deprecator.messages.size") { klass.new(deprecator).old_request.to_s }
|
|
end
|
|
|
|
def test_deprecated_instance_variable_with_given_deprecator
|
|
deprecator = deprecator_with_messages
|
|
|
|
klass = Class.new do
|
|
define_method(:initialize) do
|
|
@request = ActiveSupport::Deprecation::DeprecatedInstanceVariableProxy.new(self, :request, :@request, deprecator)
|
|
@_request = :a_request
|
|
end
|
|
def request; @_request end
|
|
def old_request; @request end
|
|
end
|
|
|
|
assert_difference("deprecator.messages.size") { klass.new.old_request.to_s }
|
|
end
|
|
|
|
def test_delegate_deprecator_instance
|
|
klass = Class.new do
|
|
attr_reader :last_message
|
|
delegate :warn, :behavior=, to: ActiveSupport::Deprecation
|
|
|
|
def initialize
|
|
self.behavior = [Proc.new { |message| @last_message = message }]
|
|
end
|
|
|
|
def deprecated_method
|
|
warn(deprecated_method_warning(:deprecated_method, "You are calling deprecated method"))
|
|
end
|
|
|
|
private
|
|
def deprecated_method_warning(method_name, message = nil)
|
|
message || "#{method_name} is deprecated and will be removed from This Library"
|
|
end
|
|
end
|
|
|
|
object = klass.new
|
|
object.deprecated_method
|
|
assert_match(/You are calling deprecated method/, object.last_message)
|
|
end
|
|
|
|
def test_default_deprecation_horizon_should_always_bigger_than_current_rails_version
|
|
assert_operator ActiveSupport::Deprecation.new.deprecation_horizon, :>, ActiveSupport::VERSION::STRING
|
|
end
|
|
|
|
def test_default_gem_name
|
|
deprecator = ActiveSupport::Deprecation.new
|
|
|
|
deprecator.send(:deprecated_method_warning, :deprecated_method, "You are calling deprecated method").tap do |message|
|
|
assert_match(/is deprecated and will be removed from Rails/, message)
|
|
end
|
|
end
|
|
|
|
def test_custom_gem_name
|
|
deprecator = ActiveSupport::Deprecation.new("2.0", "Custom")
|
|
|
|
deprecator.send(:deprecated_method_warning, :deprecated_method, "You are calling deprecated method").tap do |message|
|
|
assert_match(/is deprecated and will be removed from Custom/, message)
|
|
end
|
|
end
|
|
|
|
def test_deprecate_work_before_define_method
|
|
assert_deprecated(/g is deprecated/) { @dtc.g(1) }
|
|
end
|
|
|
|
def test_config_disallows_no_deprecations_by_default
|
|
assert_equal ActiveSupport::Deprecation.disallowed_warnings, []
|
|
end
|
|
|
|
def test_allows_configuration_of_disallowed_warnings
|
|
resetting_disallowed_deprecation_config do
|
|
config_warnings = ["unsafe_method is going away"]
|
|
ActiveSupport::Deprecation.disallowed_warnings = config_warnings
|
|
assert_equal ActiveSupport::Deprecation.disallowed_warnings, config_warnings
|
|
end
|
|
end
|
|
|
|
def test_no_disallowed_behavior_with_no_disallowed_messages
|
|
resetting_disallowed_deprecation_config do
|
|
ActiveSupport::Deprecation.disallowed_behavior = :raise
|
|
@dtc.none
|
|
@dtc.partially
|
|
end
|
|
end
|
|
|
|
def test_disallowed_behavior_does_not_apply_to_allowed_messages
|
|
resetting_disallowed_deprecation_config do
|
|
ActiveSupport::Deprecation.disallowed_behavior = :raise
|
|
ActiveSupport::Deprecation.disallowed_warnings = ["foo=nil"]
|
|
|
|
@dtc.none
|
|
end
|
|
end
|
|
|
|
def test_disallowed_behavior_when_disallowed_message_configured_with_substring
|
|
resetting_disallowed_deprecation_config do
|
|
ActiveSupport::Deprecation.disallowed_behavior = :raise
|
|
ActiveSupport::Deprecation.disallowed_warnings = ["foo=nil"]
|
|
|
|
e = assert_raise ActiveSupport::DeprecationException do
|
|
@dtc.partially
|
|
end
|
|
|
|
message = "DEPRECATION WARNING: calling with foo=nil is out"
|
|
assert_match message, e.message
|
|
end
|
|
end
|
|
|
|
def test_disallowed_behavior_when_disallowed_message_configured_with_symbol_treated_as_substring
|
|
resetting_disallowed_deprecation_config do
|
|
ActiveSupport::Deprecation.disallowed_behavior = :raise
|
|
ActiveSupport::Deprecation.disallowed_warnings = [:foo]
|
|
|
|
e = assert_raise ActiveSupport::DeprecationException do
|
|
@dtc.partially
|
|
end
|
|
|
|
message = "DEPRECATION WARNING: calling with foo=nil is out"
|
|
assert_match message, e.message
|
|
end
|
|
end
|
|
|
|
def test_disallowed_behavior_when_disallowed_message_configured_with_regular_expression
|
|
resetting_disallowed_deprecation_config do
|
|
ActiveSupport::Deprecation.disallowed_behavior = :raise
|
|
ActiveSupport::Deprecation.disallowed_warnings = [/none|one*/]
|
|
|
|
e = assert_raise ActiveSupport::DeprecationException do
|
|
@dtc.none
|
|
end
|
|
|
|
message = "none is deprecated"
|
|
assert_match message, e.message
|
|
|
|
e = assert_raise ActiveSupport::DeprecationException do
|
|
@dtc.one
|
|
end
|
|
|
|
message = "one is deprecated"
|
|
assert_match message, e.message
|
|
end
|
|
end
|
|
|
|
def test_disallowed_behavior_when_disallowed_message_configured_with_scalar_symbol_all
|
|
resetting_disallowed_deprecation_config do
|
|
allowed_message = nil
|
|
disallowed_message = nil
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| allowed_message = msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_behavior = [
|
|
lambda { |msg, callstack, horizon, gem| disallowed_message = msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_warnings = :all
|
|
|
|
@dtc.partially
|
|
assert_nil allowed_message
|
|
assert_match(/foo=nil/, disallowed_message)
|
|
|
|
allowed_message = nil
|
|
disallowed_message = nil
|
|
@dtc.none
|
|
assert_nil allowed_message
|
|
assert_match(/none is deprecated/, disallowed_message)
|
|
end
|
|
end
|
|
|
|
def test_different_behaviors_for_allowed_and_disallowed_messages
|
|
resetting_disallowed_deprecation_config do
|
|
@a, @b, @c, @d = nil, nil, nil, nil
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @a = msg },
|
|
lambda { |msg, callstack| @b = msg },
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @c = msg },
|
|
lambda { |msg, callstack| @d = msg },
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_warnings = ["foo=nil"]
|
|
|
|
@dtc.partially
|
|
@dtc.none
|
|
|
|
assert_match(/none is deprecated/, @a)
|
|
assert_match(/none is deprecated/, @b)
|
|
assert_match(/foo=nil/, @c)
|
|
assert_match(/foo=nil/, @d)
|
|
end
|
|
end
|
|
|
|
def test_allow
|
|
resetting_disallowed_deprecation_config do
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_allowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_disallowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_warnings = [
|
|
"b is deprecated",
|
|
"c is deprecated"
|
|
]
|
|
|
|
ActiveSupport::Deprecation.allow do
|
|
@dtc.a
|
|
@dtc.b
|
|
@dtc.c
|
|
end
|
|
|
|
assert_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/c is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_empty @warnings_disallowed
|
|
end
|
|
end
|
|
|
|
def test_allow_only_matching_warnings
|
|
resetting_disallowed_deprecation_config do
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_allowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_disallowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_warnings = [
|
|
"a is deprecated",
|
|
"b is deprecated",
|
|
"c is deprecated",
|
|
]
|
|
|
|
ActiveSupport::Deprecation.allow ["b is", "c is"] do
|
|
@dtc.none
|
|
@dtc.a
|
|
@dtc.b
|
|
@dtc.c
|
|
end
|
|
|
|
assert_match(/none is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_no_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/b is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/c is deprecated/, @warnings_allowed.join("\n"))
|
|
|
|
assert_no_match(/none is deprecated/, @warnings_disallowed.join("\n"))
|
|
assert_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
assert_no_match(/b is deprecated/, @warnings_disallowed.join("\n"))
|
|
assert_no_match(/c is deprecated/, @warnings_disallowed.join("\n"))
|
|
end
|
|
end
|
|
|
|
def test_allow_with_symbol
|
|
resetting_disallowed_deprecation_config do
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_allowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_disallowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_warnings = [
|
|
"a is deprecated",
|
|
"b is deprecated",
|
|
"c is deprecated",
|
|
]
|
|
|
|
ActiveSupport::Deprecation.allow [:"b is", :"c is"] do
|
|
@dtc.none
|
|
@dtc.a
|
|
@dtc.b
|
|
@dtc.c
|
|
end
|
|
|
|
assert_match(/none is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_no_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/b is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/c is deprecated/, @warnings_allowed.join("\n"))
|
|
|
|
assert_no_match(/none is deprecated/, @warnings_disallowed.join("\n"))
|
|
assert_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
assert_no_match(/b is deprecated/, @warnings_disallowed.join("\n"))
|
|
assert_no_match(/c is deprecated/, @warnings_disallowed.join("\n"))
|
|
end
|
|
end
|
|
|
|
def test_allow_with_regexp
|
|
resetting_disallowed_deprecation_config do
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_allowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_disallowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_warnings = [
|
|
"a is deprecated",
|
|
"b is deprecated",
|
|
"c is deprecated",
|
|
]
|
|
|
|
ActiveSupport::Deprecation.allow [/(b|c)\sis/] do
|
|
@dtc.none
|
|
@dtc.a
|
|
@dtc.b
|
|
@dtc.c
|
|
end
|
|
|
|
assert_match(/none is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_no_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/b is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/c is deprecated/, @warnings_allowed.join("\n"))
|
|
|
|
assert_no_match(/none is deprecated/, @warnings_disallowed.join("\n"))
|
|
assert_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
assert_no_match(/b is deprecated/, @warnings_disallowed.join("\n"))
|
|
assert_no_match(/c is deprecated/, @warnings_disallowed.join("\n"))
|
|
end
|
|
end
|
|
|
|
def test_allow_only_has_effect_inside_provided_block
|
|
resetting_disallowed_deprecation_config do
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_allowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_disallowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_warnings = [
|
|
"a is deprecated"
|
|
]
|
|
|
|
ActiveSupport::Deprecation.allow "a is deprecated and will" do
|
|
@dtc.a
|
|
end
|
|
|
|
assert_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_no_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
@dtc.a
|
|
|
|
assert_no_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
end
|
|
end
|
|
|
|
def test_allow_only_has_effect_on_the_thread_on_which_it_was_called
|
|
th1, th2 = nil, nil
|
|
resetting_disallowed_deprecation_config do
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_allowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_disallowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_warnings = [
|
|
"a is deprecated"
|
|
]
|
|
|
|
th1 = Thread.new do
|
|
# barrier.wait
|
|
ActiveSupport::Deprecation.allow "a is deprecated and will" do
|
|
th2 = Thread.new do
|
|
@dtc.a
|
|
end
|
|
th2.join
|
|
end
|
|
end
|
|
|
|
th1.join
|
|
|
|
assert_no_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
end
|
|
ensure
|
|
th1.kill
|
|
th2.kill
|
|
end
|
|
|
|
def test_is_a_noop_based_on_if_kwarg_truthy_or_falsey
|
|
resetting_disallowed_deprecation_config do
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_allowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_disallowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_warnings = [
|
|
"a is deprecated"
|
|
]
|
|
|
|
ActiveSupport::Deprecation.allow "a is deprecated and will", if: true do
|
|
@dtc.a
|
|
end
|
|
|
|
assert_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_no_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.allow "a is deprecated and will", if: Object.new do
|
|
@dtc.a
|
|
end
|
|
|
|
assert_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_no_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.allow "a is deprecated and will", if: false do
|
|
@dtc.a
|
|
end
|
|
|
|
assert_no_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.allow "a is deprecated and will", if: nil do
|
|
@dtc.a
|
|
end
|
|
|
|
assert_no_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
end
|
|
end
|
|
|
|
def test_is_a_noop_based_on_if_kwarg_using_proc
|
|
resetting_disallowed_deprecation_config do
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_allowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_behavior = [
|
|
lambda { |msg, callstack, horizon, gem| @warnings_disallowed << msg }
|
|
]
|
|
|
|
ActiveSupport::Deprecation.disallowed_warnings = [
|
|
"a is deprecated"
|
|
]
|
|
|
|
ActiveSupport::Deprecation.allow "a is deprecated and will", if: Proc.new { true } do
|
|
@dtc.a
|
|
end
|
|
|
|
assert_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_no_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
|
|
@warnings_allowed, @warnings_disallowed = [], []
|
|
|
|
ActiveSupport::Deprecation.allow "a is deprecated and will", if: Proc.new { false } do
|
|
@dtc.a
|
|
end
|
|
|
|
assert_no_match(/a is deprecated/, @warnings_allowed.join("\n"))
|
|
assert_match(/a is deprecated/, @warnings_disallowed.join("\n"))
|
|
end
|
|
end
|
|
|
|
private
|
|
def deprecator_with_messages
|
|
klass = Class.new(ActiveSupport::Deprecation)
|
|
deprecator = klass.new
|
|
deprecator.behavior = Proc.new { |message, callstack| deprecator.messages << message }
|
|
def deprecator.messages
|
|
@messages ||= []
|
|
end
|
|
deprecator
|
|
end
|
|
|
|
def resetting_disallowed_deprecation_config
|
|
original_deprecations = ActiveSupport::Deprecation.disallowed_warnings
|
|
original_behaviors = ActiveSupport::Deprecation.disallowed_behavior
|
|
yield
|
|
ensure
|
|
ActiveSupport::Deprecation.disallowed_warnings = original_deprecations
|
|
ActiveSupport::Deprecation.disallowed_behavior = original_behaviors
|
|
end
|
|
end
|